From patchwork Fri Jul 13 14:27:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 141895 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp873247ljj; Fri, 13 Jul 2018 07:28:06 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcfLBtHKS6rHwlGQZpSBs+STFFmBada8S5XMz96jLsAddfpuZ7l1XjmsDeRV71Bu6gxc5O0 X-Received: by 2002:a63:571d:: with SMTP id l29-v6mr6142649pgb.296.1531492086307; Fri, 13 Jul 2018 07:28:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531492086; cv=none; d=google.com; s=arc-20160816; b=RlvzVIZGD/lDfEChQuB7gFOhungoMZ3Y7nmGO+smOcJsD92fh1qPXNpGaxbAeEanEN 03XoCjROB4u5B+/B6lJWwt15XYrftSs6QQu3cTowoO04vMYesNZfzgkNcyJkUqEOGp/a ZkwADfDQ6q4km+oPwi6rZaBg/XF+SXcPPQbkbTSpFPfrosOHr5nJxi/ZxNeOozieUMzl ExKVJkilpIJ6xipMiAeDALdEjsL+i2Y3HPfHCjubMBgp9QePw6jj5iD6vZOon1GMFO7V 1MjBz9LAB21BRLSUUG/AbfnU/k7lXI8MdjmaalY8R0ISAUz4+dAIFAaKwBgNqrshsqGP sF/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=u1gtGYBPk7MAvL33hGVqlQv4YSkv7cd6Mj+5DALsgOw=; b=EpUD/W2YVJceBF32EM/amkz/3uMFugEDIBYWdZfSCy8mXBOTcc5ndJP71WQIsYs4fc v8AO53huHEwUObldzcfsfU4qJTpJ8mnjP78Zrz7kW3PAcF72EQ1IlTrMSpEmtR3B2YoA O/+YqUrAYk0DDfhr8Irdg617Oq4D4E/GWZxUjTdnWRXEJSRmn5BQGnhix9/KhSPpUDyx YZKPjYzk00BUJVjUykGX+izN5qW+Ekc2px+Mjq7lXOROhvRwuELBglDHF3hkzqJBALVQ rbGengM7+NMbYrIxiIBsOg33ObslGpt2SS5ZifOnlR6rEOC5Zt2G6XZAtkrsqdGAHWU4 S80w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r59-v6si23784100plb.187.2018.07.13.07.28.06; Fri, 13 Jul 2018 07:28:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729762AbeGMOmz (ORCPT + 31 others); Fri, 13 Jul 2018 10:42:55 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:39443 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729644AbeGMOmz (ORCPT ); Fri, 13 Jul 2018 10:42:55 -0400 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue007 [212.227.15.129]) with ESMTPA (Nemesis) id 0MUyXA-1fYVNe3BUa-00YCYW; Fri, 13 Jul 2018 16:27:54 +0200 From: Arnd Bergmann To: David Howells Cc: Arnd Bergmann , Al Viro , Anna Schumaker , linux-cachefs@redhat.com, linux-kernel@vger.kernel.org Subject: [PATCH] [v2, RESEND] cachefiles: avoid deprecated get_seconds() Date: Fri, 13 Jul 2018 16:27:44 +0200 Message-Id: <20180713142753.3139243-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:yeXq+fZ8EN7ss+kOiJ73y1gVzdEiikqs1lzJtaF4wDhZqXLb19t EgLxKf8Am/xOmHf5hsk7DbhPo0QNFYgS2UJ7mcltC+kHWPUcs85jnfWv0TAbZCB9dC9S34L GIMMB/MnREtyvefCgkq8CX5S7LK6nDsJC/HkLyivWKOHCc4Q/Cx2EYRq0SXOBiCvPcTb1xo IjLbyahKGSd1ox6ha442Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:beObR7mqFZo=:QazBiH1Z2YyBqA3Mjzj6um ArtFvSsRT0HVvhQgRXG9ZhnwzgcOJ07wftFjhsyzZhsPPxXnfAmpYh3F0saXZXhQFrL9XzTdx MbOqe/AOhGAwiE99wNz8kkr5CtBSZ3lK32Jn5g8EOjHNW9X7d16NeLK6f/CFFqihuNsf2odjm BdE4QY3Evg9rtz/P37EHox/Jfi4GkaOL27Bsgi2PgrdQox9jm4rEpAqQXEYs7mdU36XPloslj 5aD+us0FowYVkyx6zX/YJALivALxzXnMZYSv+pk9wG4ifix2QRQWkXgNpsKfm02AtrEQWJCXb yqIZv2U927p/nFR4PYQg/Z6To1BZkODsVRsSf9xX3sBz+S8lNnSTD8BnQOrwkhrQF/13E3s0o W7lZCbxEmKgS+isQAOu01eb376d4rAHDCtdDguX9R5nh8m9uHAt+szTdG3j3EZIxmWr4Dg7qW 8LLgJG00I26HldZf5Ht6SWJEqG0sXly6nTQ/mLIxFM6Sj/9fv6P02pVcAKAY+p+ZNqwMusLJN 6QtTM5bHyDbUZl6EuWzDsF6HI5JeBc/o/yJZ9ZMWimSO4t4GErRUgJQlIU1hOvH7B5OWzJoXy BR3iDntiO9Qd5UcC+fkR5Y/aCwMCA/C3XCQufrGeHq3wcAJr98pw9H8gCO9ARRCopitKqJQYo vLzg16YeRmz3mWpErZFojg6Fwl28OAlCZpYUH7s8fNqD9YdGVnGAmLnFC700yzE+0aGk= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org get_seconds() returns an unsigned long can overflow on some architectures and is deprecated because of that. In cachefs, we cast that number to a a 32-bit integer, which will overflow in year 2106 on all architectures. As confirmed by David Howells, the overflow probably isn't harmful in the end, since the timestamps are only used to make the file names unique, but they don't strictly have to be in monotonically increasing order since the files only exist in order to be deleted as quickly as possible. Moving to ktime_get_real_seconds() avoids the deprecated interface. Signed-off-by: Arnd Bergmann --- v2: only change to ktime_get_real_seconds() without printing the extra leading digits Originally submitted this on June 20, but got no reply. Resending this in case it got lost somewhere on the way. David, can you pick this up? --- fs/cachefiles/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c index ab0bbe93b398..0a38978b8cd3 100644 --- a/fs/cachefiles/namei.c +++ b/fs/cachefiles/namei.c @@ -337,7 +337,7 @@ static int cachefiles_bury_object(struct cachefiles_cache *cache, try_again: /* first step is to make up a grave dentry in the graveyard */ sprintf(nbuffer, "%08x%08x", - (uint32_t) get_seconds(), + (uint32_t) ktime_get_real_seconds(), (uint32_t) atomic_inc_return(&cache->gravecounter)); /* do the multiway lock magic */