From patchwork Mon Jul 16 11:35:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 142011 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2311475ljj; Mon, 16 Jul 2018 04:36:49 -0700 (PDT) X-Google-Smtp-Source: AAOMgperlWCNX7Mc/rFHHEfPuK8OmhhwIWcAhORIxxZEyW3LmzTKiu685b6IsNE1dveyP2PXJklB X-Received: by 2002:a65:4541:: with SMTP id x1-v6mr14946461pgr.26.1531741009010; Mon, 16 Jul 2018 04:36:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531741009; cv=none; d=google.com; s=arc-20160816; b=f4PHtAc/boG1lGCuR3P9XxLRTZF92dMlyK6TbZI2fVCcjzaHtV9veAsoDXWhjg3U8w +hHRwHQ9y91AzFeAIsNN0lkKRH7qLBUtKfel79hqTbZU8jz49i77gyo1v/SKLvFXCN9S PaRwstQOUqEkWhehljeUbcUWl0J6ZTy+NAq8JDJiRevSjWrRerWGMB+DvsKHC75Gz+T5 2+xFFGi8sot/ei1aQ5CmN/UcDUqITWf2ZXT9Ln1dkH7EwSyTXFDzmsC6s1aM8WpH8qam uVHjbzdDvIl2rjqihVPwY9PUtINhUq5vWwFzdnnjXSaF17Bj+2eYBRYWnSfdVeXls6/u h3rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=JNvG3eLHP0vyil+U68PGufNVjPg3Z649Xk1WFSlBycA=; b=bcANYidOMMbgFl0PcnZe0lz2vFQPeq8J4lu1h+He2iBXWJ9n//XwnYxoCDXIo1zpHN q1/CkSf2u4WskQKV+O2c2RcMgRgwaAVHvHTp9sTuD9mG1LNIaP9H6/ODZs2cx87GyzS8 d2MnFS0/W1+LhwOuJQTHPtHy2n+t4sIeb1czN4991FHGggFB6LEtv1e1uBKnttAhE/OR JeF/zL58Gg9G8Su3q5CaDPrLmho+zi5EAUnX3a4GQV3t1h28WDIstkgOza6lwcTZ0nbA ZkR01Elu1rA2EqAq9M+JQB27+1y4hJFD48F26FQV2Rdg8bbOn9opTvpaK+kkJu6EiPSI qMvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NBWIJUKl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6-v6si29801757pgn.143.2018.07.16.04.36.48; Mon, 16 Jul 2018 04:36:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NBWIJUKl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731305AbeGPMDr (ORCPT + 31 others); Mon, 16 Jul 2018 08:03:47 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:36016 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729601AbeGPMDq (ORCPT ); Mon, 16 Jul 2018 08:03:46 -0400 Received: by mail-lj1-f194.google.com with SMTP id u7-v6so27011284lji.3 for ; Mon, 16 Jul 2018 04:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JNvG3eLHP0vyil+U68PGufNVjPg3Z649Xk1WFSlBycA=; b=NBWIJUKl7PmtHd6WwJLHxbs8OnTZLSm+pyfHkT2JvYAf4jjG6V9IW8NnbeNogCio6i hK5woeI2AV7nowyVdx6GInIyyAN5t0keRsInv5cr+8EKNfzF8vYtbNoUM4WOb8IHtmLQ Z4jyyS4Q6MCbm2RJOCvwh+vNYiDczX+q3L+LE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JNvG3eLHP0vyil+U68PGufNVjPg3Z649Xk1WFSlBycA=; b=ZsUSVjojTSd4aSiWHws7n5O/CpP5jivTPxQFryaZw3DOnDbP1LVrbc4QrTIWbD5F6b IxQmGzluiBa9xYfNXV7i6qgX5EB3i4bBUuIquW7U0DaH2FfvGXns3/pX4DSsw4c+G/sz 7IDY39Jql/j3hoACrL1jOVkKK+TNhIsFF1Wkz8ZMNW+Gg7+UH7mjNPBdZcPVNemGuy4S Rt2+XamHLaer2Lp95+80/XHoyDY/iLWdmTIhedApELwDYRnGo69elVb0505iPO9iyhC6 dFNmIEu3ZN8zeyG/NfVJYQVT5oG8H9Vu+4268Qk2yOzQ8RrICWakccpGQ8O42VyZiHJt v9PA== X-Gm-Message-State: AOUpUlGEq/FHtH7uHPx2D1Rdd1uIiBTw5np3yJN4hNnKrbaGPFzrUSrm OXnqPKBJnhiYE5HSa+33X+i8wg== X-Received: by 2002:a2e:84c6:: with SMTP id q6-v6mr10574367ljh.65.1531741004164; Mon, 16 Jul 2018 04:36:44 -0700 (PDT) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id v136-v6sm8104913lfa.10.2018.07.16.04.36.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jul 2018 04:36:43 -0700 (PDT) From: Niklas Cassel To: broonie@kernel.org, Liam Girdwood Cc: linux-arm-msm@vger.kernel.org, Niklas Cassel , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] regulator: qcom_spmi: Use correct regmap when checking for error Date: Mon, 16 Jul 2018 13:35:23 +0200 Message-Id: <20180716113525.9335-3-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180716113525.9335-1-niklas.cassel@linaro.org> References: <20180716113525.9335-1-niklas.cassel@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since we have just assigned saw_regmap, and since the error message refers to saw_regmap, it feels safe to assume that it is saw_regmap, and not regmap, that should be checked for errors. Fixes: 0caecaa87202 ("regulator: qcom_spmi: Add support for SAW") Signed-off-by: Niklas Cassel --- drivers/regulator/qcom_spmi-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c index 8b921b1b1df5..054c0245aec1 100644 --- a/drivers/regulator/qcom_spmi-regulator.c +++ b/drivers/regulator/qcom_spmi-regulator.c @@ -1775,7 +1775,7 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev) syscon = of_parse_phandle(node, "qcom,saw-reg", 0); saw_regmap = syscon_node_to_regmap(syscon); of_node_put(syscon); - if (IS_ERR(regmap)) + if (IS_ERR(saw_regmap)) dev_err(dev, "ERROR reading SAW regmap\n"); }