From patchwork Fri Aug 10 22:50:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 143968 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp480810ljj; Fri, 10 Aug 2018 15:50:56 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxAqaRQqO3nKmysWpjigvUxQP18nVfZiUMMj6Y6oRx62kVMwZT10gVdxdy2+yRQoYQAeyZT X-Received: by 2002:a17:902:5582:: with SMTP id g2-v6mr7836159pli.328.1533941455884; Fri, 10 Aug 2018 15:50:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533941455; cv=none; d=google.com; s=arc-20160816; b=YKZuLpzR0y+OaQsx1zyOoerHIJiHxyJ6jO5AnPKvxYxRAZ2+IHGWao0eHSyo4X6q6o wuLIZhNHVCv+OYoiZ6rjedcvbazfRZB7nA49BLUOiYUYOhLqGOVIjlbzvWNv8g0klKTH kB1nga6U04+H43LBX2TP9dq2t++xsRdmffP4OT9L9U1slbyLwMpf6NNF8DejdLjj4lr4 iC+KJOQHcZf5JFsTOW2TA++SFPVqY08JqYdJH2sPRRsAS8i0YiL7shP4fcGNR6SFuBqy 8Q5plmhkUgPj/2uCZIuoI0D4MQ8zDFvq47pcrb9/+wXqS1611Ohej6MZ/MMdoGIequE0 Tycg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=zQ6EOvgaEThJ1QWToMEFmPIu7C+sFD+nq5QvF1R68pg=; b=X0uh6GRMjyPA6U4HFG5FzIgUiYIiCc+pXk+8NQEBls/vLitznBYxO+vwQ3vLUf1SvV gfaa9BCTGJr/WzDrZGXGBy9exNya2haaI8b3xlAIvAUAIUMqR8DwFczhaQDesB+3WFXj Tx3TLpHKEHyvcvmfLsLLSTyb1hK+UDZPn7fwNa2ODqgI8nYcWT0SE6NDJOmJD8FPTCxc kgjElxIvGOV10jfiSJB1xo8WQy7gQGJisO7NxhiHsHitWr2KRnrmyeMmq5bj2aJZ6tze AOcPSVtwlRv1BBH4yqfeT0VVM0V2ZUOQKSUB2HtBOSe1rQHkiwVbaU6Pv2PaVBQj6Oub IM/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1-v6si8413312plo.176.2018.08.10.15.50.55; Fri, 10 Aug 2018 15:50:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727206AbeHKBWo (ORCPT + 31 others); Fri, 10 Aug 2018 21:22:44 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:54208 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727033AbeHKBWo (ORCPT ); Fri, 10 Aug 2018 21:22:44 -0400 Received: by mail-it0-f68.google.com with SMTP id 72-v6so4732759itw.3 for ; Fri, 10 Aug 2018 15:50:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zQ6EOvgaEThJ1QWToMEFmPIu7C+sFD+nq5QvF1R68pg=; b=lAkDSiQOdbbxX9idELCOOBEF3BP9WGMkMkTJMo5WsRn5qCv+Asq7n4VnZmka+g+TK2 8DLrCypXnrc4IHn4FNNQ0EQS/Z0ih20iFp60AxKGlq8cCkXW8FPA5LjbsBnkQP+dqlLd IgR7r2t01uX5/sUadDP3v5FIyvqoP54MXKUpwdDaQNMETUEiXGUn1Xuws2AckOUV/G6E trKnrcJmfa9XDirPDCeiTgVcM2KItmreMqoxteIcWxFgzOjcA8Uf5LZ06frzEdNZT1bS h4xjrbYHR9AJbcHtn23ss6lDqUUmaRjJ3AD6CIHO5PMKYikBVeIeW3veCM5YCvInLsSM QQJQ== X-Gm-Message-State: AOUpUlGqcf++4Z+zj6uOuKsi8c4JyCX7tG28twrrvYbru1JuNj3MCqHY JcWjJoCKAddIwc9sq5dpQg== X-Received: by 2002:a02:891b:: with SMTP id o27-v6mr7781304jaj.23.1533941451086; Fri, 10 Aug 2018 15:50:51 -0700 (PDT) Received: from localhost.localdomain ([24.51.61.72]) by smtp.googlemail.com with ESMTPSA id j78-v6sm1766399itj.44.2018.08.10.15.50.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Aug 2018 15:50:50 -0700 (PDT) From: Rob Herring To: Joe Perches Cc: linux-kernel@vger.kernel.org, Andrew Morton , Andy Whitcroft Subject: [PATCH v3] checkpatch: DT bindings should be a separate patch Date: Fri, 10 Aug 2018 16:50:49 -0600 Message-Id: <20180810225049.20452-1-robh@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Devicetree bindings should be their own patch as documented in Documentation/devicetree/bindings/submitting-patches.txt section I.1. This is because bindings are logically independent from a driver implementation, they have a different maintainer (even though they often are applied via the same tree), and it makes for a cleaner history in the DT only tree created with git-filter-branch. Cc: Andy Whitcroft Cc: Joe Perches Signed-off-by: Rob Herring --- scripts/checkpatch.pl | 14 ++++++++++++++ 1 file changed, 14 insertions(+) -- 2.17.1 Acked-by: Joe Perches diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a9c05506e325..fa9b50d6f3d4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2236,6 +2236,7 @@ sub process { our $clean = 1; my $signoff = 0; my $is_patch = 0; + my $is_binding_patch = -1; my $in_header_lines = $file ? 0 : 1; my $in_commit_log = 0; #Scanning lines before patch my $has_commit_log = 0; #Encountered lines before patch @@ -2485,6 +2486,19 @@ sub process { $check = $check_orig; } $checklicenseline = 1; + + if ($realfile !~ /^MAINTAINERS/) { + my $last_binding_patch = $is_binding_patch; + + $is_binding_patch = () = $realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@; + + if (($last_binding_patch != -1) && + ($last_binding_patch ^ $is_binding_patch)) { + WARN("DT_SPLIT_BINDING_PATCH", + "DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt\n"); + } + } + next; }