| Message ID | 20180828142724.4067857-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 05a0a34418699ea2ced1fe6e081b91c0e1065690 |
| Headers | show |
| Series | [v2,1/2] rtc: mips: default to rtc-cmos on mips | expand |
Hi Arnd, On Tue, Aug 28, 2018 at 04:26:30PM +0200, Arnd Bergmann wrote: > The old rtc driver is getting in the way of some compat_ioctl > simplification. Looking up the loongson64 git history, it seems > that everyone uses the more modern but compatible RTC_CMOS driver > anyway, so let's remove the special case for loongson64. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/mips/Kconfig | 2 +- > drivers/char/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Looks good to me - history suggests Loongson's RTC needs to use binary mode for some reason but we've had that support for a while. Presuming you want this to go through the RTC tree: Acked-by: Paul Burton <paul.burton@mips.com> Thanks, Paul
On 28/08/2018 16:26:30+0200, Arnd Bergmann wrote: > The old rtc driver is getting in the way of some compat_ioctl > simplification. Looking up the loongson64 git history, it seems > that everyone uses the more modern but compatible RTC_CMOS driver > anyway, so let's remove the special case for loongson64. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/mips/Kconfig | 2 +- > drivers/char/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 35511999156a..c695825d9377 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -75,7 +75,7 @@ config MIPS select MODULES_USE_ELF_RELA if MODULES && 64BIT select MODULES_USE_ELF_REL if MODULES select PERF_USE_VMALLOC - select RTC_LIB if !MACH_LOONGSON64 + select RTC_LIB select SYSCTL_EXCEPTION_TRACE select VIRT_TO_BUS diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index ce277ee0a28a..131b4c300050 100644 --- a/drivers/char/Kconfig +++ b/drivers/char/Kconfig @@ -268,7 +268,7 @@ if RTC_LIB=n config RTC tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)" - depends on ALPHA || (MIPS && MACH_LOONGSON64) + depends on ALPHA ---help--- If you say Y here and create a character special file /dev/rtc with major number 10 and minor number 135 using mknod ("man mknod"), you
The old rtc driver is getting in the way of some compat_ioctl simplification. Looking up the loongson64 git history, it seems that everyone uses the more modern but compatible RTC_CMOS driver anyway, so let's remove the special case for loongson64. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/mips/Kconfig | 2 +- drivers/char/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.18.0