From patchwork Wed Aug 29 18:34:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 145464 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp989360ljw; Wed, 29 Aug 2018 11:34:08 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZRAbb3CdXA7VBrO/EEbQG7rxzb70n0dKKJLkb4V6zII/OXbMrVLgTsTFwMKBMc9w4OWvQH X-Received: by 2002:a17:902:7009:: with SMTP id y9-v6mr6932752plk.249.1535567648034; Wed, 29 Aug 2018 11:34:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535567648; cv=none; d=google.com; s=arc-20160816; b=L0jbzUhVRzafQaB5JGU9XsbC5xisaG2n8mtvvHug73ylEUarNRhFR5kq36PqmKfT0C c9ZfsFY+oz+zQhfnWWSCHvRklC4s2FuCO/mA1VAiitwF3MKI0ee7WwLq579OyynN/Wvg 9mtlFvsx0+6NWifK174V9dE/i/d3MZIqfPo8spwSvrR9S7Usg5LpaHIxmV0N8zAseAd8 o2Snw2UnL85nneOH9txalp0iSEo53sJdgtjdFQSoxK5ZwHSXBaTU2BKJhOiGSVv1wpUN 2AvOmoOae05NxUD1FLsC7hrZTh390MQ+cRidG+jSLflMaLSu0HMbAERh70qz1401l5mF eSXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=GKQiezdqb2dvMAN04K3bM9bn8gEYB01L2pCQBNrZbF8=; b=DA/tJW5V0k3bwV5D1GMGS5Dwq13YfMc/Ll9HLFFJQ678qdiXdJD9WAZr9ys13vCLu4 uMZ0Sn1grXDH706EfoGDiSo9vrOxRdNy/36ddOmNJTihKpc5oSf03GY9/0qSRHJuLC7Y IN3109yGNbqJHkjI1yTTX8ya0WOpSFz1sfinqrNNYllBCkxRnJPRyzIJAmN9QVPby8A0 0tKZNDZ4UOZdo6BFEwmboEs678gmz/tcdnOQM4ADeOKPviL+Gd7EDPAl8MUidj8UsLYB wXhNsjdAtdmkPFwLquk4bwS9JTewZjQxUscUnQSJAmWU3TlBLpMI//DbwTJYDZieptQN 4dQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11-v6si3525660pgm.616.2018.08.29.11.34.07; Wed, 29 Aug 2018 11:34:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728535AbeH2WcO (ORCPT + 32 others); Wed, 29 Aug 2018 18:32:14 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:37951 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727657AbeH2WcO (ORCPT ); Wed, 29 Aug 2018 18:32:14 -0400 Received: by mail-oi0-f67.google.com with SMTP id x197-v6so10942395oix.5 for ; Wed, 29 Aug 2018 11:34:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GKQiezdqb2dvMAN04K3bM9bn8gEYB01L2pCQBNrZbF8=; b=nWuImbA6VblCehVqqG2t2A70LG63XPi3dA6drYauoCWDr7d39zsRUPhQFcwMrTCOhu MN6H38wVG+sFOKojbd7l3Q4/iJpNUyXLhO0J2amaZrskz8pV2Qedobr+McAxDpWkwXTV PXSkNJBHcNRn9zts7q7tJwlIrEkdzv8YNoZlpZaejv142rhc2xIjjgDZ60jsO/0OlaVF lYlEzAerWn1y3XJEdH1Hw1QdjlsiCfWEQ27Hjt5BRHz4LEYP9ZFXVjyqeFPASX50cE6/ S1sL+T1ZvyfHfzBL8rgg8ZWa4REPwh9+y1P2fyKXlZaefxXDR0InXoQbQmNm05s/g9YL tG+Q== X-Gm-Message-State: APzg51B2kI9lCKiEn7F/G7qr4UlQreWUnySuYE6J+UlmDbrzEHiX2Fa3 XaiZ1XmBhReaUWdneLsQfa8wEUY= X-Received: by 2002:aca:2c5:: with SMTP id 188-v6mr4012220oic.192.1535567645090; Wed, 29 Aug 2018 11:34:05 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id 16-v6sm2391487oin.5.2018.08.29.11.34.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Aug 2018 11:34:04 -0700 (PDT) From: Rob Herring To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH] staging: mt7621-pci: remove unnecessary check of device_type == pci Date: Wed, 29 Aug 2018 13:34:03 -0500 Message-Id: <20180829183403.12790-1-robh@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PCI host drivers have already matched on compatible strings, so checking device_type is redundant. Also, device_type is considered deprecated for FDT though we've still been requiring it for PCI hosts as it is useful for finding PCI buses. Cc: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org Signed-off-by: Rob Herring --- drivers/staging/mt7621-pci/pci-mt7621.c | 7 ------- 1 file changed, 7 deletions(-) -- 2.17.1 diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c index 0d13384b90c4..5055475bd04e 100644 --- a/drivers/staging/mt7621-pci/pci-mt7621.c +++ b/drivers/staging/mt7621-pci/pci-mt7621.c @@ -387,15 +387,8 @@ static int mt7621_pcie_parse_dt(struct mt7621_pcie *pcie) struct device *dev = pcie->dev; struct device_node *node = dev->of_node; struct resource regs; - const char *type; int err; - type = of_get_property(node, "device_type", NULL); - if (!type || strcmp(type, "pci") != 0) { - dev_err(dev, "invalid \"device_type\" %s\n", type); - return -EINVAL; - } - err = of_address_to_resource(node, 0, ®s); if (err) { dev_err(dev, "missing \"reg\" property\n");