From patchwork Fri Sep 21 15:41:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salil Mehta X-Patchwork-Id: 147295 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp971109ljw; Fri, 21 Sep 2018 08:43:21 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYQrFDekWsjzxGQtqhXlcjP/vJNv6C8blnCunjDextnYLFWmJzzqcYxFOKIaAiOU5P5GavA X-Received: by 2002:a62:50c3:: with SMTP id g64-v6mr46526068pfj.244.1537544601597; Fri, 21 Sep 2018 08:43:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537544601; cv=none; d=google.com; s=arc-20160816; b=vHyvlI6BhEXj+70bfYEck//MntRLorCJV1BBl0aefBTfdprcdTOe4s7V4q1ZJqwlxo jsxmQ0doSJM9NHvmnQfHVJTkHc6ulR+7q/kMgb1QGhmkCZ+koXFTE2kRWK0chUWfUWRs knFNcXqVBO8rZQt64ZWvPsIt6DVWk9dp67Pdze61id40wLX632ua1AA5B4DTYs353n64 R7CHcyArWiWWn9AXAc9fZRUXsyNvcrI/DrH6gA23dgbAyH8TcmjjcFTk7IEbnmMoUnZ7 QMUvHGJ5PfOh0Zkrb1Eun8eWg/RhuVhudjgTgHBm79vImPgYA4Dvidt4n5NInVkdPe9W alhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=dXFdJnwUWC7XFcBwMgz/P7//BWr6h13YxYPN9VhPu8c=; b=DuHyHC9dVEXQKJAWbFYRQL6pj3ZoRo49E0Bqr2xRye3feX1VAOZXn7GnZN4eiNixCv 058AMAnGdec2dZ7U/b32ux9wY89KPDuVIxjHSIENWpsE9Iw30emuOc01EJG+kRDNrcrI kL4bfbSpbrkfjbT1x30pa6O4PXI6xK34TwZl2egzpHaWL8Ww42jLviL46fyH3Kr20BdS EWcXz9Gb3OVSEeGdfZH71GeLsCDzPklU308l2CpwQtTuCcFM2vAaN6L7hAX35d63RUUD Uzumm7iL5k6WX1DrDbMla4lKy3f7kquCbUYY1B53Ua/4+lDppiUZgCEhpwW3Nt9nVCG0 PFZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a75-v6si27696644pfc.106.2018.09.21.08.43.18; Fri, 21 Sep 2018 08:43:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390755AbeIUVcn (ORCPT + 32 others); Fri, 21 Sep 2018 17:32:43 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:47207 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2390678AbeIUVcm (ORCPT ); Fri, 21 Sep 2018 17:32:42 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 63CF7934E985E; Fri, 21 Sep 2018 23:43:13 +0800 (CST) Received: from S00293818-DELL1.china.huawei.com (10.202.226.54) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.399.0; Fri, 21 Sep 2018 23:43:06 +0800 From: Salil Mehta To: CC: , , , , , , , Jian Shen Subject: [PATCH net-next 09/12] net: hns3: Remove print messages for error packet Date: Fri, 21 Sep 2018 16:41:45 +0100 Message-ID: <20180921154148.26756-10-salil.mehta@huawei.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20180921154148.26756-1-salil.mehta@huawei.com> References: <20180921154148.26756-1-salil.mehta@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.202.226.54] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jian Shen There are already multiple types packets statistics for error packets, it's unnecessary to print them, which may affect the rx performance if print too many. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 5 ----- 1 file changed, 5 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 8b63707..5a4773a 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -2149,7 +2149,6 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb, hnae3_get_bit(l234info, HNS3_RXD_L4E_B) || hnae3_get_bit(l234info, HNS3_RXD_OL3E_B) || hnae3_get_bit(l234info, HNS3_RXD_OL4E_B))) { - netdev_err(netdev, "L3/L4 error pkt\n"); u64_stats_update_begin(&ring->syncp); ring->stats.l3l4_csum_err++; u64_stats_update_end(&ring->syncp); @@ -2328,8 +2327,6 @@ static int hns3_handle_rx_bd(struct hns3_enet_ring *ring, } if (unlikely(!hnae3_get_bit(bd_base_info, HNS3_RXD_VLD_B))) { - netdev_err(netdev, "no valid bd,%016llx,%016llx\n", - ((u64 *)desc)[0], ((u64 *)desc)[1]); u64_stats_update_begin(&ring->syncp); ring->stats.non_vld_descs++; u64_stats_update_end(&ring->syncp); @@ -2340,7 +2337,6 @@ static int hns3_handle_rx_bd(struct hns3_enet_ring *ring, if (unlikely((!desc->rx.pkt_len) || hnae3_get_bit(l234info, HNS3_RXD_TRUNCAT_B))) { - netdev_err(netdev, "truncated pkt\n"); u64_stats_update_begin(&ring->syncp); ring->stats.err_pkt_len++; u64_stats_update_end(&ring->syncp); @@ -2350,7 +2346,6 @@ static int hns3_handle_rx_bd(struct hns3_enet_ring *ring, } if (unlikely(hnae3_get_bit(l234info, HNS3_RXD_L2E_B))) { - netdev_err(netdev, "L2 error pkt\n"); u64_stats_update_begin(&ring->syncp); ring->stats.l2_err++; u64_stats_update_end(&ring->syncp);