From patchwork Mon Oct 15 19:44:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 148885 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp4193787lji; Mon, 15 Oct 2018 12:45:02 -0700 (PDT) X-Google-Smtp-Source: ACcGV60KauCVo/bMuXOl8eSuYipnFRGyqDbA6i4DmzRTugAisUAH2HjJTzgVEB82XsOOOeOBRrrK X-Received: by 2002:a62:7604:: with SMTP id r4-v6mr19065363pfc.230.1539632702813; Mon, 15 Oct 2018 12:45:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539632702; cv=none; d=google.com; s=arc-20160816; b=qAT6X5tU08owU/1E/kASz2r1oZYxrVB+tIwMHldqCt22fMOXtKAB/UeUQwxQFw9CiD oF0vsvoodnShkf+DQY046d6wHf3kXjfNnFbS33tGxRAhZJL6EEG2p9yHnsGpNCUduvhD ND00HyHUakEQuOGZyHsAeu/CMGgc6Ske2nkXY/8w9aBX3LgYiB+vkb5/qL5eULhRq2bB ahjp026YDxydemV1Ar8kEBFMpvE5Cx2Ev6FfAZ3/g1hJI9iZuIgC62xkGr6v70D+Av47 VMG2UDsPBTLiKvWJsMvBhCf/Dq5MDBSUSm1QGHkmThB+oJSsuX7lv9qzYjtRaXJ2lBvh jYfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=i3xUaXG+1kGQsQJJ9XMptJa94waHMLew9MuT9BmQ3i0=; b=MN/I1H4MNWvnPS1C4h3SjpMnqSQWfnT/L854NXjksO8uklcR1bbXHiEP/GA7ahRSC2 +lHYYV3xWxENxF+Im8c0YR0d0zU2WEJF6eKCeMh82KODlyMzkFYi83zn0xECmcdnJtgE taRXT6hwNZun9gtA4/ODxwrRQ1jLQCqwZHEaKpzYa/txf0Jn8pZNzLp/Rz4WmoGOCJ1X dKJuRWfwmr9y9X2wQLL04CRwFDWfs6vZ5kj2cRBHvK28M7ze4CJX0yTkIXMyi90uHIv6 qPeeGyZrisn8qqnY1f+X6wYWNGtuHT8BwDSc+35LI6lp9EB168bGMIceKhRsoQQmpUHc OGwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IeuAxScY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f9-v6si12324544plm.126.2018.10.15.12.45.02; Mon, 15 Oct 2018 12:45:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IeuAxScY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726955AbeJPDbk (ORCPT + 32 others); Mon, 15 Oct 2018 23:31:40 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:36515 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbeJPDbk (ORCPT ); Mon, 15 Oct 2018 23:31:40 -0400 Received: by mail-lf1-f66.google.com with SMTP id d4-v6so15027514lfa.3 for ; Mon, 15 Oct 2018 12:44:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=i3xUaXG+1kGQsQJJ9XMptJa94waHMLew9MuT9BmQ3i0=; b=IeuAxScYsl04F4M+pL1LvkyVleWMqK/SraVIfjAYsTGHYqTEdYN8q+GBDRa206pdF7 xwOu4xIzcfh4qrdVIfTs3RTctLsOEOIPHTY8uGt9TCNCOFUZu146FCTT9Seks0Wv53g+ 1MKeIF6tp+6bDj5rxZNrOAl3PJyCtnuqnexuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=i3xUaXG+1kGQsQJJ9XMptJa94waHMLew9MuT9BmQ3i0=; b=kgmNNTIOBqhhZ2L/UOAahdPNHpANhR0ESgf8+CHxTeZu/qLNMkHhNUA0Grx91gKNqP HfjXEnoUZxq9VqQVIn0OU9YbvkjFcs9GzctG7fzfg/CXkspKJ/GRtMtU4Il3sIoJzlAx Ga//IuG2ipf55zJ3lo4lK0FGu4zdZboVaWrBQqelPjueYlKTTSPkG7FFSG0CsQ8YFIVU 52nu/eJ6hJTOoZLyn2zrzBEVM6TTJOyYhQukxgXZGhc4g2xaPZXCcdarnVWFhVYN2WjV NW700dHGDEzfiq/jE1/v0+OeAkHAnNYk6Y9xBwga9kPfWaWa9ExoOJMAgGklcNzYKnmq m+hg== X-Gm-Message-State: ABuFfohi0gxx/RTtSjthw0e1QH1oG2It9XAZu4sxDdpCfa+bCQHAQCVf rVoXrHLuTdEPOZKuPpwgGdTXNCZqi+E= X-Received: by 2002:a19:a686:: with SMTP id p128-v6mr10323260lfe.42.1539632698114; Mon, 15 Oct 2018 12:44:58 -0700 (PDT) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id i16-v6sm999681lfj.18.2018.10.15.12.44.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Oct 2018 12:44:57 -0700 (PDT) From: Niklas Cassel To: srinivas.kandagatla@linaro.org, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Niklas Cassel Subject: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected Date: Mon, 15 Oct 2018 21:44:41 +0200 Message-Id: <20181015194441.10475-1-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181015183218.GA16900@kroah.com> References: <20181015183218.GA16900@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is to select it, not depend upon it. Because of this change, we now also need to depend on the same Kconfigs as QCOM_QMI_HELPERS depends on. Signed-off-by: Niklas Cassel --- Hello Greg, Srini, I'm sorry for this. (Although I'm a bit curious why 0-day test bot didn't catch this.) Considering that I've just changed QCOM_QMI_HELPERS in: ccfb464cd106 ("soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs") which is currently in linux-next, and that this Kconfig should depend on the same Kconfigs as QCOM_QMI_HELPERS depends on, I chose to have this Kconfig match the QCOM_QMI_HELPERS that is currently in linux-next. drivers/slimbus/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.17.2 Acked-by: Srinivas Kandagatla diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig index 9d73ad806698..8cd595148d17 100644 --- a/drivers/slimbus/Kconfig +++ b/drivers/slimbus/Kconfig @@ -22,8 +22,9 @@ config SLIM_QCOM_CTRL config SLIM_QCOM_NGD_CTRL tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" - depends on QCOM_QMI_HELPERS - depends on HAS_IOMEM && DMA_ENGINE + depends on HAS_IOMEM && DMA_ENGINE && NET + depends on ARCH_QCOM || COMPILE_TEST + select QCOM_QMI_HELPERS help Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device Component is programmed using Linux kernel.