From patchwork Fri Nov 2 15:36:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 150057 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2222937ljp; Fri, 2 Nov 2018 08:36:45 -0700 (PDT) X-Google-Smtp-Source: AJdET5f8N90bsbmEJkE9Y1M3ff5aZWt/lYTjmed+CQ/DYdFTlbZKwftsnoRljM/H9NAR4qBrAg0N X-Received: by 2002:a63:4044:: with SMTP id n65mr5134595pga.90.1541173005492; Fri, 02 Nov 2018 08:36:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541173005; cv=none; d=google.com; s=arc-20160816; b=enZUadWihtHiya1JY5DJGnHALS/He0M/2I4sivw4UMEbL4VYWfeD6PAwKVDUERR6nU uaiiFAOmTOn1IM90+1PJO3ohko4piQDTG9dbPOe3RuZlu/pbvxbB21+cZM6LE41RYwmN 3D0pndVwbbypNDtuHECx/XDWDiNBf1Ez7ht5znB+xxht0tmCdPi140Qe27kLlUxnxRjd gpB8ZMZ2txgECiXjGeFrvet72lKiao+Xuyl/Eq3oXH0BEecvqBDVoGipRYrkXLuypjKj qO6m1biw7CTuyVoo/ha6TES4b1O0ST9S0JOIY9F9hjHvbnXBnDl4RNcFvitO+B9yEFXk mHjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=xWH3CrLFMIuZ/V9Kpgq+c30a4p0gWCsY8A0Tr0UAfi0=; b=XFRsc7vkX0UHw+IMRlEHlAmlB644qJClJ0T5X2jYrfmPNBLmW34c4N5XttKkvRIYcs SB3tdoJ31F0jEpR4C2pf+jLMFhW21c+wPH85N/7zbXNjj7FM1rjIZ70+9NhU75sGqwHr xMP3qbQgK8Dz/9/ON4aNTn2MFcS3WWWjrYNVFed86EDn1baUM0aP4Nn4FzMz/RlRJN85 BylZPJLdMs/QpcETvojee3YdX1kLiKf5u9IozLjsmhrE4qm3oaHOnWTNGrDEuQlK2sre xJo3uvZextntxCZ6mLTvjYyRubj2M5PlJ8IkQc++qQMZddFPRlMngEE5XKaPGeuOwqhT ZOHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 23-v6si34099816pgx.594.2018.11.02.08.36.45; Fri, 02 Nov 2018 08:36:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728092AbeKCAoL (ORCPT + 32 others); Fri, 2 Nov 2018 20:44:11 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:56287 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728060AbeKCAoL (ORCPT ); Fri, 2 Nov 2018 20:44:11 -0400 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPA (Nemesis) id 1MQvH5-1fwGtZ3Rvr-00O01o; Fri, 02 Nov 2018 16:36:34 +0100 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPA (Nemesis) id 1MQvH5-1fwGtZ3Rvr-00O01o; Fri, 02 Nov 2018 16:36:34 +0100 From: Arnd Bergmann To: Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" Cc: Arnd Bergmann , Sudarsana Reddy Kalluru , Tomer Tayar , Denis Bolotin , Rahul Verma , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] qed: fix link config error handling Date: Fri, 2 Nov 2018 16:36:24 +0100 Message-Id: <20181102153632.1646632-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:4roWWxVSKT7R5vRrB16ZZ5BGYXw06RETKkivZSYmyNZ3O41gCRa DilHpHXpWZKtn4aX7TeZC9IkBoMVbbfKl1UgyYVRWdqxah6ndjU9y+oPELwmlkSYJp7SaVd sad0CBt/Nm6WNl5qeqzjCTjCWgAi65PJ57ewBc/lvBPucs3oCqEn2PwKGoJQkuJSuu38/vN P5lDpUqo1Jjkf9OY4xiWA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V01:K0:B0iscfhiLFg=:DbhgyaY2sxYLS3O0sVP3k1 pBtaDP+9KSLlRghNEyL4KaQGiMQfd5mwmPFfAQ51F6J+A9uNYmcj2sQJHRHD5ss6VJIL3bk0v s3L/7qS/l9lzX/OeaavF6Uo+SFpHW/Hy+Ot2ggK8Dfxjlbgh9htGde6n2bIXkBo1Ml4yha+Wz LJAESo/PQzn+TjyVj4+hgRVi1UuYKfpHimN8UgQskzN9tD1ZipUQDsa/Fj/S4jyF0prG4Tat/ jIqdh7dovr1fo5ucYymBaLU6JqWqgY8NqbbxLW3fYHJxWdrGvwBseXfEXdLfv+N504Mxz+Moo Sit6rLiEGWGBZakZcS5ALU/pseNbBIV5oMtOaxq6WpPFn9ORCFVxJ4dS+yn60WhSYY20lAg5A wYjO6+8ka62yH4mN+f/R3lr1aOq2fe90+6s5DINlR5tYB7xz/+Yky33NP3KVhEkg/I1IALVvd g2lGkOiUvagGuBTu1K9j7zXmEIz1MIDH+p+tkTwQoBjnPhFCUkrq2WCrkYsiiOpOjQzqAxPHA 8nBd3Vgvxg/73vgBLf15zsjyic/h8G4pqW0aJrvn7FKOvYflIFYuD00XbUwI0rciCXE7b++X3 jNJ3zZu1P8GL1jKAqJrfoQGUKNAyiDFvie1fhHNmDezgTsqCXcoTybKFUqPz78mwS4B0ThkF2 ellJwEGwXvMsfaqyCnzJdBQmQ2quNrRt5tIf6nZlWLiC0LeR1H6lQkMUTezuWtHn252I= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-8 notices that qed_mcp_get_transceiver_data() may fail to return a result to the caller: drivers/net/ethernet/qlogic/qed/qed_mcp.c: In function 'qed_mcp_trans_speed_mask': drivers/net/ethernet/qlogic/qed/qed_mcp.c:1955:2: error: 'transceiver_type' may be used uninitialized in this function [-Werror=maybe-uninitialized] When an error is returned by qed_mcp_get_transceiver_data(), we should propagate that to the caller of qed_mcp_trans_speed_mask() rather than continuing with uninitialized data. Fixes: c56a8be7e7aa ("qed: Add supported link and advertise link to display in ethtool.") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/qlogic/qed/qed_mcp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.18.0 diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c index f40f654398a0..a96364df4320 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c @@ -1944,9 +1944,12 @@ int qed_mcp_trans_speed_mask(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt, u32 *p_speed_mask) { u32 transceiver_type, transceiver_state; + int ret; - qed_mcp_get_transceiver_data(p_hwfn, p_ptt, &transceiver_state, - &transceiver_type); + ret = qed_mcp_get_transceiver_data(p_hwfn, p_ptt, &transceiver_state, + &transceiver_type); + if (ret) + return ret; if (qed_is_transceiver_ready(transceiver_state, transceiver_type) == false)