From patchwork Fri Nov 2 15:38:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 150059 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2225690ljp; Fri, 2 Nov 2018 08:39:28 -0700 (PDT) X-Google-Smtp-Source: AJdET5e8OK2T+Io/dHf2MPKngaZRGpYTect6MpMMEcoEBu4ZxT07IcqSdQDX3qoCWl1jPFqpznXc X-Received: by 2002:a17:902:6ac7:: with SMTP id i7-v6mr12377158plt.268.1541173168524; Fri, 02 Nov 2018 08:39:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541173168; cv=none; d=google.com; s=arc-20160816; b=c2qxpKMrNcye4n0mL5aAx5DkY92E6yHYqN+tINaeZ4pTMbNPLFO01JKdQ0xMPuNVs2 +PMm6/1MY4e8ZZzWqFboB1tVmwok6b7RjSxfXavO49KbvgGYITm6jUOw5Gqr59T+JUib Cnk7K7CIugENdc/EqJses+iFwEXT0LUtWJVao4zU4GAPvLTlOT7eVCEn5lp9ccd9hcpN PGg6p7P5lAcnszeS7A/3g8z5NoFvntqfCohdaZGvieXbc1cmReDY9ZlCFrO3i5bqx0lr 0Ms35jR5LvfaUJOdmegJ+Q2JUVn2GAvjG4Iq10pX/x+NdDW2FIyP6PK2DnYQK0E6TSKK tuOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=N8t40GYWnchgvEw+r/8PZrp8AI1NZj6LzX6LccuQdQ4=; b=vwCvPZG91HBQSPlxnU5h08wJLocKgZGc73rtodGungV4Fzm+kwVaVfgJCGF0k4ghoq vwkf3HtwYU5Wk4f4BuZtbiIgdQ92qVYPiXt5fhJ491cp4i/2MbxR0qKdzTXUe/7HZbNk K4GDv5Z59RsMDHViy2QVWCr49NYfXsi3uDbZj0pCcNnd0BlHUbpjfELieKhUzdEUbhfm VjMt5XysNJw1RjAmJLrFLtWtk6eDaBKz2AGfdQe7aF73U6sybcvkpN7iJLPJutOJojus sZTsXYgz0IB91bNCTbwzai0LxwwsW3CPUzGeiL+sk02DmcZfGwLLCTAdM1jfmWIMEdRu xL2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7-v6si34332697pgj.116.2018.11.02.08.39.28; Fri, 02 Nov 2018 08:39:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727885AbeKCAqz (ORCPT + 32 others); Fri, 2 Nov 2018 20:46:55 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:52569 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726707AbeKCAqz (ORCPT ); Fri, 2 Nov 2018 20:46:55 -0400 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPA (Nemesis) id 1MpDRv-1flR37357H-00qhqj; Fri, 02 Nov 2018 16:39:06 +0100 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPA (Nemesis) id 1MpDRv-1flR37357H-00qhqj; Fri, 02 Nov 2018 16:39:06 +0100 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Arnd Bergmann , Hans de Goede , Kees Cook , Randy Dunlap , linux-kernel@vger.kernel.org Subject: [PATCH] vbox: fix link error with 'gcc -Og' Date: Fri, 2 Nov 2018 16:38:53 +0100 Message-Id: <20181102153905.1732199-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:Umf2kNw7COZBQOvbe+abFdKI3dJdTojWXAeo3djbD4kLQ42Z23F fXPT6IYXybHsSZNWLXa917HTeNZ1HTgx4xSyNRtK1CNlHIz9VyXTnNbFgBbu1faiSQiFnET 3bjEfCT+7khtgtBHohH5SxBnzqfforARVI1+r7lqAxM4LrOk7W+JjNNMEctFMr/rhEskgH6 +UyEVMcew7n4ZTldQYS/g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V01:K0:EHhyj7+A72o=:2dtkBaSOACqXyBBRWIqBnB JprbdWcA8EONWqPJt+fDWG8fjeZILS7+FhmyEUBARiQuQz2TMksvCffUqkwNzbhAJ2svQD3Gt +ofttZUArKzPHoj+GxI9QLSsaP91Nb+0Y+TWIpvzEDD+K02jNKkQzOieu4rJ1nTpBGcu5b9E8 +wd7GeeXO8JPpvB77QM0wyORRVMcD5No7/fFLucYWg8qrZc7jgOQzyIM98HbKxhFogaPTw+f6 Om7q4JJXVePoV+KgGOzJRrqmPC86ftDyQvV/doJKFmDTi1UYTcYMF5G7dp3iMSqEDG0FtAcHH V8+EWO2rHZ2inurINHYYePH3OB18dInUAD7Yky1ObGO987yq+duogXngGebUsWKK1DG2cS2RX i97471g8i2l1KsIHadK2UFYdiJxD1RFVkFkR5QlqwSWvf6BdaJKs3YSq+EG7XmUON57bENJrb P7XUlGI6mv7+sWgOIs4My3m3i4sv70jhmq9kBBxYlU6+jmqYnJP4ptFgh6YWnoiJ3TZ4LRiiL jyHWh2Kvb66FoJKWXAPJoLR7q0g+4Zeh0UnrH3jCptudfCGycj2MpXQyxCvjeum13z8G3PPGv 2qHZVmS4eOH2BP/KU+vwm2TP8Q7t/FKwoa+VuaSiE9147DWkGH9pMhLKBQx4i/zD/63IDxXFX KUHmdHDgP0WqnYcGhJCCx9dV282OX2tlEDFnAZ686b6EUNtzOhQxHqoZnEjhgF4Kbqco= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With the new CONFIG_CC_OPTIMIZE_FOR_DEBUGGING option, we get a link error in the vboxguest driver, when that fails to optimize out the call to the compat handler: drivers/virt/vboxguest/vboxguest_core.o: In function `vbg_ioctl_hgcm_call': vboxguest_core.c:(.text+0x1f6e): undefined reference to `vbg_hgcm_call32' Another compile-time check documents better what we want and avoids the error. Acked-by: Randy Dunlap Tested-by: Randy Dunlap Signed-off-by: Arnd Bergmann --- drivers/virt/vboxguest/vboxguest_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0 Reviewed-by: Hans de Goede diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c index 3093655c7b92..1475ed5ffcde 100644 --- a/drivers/virt/vboxguest/vboxguest_core.c +++ b/drivers/virt/vboxguest/vboxguest_core.c @@ -1312,7 +1312,7 @@ static int vbg_ioctl_hgcm_call(struct vbg_dev *gdev, return -EINVAL; } - if (f32bit) + if (IS_ENABLED(CONFIG_COMPAT) && f32bit) ret = vbg_hgcm_call32(gdev, client_id, call->function, call->timeout_ms, VBG_IOCTL_HGCM_CALL_PARMS32(call),