From patchwork Sun Nov 4 13:51:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 150106 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1537341ljp; Sun, 4 Nov 2018 05:52:17 -0800 (PST) X-Google-Smtp-Source: AJdET5eDJFW7YacsvsimKUyzvLtoJIRjVAARiNEHAht5IeGinMa0LeeSiwKuxoPW+DbxV22mXbvg X-Received: by 2002:a62:3101:: with SMTP id x1-v6mr16654856pfx.204.1541339537860; Sun, 04 Nov 2018 05:52:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541339537; cv=none; d=google.com; s=arc-20160816; b=ebut2sACqyBz32E/p2ykevbDUpYFihzbOiNd9YAWUuM6/rDiZ3y/j21VOhTPt3Y47N 6IeVcSRLJbVNQZOP3JjNLT3fZcdwtb7gl9rtXKpEuQLZX51hGYlXW3RlswQ8I+gjU1IF tTAxUgKOPdKxLRVN9ffpMZU41QS222FSnxYBu3caaiVlWyLOanEBJX6IQZOWeq5T8/fC qgZAVeogZJNsGrEo55ZzmkGfV4TbjxlX9+6Zq7A6Q/dOlEO5kyLtr8xr3H3rgIMMCgpO E4AVftSh3LN6aKTTYHDc2049vvdWsVV5aN8ZY3ba7B06e3TxQW7BlzaZM9/M0xtiY2ZU edWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=ESpjxJKtfwaRgvJFVAHVK7vaGZUkXXNlgRtDnVWvxeg=; b=soCYVomonuK0DiLehclRDQ4CExi7df2pKSuejgP5hTH8XLX3dQ51SG/dwfTq9PWNdv CzhElG3CP31UC3LR2cKQCr1F22u//xZEe6kbtZwE1oaibWhWrSi5TauIOB64OxvIeKru yp3KwH6nGG1od4Zw730y+tLGleskHAWu+mGBeFH9wOyEwWKlEYYoV50WX698bjRzeId2 dK6mxY8HHRZd18SC+yyLcBb59ZdlFGOErNsfsXIXDnaGO3F30CYX/7FciK3+9v22ScsK r1D46UKCk8HIOaEQ9YuGmeKQXARWvpplqV4jdkX6ygMNVygobccU80PU9VMV8TH1ymrc e8ZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=swhlqOXY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k25-v6si30204977pfe.36.2018.11.04.05.52.17; Sun, 04 Nov 2018 05:52:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=swhlqOXY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730243AbeKDXHT (ORCPT + 32 others); Sun, 4 Nov 2018 18:07:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:44906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730225AbeKDXHS (ORCPT ); Sun, 4 Nov 2018 18:07:18 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3106420869; Sun, 4 Nov 2018 13:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541339534; bh=XsRtoR2HobAJkGooN+EhBAm9Zeet5xoJpEAy0slXurk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=swhlqOXYffkteo7tlo0KnbCjMO/3STjylK7fQiCsZTcZK7N36QxOtbwMMJ1fkbga0 q3djscOD+X+ys577GN1reTN7k3HjgFpkzibVbPQiLZVu43HGWGX0OaZTK4knO+Mcic aGYWzB9ShMXOSNhTM7JwdOZuCX2mWyiEvTXx131c= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tomi Valkeinen , Peter Ujfalusi , Sasha Levin Subject: [PATCH AUTOSEL 4.19 29/57] drm/omap: fix memory barrier bug in DMM driver Date: Sun, 4 Nov 2018 08:51:16 -0500 Message-Id: <20181104135144.88324-29-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181104135144.88324-1-sashal@kernel.org> References: <20181104135144.88324-1-sashal@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomi Valkeinen [ Upstream commit 538f66ba204944470a653a4cccc5f8befdf97c22 ] A DMM timeout "timed out waiting for done" has been observed on DRA7 devices. The timeout happens rarely, and only when the system is under heavy load. Debugging showed that the timeout can be made to happen much more frequently by optimizing the DMM driver, so that there's almost no code between writing the last DMM descriptors to RAM, and writing to DMM register which starts the DMM transaction. The current theory is that a wmb() does not properly ensure that the data written to RAM is observable by all the components in the system. This DMM timeout has caused interesting (and rare) bugs as the error handling was not functioning properly (the error handling has been fixed in previous commits): * If a DMM timeout happened when a GEM buffer was being pinned for display on the screen, a timeout error would be shown, but the driver would continue programming DSS HW with broken buffer, leading to SYNCLOST floods and possible crashes. * If a DMM timeout happened when other user (say, video decoder) was pinning a GEM buffer, a timeout would be shown but if the user handled the error properly, no other issues followed. * If a DMM timeout happened when a GEM buffer was being released, the driver does not even notice the error, leading to crashes or hang later. This patch adds wmb() and readl() calls after the last bit is written to RAM, which should ensure that the execution proceeds only after the data is actually in RAM, and thus observable by DMM. The read-back should not be needed. Further study is required to understand if DMM is somehow special case and read-back is ok, or if DRA7's memory barriers do not work correctly. Signed-off-by: Tomi Valkeinen Signed-off-by: Peter Ujfalusi Signed-off-by: Sasha Levin --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 11 +++++++++++ 1 file changed, 11 insertions(+) -- 2.17.1 diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c index f92fe205550b..e884183c018a 100644 --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c @@ -285,6 +285,17 @@ static int dmm_txn_commit(struct dmm_txn *txn, bool wait) } txn->last_pat->next_pa = 0; + /* ensure that the written descriptors are visible to DMM */ + wmb(); + + /* + * NOTE: the wmb() above should be enough, but there seems to be a bug + * in OMAP's memory barrier implementation, which in some rare cases may + * cause the writes not to be observable after wmb(). + */ + + /* read back to ensure the data is in RAM */ + readl(&txn->last_pat->next_pa); /* write to PAT_DESCR to clear out any pending transaction */ dmm_write(dmm, 0x0, reg[PAT_DESCR][engine->id]);