From patchwork Fri Nov 9 14:04:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 150645 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp209589ljp; Fri, 9 Nov 2018 06:05:22 -0800 (PST) X-Google-Smtp-Source: AJdET5fYSIj6S7Fk35+m/0tIv8S0GoN6BxrEgZ1Klel7r/5WQqUCOvBDQnhIzZYue9SfFJYmbSyh X-Received: by 2002:a62:f541:: with SMTP id n62-v6mr9113879pfh.59.1541772322811; Fri, 09 Nov 2018 06:05:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541772322; cv=none; d=google.com; s=arc-20160816; b=PEXzcmdBH94ksMPIyjqnfPw5AOFxvRR4+cKnOvU2LvCOXdQOjmfZwejDyWhhCqUzih eVrvTXs/EnmW5KhknUykKJpVDmAYwxiMIMnulbNRbMxLHkksx8V6dzQcynGqD4UiTfRp yKMvuaYajaofhAOR2X5STNy7eeu51VdSb+UdNK4n4VIUs4d34Klmw9fH8F66Pl3ZdWe1 UvOp8Hi660GDZVDwJuBOvY0dC273eQ7cSRPInCFxH+EqVIK8WKruq+YHyJnQXcu8FQrg GA505lQjGlYMNm7FK18dNtHlS0SfAE/p8vg5TqXeeM4CJF+AcGmYk4iyWPv1nE971ppW /6HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/0smNNuQStEDVjeoyozdvGvGeLKrZskOlohutZmWEJk=; b=w8AtUJjS35FU2ys5wTl0KeLhgV11KNZhnH1DEPceS2Yl1mR9Jkosw630lsnVN+Ry3Y mIt0cp1xj/OKMkbXxTTFU7xHuoy6xxyvEuowjmeSfKB2POMG83powpgG8Yb/1psJpgDv cQJUdqGYM4IuBdbe19aAGp4MXnbpalUWILtFUo+nh7SEQpJngk5TQwr7+NHDrnn7eB/n zRLICLakNfatzhqIMLFz26hAQl8QC0DQmJtz/kYwiYUw09oqaBo8gxOKzNwobaBt0p7C tk87ykoovZ3/SxypbGayFAtS8QdPXmevLtPnQIKQeEvkpUmpsZjfjolML7xQ1sDLpT3b MDrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=f+mSw5cp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l184si6806759pgd.523.2018.11.09.06.05.16; Fri, 09 Nov 2018 06:05:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=f+mSw5cp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728167AbeKIXpq (ORCPT + 32 others); Fri, 9 Nov 2018 18:45:46 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36247 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728054AbeKIXpp (ORCPT ); Fri, 9 Nov 2018 18:45:45 -0500 Received: by mail-wm1-f68.google.com with SMTP id v70-v6so1612130wmd.1 for ; Fri, 09 Nov 2018 06:04:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/0smNNuQStEDVjeoyozdvGvGeLKrZskOlohutZmWEJk=; b=f+mSw5cpUaZcnpAq2GahJvGFTV0HHsWqEo3+scU7rhlulqlm+RgWgTsrIoUumxjtwJ BL835mB9Z3wcjUdARRVKEhU/ad8gPzgQ5WHiM7JpxUxKEzTYrefrjWJ0+31+V4+NXByI D9AWo9f1DgmdORxhd+5zRfFyRZPyXDLuG5l/9wuDvUeXpWebD7Yi/dpRswmq60NYTdYQ yff8hQdStJW0TTFuIk6TI2+wQC41fMtldAEZtwLjadENw/In3kHmZPZFUS6w+e/llg1o LR/mao8vIVdIoKkv0hY/WvxFgf84FEjEchkr2itYrD4tGsWPOywHQotzp2si8h58Q6JM thjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/0smNNuQStEDVjeoyozdvGvGeLKrZskOlohutZmWEJk=; b=gZCb+bj5FuT/wVxiHLedZwE4bxQZEysDYO8NXADAYikgdRgniTWut3wiJDQ1KXXgFw 3rBGgPe02WEAb0eqfFO4QJIxyqTvvsv1agrjwAG7czpJZ4qwpHJcDGdE95009PtSxlBa W+8q/8183RT+qGLldF6ylv4UACosTFOOkiZf39Pniko/lpUYlHThJ0WB7DaESIigSYk8 VIdTJjKDzmWccENfkmem7ZpY1SGJfkWabt/wnp4BqkJ6rLXQUp2BVyADLD+b7SJVI7ML 4HIlnu/2sBn/BPf07q8igrOyvNKQntkPzoBE35XMeDEu8waPSvMEpN2x85xT0BVhLEsN yHiQ== X-Gm-Message-State: AGRZ1gIp3s3QstluPhJYY4Va8Xi1FTiB3yx+LaE8N+I8r2kWCStOxG6D HmNcL679rl+qAdmGEBWljiIsIg== X-Received: by 2002:a1c:e088:: with SMTP id x130-v6mr4720487wmg.6.1541772298896; Fri, 09 Nov 2018 06:04:58 -0800 (PST) Received: from boomer.baylibre.com ([2a01:e34:eeb6:4690:106b:bae3:31ed:7561]) by smtp.googlemail.com with ESMTPSA id w18-v6sm15964987wrn.66.2018.11.09.06.04.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 06:04:58 -0800 (PST) From: Jerome Brunet To: Kevin Hilman , Carlo Caione Cc: Jerome Brunet , devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] arm64: dts: meson: disable pad bias for mmc pinmuxes Date: Fri, 9 Nov 2018 15:04:43 +0100 Message-Id: <20181109140445.17795-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181109140445.17795-1-jbrunet@baylibre.com> References: <20181109140445.17795-1-jbrunet@baylibre.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In some cases (such as a boot from SPI) the bootloader or the ROM code may leave a bias pull-down on the mmc pins. If so the MMC will fail during the initialisation. Explicitly disabling the pinmux solves the problem. Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 ++++ arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 4 ++++ 3 files changed, 10 insertions(+) -- 2.19.1 diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi index e86f5f721f8f..bc427b9d3e13 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi @@ -273,6 +273,7 @@ "emmc_cmd", "emmc_ds"; function = "emmc"; + bias-disable; }; }; @@ -503,6 +504,7 @@ "sdio_cmd", "sdio_clk"; function = "sdio"; + bias-disable; }; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index 1cb8e7e0d0da..32ef82321340 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -363,6 +363,7 @@ "emmc_cmd", "emmc_clk"; function = "emmc"; + bias-disable; }; }; @@ -370,6 +371,7 @@ mux { groups = "emmc_ds"; function = "emmc"; + bias-disable; }; }; @@ -416,6 +418,7 @@ "sdcard_cmd", "sdcard_clk"; function = "sdcard"; + bias-disable; }; }; @@ -436,6 +439,7 @@ "sdio_cmd", "sdio_clk"; function = "sdio"; + bias-disable; }; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi index 7cfee40d89e9..cfeec5579726 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi @@ -310,6 +310,7 @@ "emmc_cmd", "emmc_clk"; function = "emmc"; + bias-disable; }; }; @@ -317,6 +318,7 @@ mux { groups = "emmc_ds"; function = "emmc"; + bias-disable; }; }; @@ -363,6 +365,7 @@ "sdcard_cmd", "sdcard_clk"; function = "sdcard"; + bias-disable; }; }; @@ -383,6 +386,7 @@ "sdio_cmd", "sdio_clk"; function = "sdio"; + bias-disable; }; };