From patchwork Tue Jan 15 23:07:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 155677 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5454531jaa; Tue, 15 Jan 2019 15:07:53 -0800 (PST) X-Google-Smtp-Source: ALg8bN7Xgw7pDeqAZMR7rRf5UOD3BHW/Fe5XdOWRhSxBclOdhZQnB8zab1f20axDsA0lSpU9UhxL X-Received: by 2002:a17:902:780a:: with SMTP id p10mr6762356pll.54.1547593673465; Tue, 15 Jan 2019 15:07:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547593673; cv=none; d=google.com; s=arc-20160816; b=UYTInFWZvQXluBgCZ6AmKBFz2FPmjIUJovsU1Ohs7zfNME6I8HqadH7b/pOT6/alpX QIKT4PUMSBymU3RNogzLhJOn2VWHKyvanl9l4F/qaTmYAkcHwolkeNpWFXx8GYazcOrP TTQmfWozmuCMysZ4Kwbyoi5XqnX6TQYfiNduPug2Gg34BArF+MMzoIAqTsEjRc+vY/UC jJuSfWMDOaz9zc1IgE+G3AnESO/H0VYBQSadnd44EdQsxApDdmweAHupmRYeJuWeoUZy TJUDsiKDGO/t8nWHnCOcnMZc4b7c8JOWT3UgKnDkLugBM5Gmh2xExxIK2sfxxfxiV5y2 pCFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=voXZlLjcF9iMfJYraScWxo2aiNSp6J0i0hFMp6bhq5w=; b=SSXO18a6rVJT2KT3tahoBUJ5tdLXSTDuO/Ce5mNclZF54L/wJlhQxBiCGXpGiC+Kby Hp/bEou7mqnHLRNb3P5Q4Dt01N7LH4LbC37FYomeDQm/dMR8ZqGgOl4AKgGYl99SSEZl AsbstYpbPMo3FWHPoaBHi/ktf6kms5MAjQWuGRmrfpsvmK52m7HWQXBzvjeu0XHUoZhl zfOkKb7XM2KO78k+ieYYtamzT+ZjbCzopAbKwULcDrY6KYk7UsE5xVJyOhxrY04GZPcP RjLDIgfEpwhfXtgonC+paErR1DpbG7HL+9eq9CSAeEf3Lvuw5Eur3DxN26FAxzYYYLmS J0nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RGx3oU3n; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si4476923plv.258.2019.01.15.15.07.53; Tue, 15 Jan 2019 15:07:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RGx3oU3n; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391301AbfAOXHw (ORCPT + 31 others); Tue, 15 Jan 2019 18:07:52 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:46639 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728757AbfAOXHt (ORCPT ); Tue, 15 Jan 2019 18:07:49 -0500 Received: by mail-pg1-f194.google.com with SMTP id w7so1869864pgp.13 for ; Tue, 15 Jan 2019 15:07:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=voXZlLjcF9iMfJYraScWxo2aiNSp6J0i0hFMp6bhq5w=; b=RGx3oU3n6x8+7l4o/Ne17g9eKln9qFOkWUXrvDRCLKTIeYzgAOQy/bAZOkXLMTgVF+ yteMBn8xkbIaYkod4nEePuIaSFeCqPjEG9M5u/rLh2JaXM4YeZMpNXcrbcjCuCxnFep3 +OVBcBZr/ANaevqHnj/b9Kr21ZHOtwY2DQZiE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=voXZlLjcF9iMfJYraScWxo2aiNSp6J0i0hFMp6bhq5w=; b=I2KX3LvWYGiLuw8aDdxbv/kkPusIYMBxQuHWGn9qSVprxqhHRhlB17vXVy5Kp4ap1d HJJ6KBKkNy2dTx8So1FmOlWhtS5n/CGP9GLxjNf3KSMV0BjbsH+/wt7Mwrv5+F5V56L6 T9zw3RYtaqzddx15wZfo8Czz50kMWreD6Dhi2hsgTipSjnt6tjc5IOpYRU6B7KJGaDXt hUzOqF8/duX5qoc/hadrrFMuD9X7JXgAKmDqghpmFxobIU+L8wHzwbkIOanW59GfnUjD dQDX4NbWsgeGUIhhxRM9bPwMLhNTBJSA1Tje5h/TWOkoBVpO/YMMVQzockbeA328fCrL 27Lw== X-Gm-Message-State: AJcUukd3raZIi6M9YZTSK05z78Qk53GSMb2vxFyqgkQvPTmI0kwud9BQ AZKa3EekxZAizP+f0FrFhOTzQQ== X-Received: by 2002:a63:61c8:: with SMTP id v191mr6052271pgb.242.1547593667822; Tue, 15 Jan 2019 15:07:47 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id h19sm4985928pfn.114.2019.01.15.15.07.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Jan 2019 15:07:47 -0800 (PST) From: Mathieu Poirier To: acme@kernel.org, peterz@infradead.org, gregkh@linuxfoundation.org Cc: mingo@redhat.com, tglx@linutronix.de, alexander.shishkin@linux.intel.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, will.deacon@arm.com, mark.rutland@arm.com, jolsa@redhat.com, namhyung@kernel.org, adrian.hunter@intel.com, ast@kernel.org, hpa@zytor.com, suzuki.poulose@arm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/7] perf/aux: Make perf_event accessible to setup_aux() Date: Tue, 15 Jan 2019 16:07:36 -0700 Message-Id: <20190115230742.13730-2-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190115230742.13730-1-mathieu.poirier@linaro.org> References: <20190115230742.13730-1-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When pmu::setup_aux() is called the coresight PMU needs to know which sink to use for the session by looking up the information in the event's attr::config2 field. As such simply replace the cpu information by the complete perf_event structure and change all affected customers. Signed-off-by: Mathieu Poirier --- arch/s390/kernel/perf_cpum_sf.c | 6 +++--- arch/x86/events/intel/bts.c | 4 +++- arch/x86/events/intel/pt.c | 5 +++-- drivers/hwtracing/coresight/coresight-etm-perf.c | 6 +++--- drivers/perf/arm_spe_pmu.c | 6 +++--- include/linux/perf_event.h | 2 +- kernel/events/ring_buffer.c | 2 +- 7 files changed, 17 insertions(+), 14 deletions(-) -- 2.17.1 Reviewed-by: Suzuki K Poulose diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c index bfabeb1889cc..1266194afb02 100644 --- a/arch/s390/kernel/perf_cpum_sf.c +++ b/arch/s390/kernel/perf_cpum_sf.c @@ -1600,7 +1600,7 @@ static void aux_sdb_init(unsigned long sdb) /* * aux_buffer_setup() - Setup AUX buffer for diagnostic mode sampling - * @cpu: On which to allocate, -1 means current + * @event: Event the buffer is setup for, event->cpu == -1 means current * @pages: Array of pointers to buffer pages passed from perf core * @nr_pages: Total pages * @snapshot: Flag for snapshot mode @@ -1612,8 +1612,8 @@ static void aux_sdb_init(unsigned long sdb) * * Return the private AUX buffer structure if success or NULL if fails. */ -static void *aux_buffer_setup(int cpu, void **pages, int nr_pages, - bool snapshot) +static void *aux_buffer_setup(struct perf_event *event, void **pages, + int nr_pages, bool snapshot) { struct sf_buffer *sfb; struct aux_buffer *aux; diff --git a/arch/x86/events/intel/bts.c b/arch/x86/events/intel/bts.c index a01ef1b0f883..7cdd7b13bbda 100644 --- a/arch/x86/events/intel/bts.c +++ b/arch/x86/events/intel/bts.c @@ -77,10 +77,12 @@ static size_t buf_size(struct page *page) } static void * -bts_buffer_setup_aux(int cpu, void **pages, int nr_pages, bool overwrite) +bts_buffer_setup_aux(struct perf_event *event, void **pages, + int nr_pages, bool overwrite) { struct bts_buffer *buf; struct page *page; + int cpu = event->cpu; int node = (cpu == -1) ? cpu : cpu_to_node(cpu); unsigned long offset; size_t size = nr_pages << PAGE_SHIFT; diff --git a/arch/x86/events/intel/pt.c b/arch/x86/events/intel/pt.c index 9494ca68fd9d..c0e86ff21f81 100644 --- a/arch/x86/events/intel/pt.c +++ b/arch/x86/events/intel/pt.c @@ -1114,10 +1114,11 @@ static int pt_buffer_init_topa(struct pt_buffer *buf, unsigned long nr_pages, * Return: Our private PT buffer structure. */ static void * -pt_buffer_setup_aux(int cpu, void **pages, int nr_pages, bool snapshot) +pt_buffer_setup_aux(struct perf_event *event, void **pages, + int nr_pages, bool snapshot) { struct pt_buffer *buf; - int node, ret; + int node, ret, cpu = event->cpu; if (!nr_pages) return NULL; diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c index abe8249b893b..f21eb28b6782 100644 --- a/drivers/hwtracing/coresight/coresight-etm-perf.c +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c @@ -177,15 +177,15 @@ static void etm_free_aux(void *data) schedule_work(&event_data->work); } -static void *etm_setup_aux(int event_cpu, void **pages, +static void *etm_setup_aux(struct perf_event *event, void **pages, int nr_pages, bool overwrite) { - int cpu; + int cpu = event->cpu; cpumask_t *mask; struct coresight_device *sink; struct etm_event_data *event_data = NULL; - event_data = alloc_event_data(event_cpu); + event_data = alloc_event_data(cpu); if (!event_data) return NULL; INIT_WORK(&event_data->work, free_event_data); diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c index 8e46a9dad2fa..7cb766dafe85 100644 --- a/drivers/perf/arm_spe_pmu.c +++ b/drivers/perf/arm_spe_pmu.c @@ -824,10 +824,10 @@ static void arm_spe_pmu_read(struct perf_event *event) { } -static void *arm_spe_pmu_setup_aux(int cpu, void **pages, int nr_pages, - bool snapshot) +static void *arm_spe_pmu_setup_aux(struct perf_event *event, void **pages, + int nr_pages, bool snapshot) { - int i; + int i, cpu = event->cpu; struct page **pglist; struct arm_spe_pmu_buf *buf; diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 1d5c551a5add..3e49b2144808 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -409,7 +409,7 @@ struct pmu { /* * Set up pmu-private data structures for an AUX area */ - void *(*setup_aux) (int cpu, void **pages, + void *(*setup_aux) (struct perf_event *event, void **pages, int nr_pages, bool overwrite); /* optional */ diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c index 4a9937076331..857308295f63 100644 --- a/kernel/events/ring_buffer.c +++ b/kernel/events/ring_buffer.c @@ -658,7 +658,7 @@ int rb_alloc_aux(struct ring_buffer *rb, struct perf_event *event, goto out; } - rb->aux_priv = event->pmu->setup_aux(event->cpu, rb->aux_pages, nr_pages, + rb->aux_priv = event->pmu->setup_aux(event, rb->aux_pages, nr_pages, overwrite); if (!rb->aux_priv) goto out;