From patchwork Fri Feb 15 00:45:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 158457 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp103582jaa; Thu, 14 Feb 2019 16:47:44 -0800 (PST) X-Google-Smtp-Source: AHgI3IYI0cyskvxl0TPKlc7llmAkqC+u1Q1tvCCVzB9wsjQyZCW3wcdal+9II0HS16NJMjFq9u5B X-Received: by 2002:a65:4904:: with SMTP id p4mr2698249pgs.384.1550191664527; Thu, 14 Feb 2019 16:47:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550191664; cv=none; d=google.com; s=arc-20160816; b=XStkhFS0iCK0sct2lj1l1Ic+GD1cqynY5wi7MMFdNcAjJDV6yP+ZkZFqNEFnmTp3eM +znWxZ6oCVyiPHXNmHEYSAHxiDIhHojGJH6EpGpZGuAQVL9P4rh+Es7g6W0Rh1rCkKQx cIaoKZJ81xn/t+5ia/P1WcSciO/ogM1CWNkIR2j7cLYO6SS5f9an4Qv6MKJaysfFeXBq lENF5BtBY24UTuk7F1MJvMsIbnChCqsU2lT9OnzHceYIn4C8mfTH2JRLr4BtKrCQpWO0 6eRWnjWK5ZY92IGe2OBS/QSdWpkT5hN93t3jmLAyop0hu3RJLMkPE9iOw78Krj3KTvOr e6UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CCha0YWke1GELkFxdmpnUqq9HNpWT3n3UqXNlCrht1I=; b=tH3l5fPIiSAKhkEOvP0S3mcCJf2xEUaiU+xwWhyMSSXltBx/fW8GISwpLSRDpK6jrc VLx3UFlcp3L5JhNH3dNJC5rkNxf/mXnV09Zmo3nNwlSkhE9n3GLDHyjC5NX6gb0U7eHo vH8/cFcGdK3WhLxRj5r9AQwoVl9yuY4Vk7DeXeqYLLOAvaqg00Rd41XfIjS57X/kWBKR xL5fVn5eHLjj4QzLOQ535T5xH9RKSMlLO8aIUhRimRqwVzbKBRxUM3Zy87NM+8K3vJDO 3eYTLKjISwm/P/oKJUvQWh29B+ScOWJy2pJbtBoIWuB/UvMEqfC8KzYE87/7rH3+9mXu 8XCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="zK/XHAsa"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gn11si3859151plb.94.2019.02.14.16.47.44; Thu, 14 Feb 2019 16:47:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="zK/XHAsa"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730478AbfBOArl (ORCPT + 31 others); Thu, 14 Feb 2019 19:47:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:46424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389281AbfBOArh (ORCPT ); Thu, 14 Feb 2019 19:47:37 -0500 Received: from quaco.ghostprotocols.net (unknown [189.40.103.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36E24222C9; Fri, 15 Feb 2019 00:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550191656; bh=pOeRP4uZkpi3aMp0MnlfEAGPtSqz5e2gzJj/+OoQsRw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zK/XHAsa7izj1acW4Xdbe4LufcCrIPpSweD0YK9HyzDdXApiNPYLADXrXA5TQX+lG cY35qBPjAPhKg32/hdEYNrM964tJbLiViFca/qAJ68pSkP9DrbC5zMLavg36Zt97Bo 1ILSiltBJKnQdTYcLjNq/G1q6jVZ/eC4w5wyK1Pc= From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Mathieu Poirier , Jiri Olsa , Leo Yan , Peter Zijlstra , Suzuki K Poulouse , linux-arm-kernel@lists.infradead.org, Arnaldo Carvalho de Melo Subject: [PATCH 25/43] perf cs-etm: Fix wrong return values in error path Date: Thu, 14 Feb 2019 21:45:21 -0300 Message-Id: <20190215004539.23571-26-acme@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215004539.23571-1-acme@kernel.org> References: <20190215004539.23571-1-acme@kernel.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mathieu Poirier Function cs_etm__mem_access() is supposed to return a u32 but the error path returns negative values at a couple of places, something that really throws off the clients using it. Fix the situation by return '0'. Signed-off-by: Mathieu Poirier Cc: Jiri Olsa Cc: Leo Yan Cc: Peter Zijlstra Cc: Suzuki K Poulouse Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/20190212171618.25355-4-mathieu.poirier@linaro.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/cs-etm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.19.1 diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 1d9419a0cf0c..f396fee9bb95 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -324,7 +324,7 @@ static u32 cs_etm__mem_access(struct cs_etm_queue *etmq, u64 address, struct addr_location al; if (!etmq) - return -1; + return 0; machine = etmq->etm->machine; cpumode = cs_etm__cpu_mode(etmq, address); @@ -332,7 +332,7 @@ static u32 cs_etm__mem_access(struct cs_etm_queue *etmq, u64 address, thread = etmq->thread; if (!thread) { if (cpumode != PERF_RECORD_MISC_KERNEL) - return -EINVAL; + return 0; thread = etmq->etm->unknown_thread; }