From patchwork Thu Mar 7 09:32:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159811 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp7216929jad; Thu, 7 Mar 2019 01:32:52 -0800 (PST) X-Google-Smtp-Source: APXvYqyGftCI6rwPHul0/+bRwhfY2u6tTbsdFYFQ4u83iNVayuCorp9p7RpQeZ9FqhmWblbw4z3P X-Received: by 2002:a17:902:4545:: with SMTP id m63mr11642854pld.71.1551951172119; Thu, 07 Mar 2019 01:32:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551951172; cv=none; d=google.com; s=arc-20160816; b=nAN3YxUf2iJm57LJw8WhcYE7ry5lziwaE1SjrXEieQAm7uht+o866B15Io7VudtpMf iSgcFi/2THgPO29T7v/qIFYOK3dumDrRgLFBRudjS5U9EV146TpwDMDI1IQcK78Xp/9B hi2wh6o2mQlguF2MrYZiAwDUDpEFsj7HUFpJZ2DTuXRkuu34+F3xxEbgXYItt40XzY2A e/1YijeAF2s4DE5VBBsSgtbh4A8UvCKy04boMw3vX2sHoCZWS5AIUGPZf02Jo7irujhU nt6fJGBbhvxzO+MWLsmO28emkimvdcNfhMLl6GNVZTYSuZCcXOAZq4xqkj5+1FJl233C 6wtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3sUvQTct0G1heN4IbOdL9jXe9zqTzHCRWGdlZbcKpTg=; b=L+VgyoUe+z4BXLuFbsHQpB/HtHmqBgSNOhkBpxWZd4xXtfD/zzHUwyov2yFj4Uuta4 3yzw5OuASD118lZmFDQTo+9F6mBdrdDvzUdUgFv/3KrkeRMyRxTAGJ8fuHwLH5Vqbsm0 T2m8VBYcW7z36ir9rcxlX848cJlkuklQfhRGi9cZL8wfB59CMmzKPg3tbydzETYmgxzi gVAL2IpEoSZI0ha8TA/W3IXR+q1eaqtLvFX4i5atQF94baCjz3GjGmUbphCbjknBxEZi uiKRc3sx1BL/z8+7j/nKAKnq4zR5290HPAKwy2D8rktmHERhRoZKDMQzkJi2KZ2rWBst NAPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b17si3774058pfm.57.2019.03.07.01.32.51; Thu, 07 Mar 2019 01:32:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726393AbfCGJct (ORCPT + 31 others); Thu, 7 Mar 2019 04:32:49 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:43133 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbfCGJct (ORCPT ); Thu, 7 Mar 2019 04:32:49 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1Mdva2-1gU8nl1vuQ-00b3n2; Thu, 07 Mar 2019 10:32:43 +0100 From: Arnd Bergmann To: Karsten Keil , "David S. Miller" Cc: Nick Desaulniers , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] isdn: isdnloop: fix pointer dereference bug Date: Thu, 7 Mar 2019 10:32:07 +0100 Message-Id: <20190307093241.3380715-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:SgTeDUmCb4KFlphK0yPBLuw2NW6S032Tn10HjVm7TU0Czb6EpYa eRYVPB0/X6ZkfbzCWEXtFHhAGF4ttjsX54MPpkY0asX0xZBt1PLHacdMoVns5haU0tnQMe/ qjQCVtT/gaJ6u5ZSh7eEa8hPpZ3jcvF+24HzToq9iSx0Vd4sv9FQ4U2fJ+oeDkBiYPr9bWl ATQ8CRZIe0gfrue85Dl/A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:xHhHN6Ai/kw=:xI/ns8pM133uhDonbRMncj Hk7sn8MB6WzkS5LlNHX72iouVZxeXHpQBCKlI5mqe+Yh5Eru/2hkGY7TZw+e1jMQ6GMp3zCuT TonvZdVPfYJ0dw9tLbeVqmUosaqY7J8znfww5hxsQ3L6iQqKzYJ8m6T25JylcUe158OlT29Dg 1NNN9I6o3HQGQdYoq4v0iMtzo80EjkoJsnvDISpRyRQpXmS6GgCbITmx6xXTSMbK+/MdQkYra 9LxwV/1W/36T/UEzPmGuvHGEspMl9P/lFwO/E7RqSDG+bOj2CHj/M791OfcdZ8whXsXYzEtFu EftV3QrasQO1fPsmqt3dav6CJ3SqlltXRQUuYJAH658KH6+8UROWLCR7RFUIqsHuGIoBjjyLe 2dIS5Gr059KPQQsTaDZGcCHU2uEg1+w6kgjk/JeuUDpCS6OH9UVXw0/St6h6m0vMASvj9BCC+ pCDjJ0sEF+z8sOW4B0T6EoCdUAy8cryXA0dtt0gH6ItNe03+UPvC4zqbRcifRqQg0UgWvvuue BeyqAMobRpWw7J8A9sus3U9PtJSCcEouI0aIE0vqvz68kxYNU65cu5h+a+oed32OJBOWgIiM4 0YYdS2Ad9UGWcOEkmptvMlvlAtAWmnV/NDQRCZN13hdnutyQ3Qh/rwGOX8zOVDn4RG8lJO7MK wvWD4DpspeKTHgiOIYOz50mKP1hPBE7YWgWJ81vb9sYpW1bdaGpIE18ZyOTKKH6M5JrfHjNPo 80PQXI8qU41f92QjwMrM74Xv5LkQGP2RSICypw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clang has spotted an ancient code bug and warns about it with: drivers/isdn/isdnloop/isdnloop.c:573:12: error: address of array 'card->rcard' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] This is an array of pointers, so we should check if a specific pointer exists in the array before using it, not whether the array itself exists. Signed-off-by: Arnd Bergmann --- drivers/isdn/isdnloop/isdnloop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 Reviewed-by: Nathan Chancellor diff --git a/drivers/isdn/isdnloop/isdnloop.c b/drivers/isdn/isdnloop/isdnloop.c index f4253d468ae1..755c6bbc9553 100644 --- a/drivers/isdn/isdnloop/isdnloop.c +++ b/drivers/isdn/isdnloop/isdnloop.c @@ -570,7 +570,7 @@ isdnloop_atimeout(isdnloop_card *card, int ch) char buf[60]; spin_lock_irqsave(&card->isdnloop_lock, flags); - if (card->rcard) { + if (card->rcard[ch]) { isdnloop_fake(card->rcard[ch], "DDIS_I", card->rch[ch] + 1); card->rcard[ch]->rcard[card->rch[ch]] = NULL; card->rcard[ch] = NULL;