From patchwork Thu Mar 7 10:31:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159833 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp7268469jad; Thu, 7 Mar 2019 02:33:00 -0800 (PST) X-Google-Smtp-Source: APXvYqwEjKFJZrT1ibzNvqxwUMGkSzGhP+wqsAjV0hB90K4mPLroeBi1HkPdz3Cy5WaqIZ4QxkTC X-Received: by 2002:a63:e40b:: with SMTP id a11mr10732723pgi.259.1551954779780; Thu, 07 Mar 2019 02:32:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551954779; cv=none; d=google.com; s=arc-20160816; b=rVTSEXLW9cE8UEE5zcuvnCqx/UkqjVyVLIINg7moy4D7wZysRg3c+h5DyG0HuoXa6t 0b7b7+qsW4/PBRp7kw6i2rqfDzN8S1BAtiIN80jOpidjh3sIEAJX96NPrgBUErAuY0Q0 gAhRAaTlcTlmSW8ng4zg5SG2XyiUBehlzHUvh2YSWNbOE+16rTI5YvvD9DauAVHY+I3V HZi5KAwCJd8mSPyKmaf+ICCVb6sqiLOt3gcCv9qUP1KfdcHigDqVS7UA0mGvdLav12UQ 9ohZbxVEDT7wC4zqBBeiFIeUkvVQlLLEe3tUtGJ2nRoSdm5QBE77uAIiqn+C+a8JBlFN yYEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=eLvDi+MrpVu834E2jDS8l9sebanV9vHpzMy37axstbk=; b=ZJfECj5/DVQvp0XuOzhH9dbIISht7XIlxicuWnrX7M6gHC6cjpGtodZ9HWdtsfENQt b7oYuEE4KUzIOWqbtPR2kllV+53/6WB3EPZwex2gf/ebwOANX1H4xJdch+pztYfP7UjX 7ROfzNQdlhlLHtBFpxgaFoJ7UwHwGhJI0Fla1yWAkr4Hb/JUmPRwiqMKh9tkKfvazcKh LNTYjitLBkCTeFlZHkPaZLaN1lBEH4KImmjLNc1qmm5M5RKgyp8HQOxKPgGWf23VdXpU mXh80e4BiBOKVnF6Zo4PvfbOMKQtlkeOZjNP4czFblRMN1J89bwC/46LA8sd1FBe7W6q faDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o24si3575343pgh.114.2019.03.07.02.32.59; Thu, 07 Mar 2019 02:32:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726409AbfCGKc6 (ORCPT + 31 others); Thu, 7 Mar 2019 05:32:58 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:55893 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbfCGKc5 (ORCPT ); Thu, 7 Mar 2019 05:32:57 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPA (Nemesis) id 1MS1G7-1hVAVG2Dwx-00TRzg; Thu, 07 Mar 2019 11:32:25 +0100 From: Arnd Bergmann To: Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" Cc: Nick Desaulniers , Arnd Bergmann , "Gustavo A. R. Silva" , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] peak_usb: fix clang build warning Date: Thu, 7 Mar 2019 11:31:55 +0100 Message-Id: <20190307103219.1539316-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:MwzC7PHGmR/ZaFJettcRS7X4cH35yXFJbgHGX/earEEn3KFTJcO WexMVORtDuzJ4C3EKmyRRxLLptM8sU96ru45JXUh1rIeMSv7XG8PlD9s4x7B6/ErxIZlA33 ErqoN+bDsaFHeXRhWfZJEhp3gy2GGbja7M+VpdJmkQTkdSE1gKqnOnBVS9b2gDRQFIX5+dg c4dOFqYVmB7Vwfq3bgKyA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:tQ5sTkHexPI=:m+uhnXGrITU6ocPc2ZUSxD fraZ+R/xw3p/DwQ4R7mC7J6L+cBmDwWROFiaJUyJdjO5fhwe4MjK5gwx82WYDh9lvk3M69Srl Xfm0aom0dRQCJy0fK65qIjq1ZXq8qWQYZQQvifvs6bih1cPtBLRg6pHOAtBQA54bSGn7ei6P9 grcRfW1+EDxXc5U4xzDJy8rCdBBZmOC6vOmFAmfRb6anaRMMJWYVCla+BkkMupQ9CbGhQERb5 1o5FmpjYcr3iBut/6Rl2KBSB8/FKyLP+Q/l1Sh+YZxZX5RPEw9wcFB/86z4Zu9skurcWlVMLL VHJuaBONHbugE4z2iCCHWBkrYeFLXo7v3ah0AxI4ZUuXIRZtlJmXUb8FhaD1Ir/QDwnl4X7jH VK5mz1+Y8FDFFfX6eW3Aml0pteQAxxQI8X4tDvilkDQaVMtVOx2csN9AHMkCECZeB8fjkJazq yfRvyhHyH7Z1NxTBBMXVk6pnwDqc65xqdaQsqjfoGzGs7E+q2uBYEUQRMyU5lzq1zlJNEr93C V+LKWM/5maNSB6ELsPcptXUorUE9V8bEfLMPgxxzb3WtYZvuBzLEiCz/QGeSoEfT5IpaGMqOL lLfcMShn6hCDOBczi5jpwkdKjUgSN+V6NwTDLqPRhJm1n468CHyP/jMTc+tg9Y8OeMnyam5A9 6m7sM+JrNiCwGRAf3OKipXaLvY8XqzvQ9ihBSh4ab7Nw8oytpm4FKCAo+wJY0oAm6PUPgNg+e m6m1Quf8kDeIWumZvbBvGZuV+esHewxYqVHKrA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clang points out undefined behavior when building the pcan_usb_pro driver: drivers/net/can/usb/peak_usb/pcan_usb_pro.c:136:15: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs] Changing the function prototype to avoid argument promotion in the varargs call avoids the warning, and should make this well-defined. Signed-off-by: Arnd Bergmann --- drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 Reviewed-by: Nathan Chancellor diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c b/drivers/net/can/usb/peak_usb/pcan_usb_pro.c index d516def846ab..b388406ac0f5 100644 --- a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb_pro.c @@ -127,7 +127,7 @@ static u8 *pcan_msg_init_empty(struct pcan_usb_pro_msg *pm, /* * add one record to a message being built */ -static int pcan_msg_add_rec(struct pcan_usb_pro_msg *pm, u8 id, ...) +static int pcan_msg_add_rec(struct pcan_usb_pro_msg *pm, int id, ...) { int len, i; u8 *pc;