From patchwork Tue Mar 19 21:15:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 160613 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp27607jad; Tue, 19 Mar 2019 14:16:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqxkaKuE1BefiCXzBCECeFSnA6BDcwXM3KZjmJLSobCm1XYTW+EHZJCc4mTophgKH+WkEVxm X-Received: by 2002:a17:902:2c83:: with SMTP id n3mr4337680plb.281.1553030199678; Tue, 19 Mar 2019 14:16:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553030199; cv=none; d=google.com; s=arc-20160816; b=PNiilC5ZmfdCJQVapdexvLGZzc7bYNoeAGtuY5YvEb7aIBaguY7O9pSssSf6bGKHvU /ZFCAN30Ih2vC5Ywupqy5/VzZYlngzP60ZNHQyVnu7pr0jKYOS7xm3yPL9+3hbV62ljD cUljyNoYByILDgZlzaPRbSrIOzWGXzLy/REWlPnypHFir3Ah02XBk8BhFH9gSlxNs2Vr ZMQX9EtZMxRsZu72SJNDJRhbgHGPcA6g0InIyInBz0lze6n7aKdoegkTFZfCZYsLXGKW pZ/Z66W7GVFVmUZeTxz6zhP78JXgCBO9YnE+Uqkx8TarsvoTuXPIcEe7AhQm+LRNeTL/ Azfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MjN6bSZwTNm6/ZnGvQUuhFc9v/uSqnWNo9LyOA3X2oA=; b=vM1uLq5qx9qDiAoVz/gSgk4vj3IKwkRTPIkfaHlibm+V6RcOZfIQka0yrT9gB01HM5 3wip0dcZRuW21ZCCfHzrW+ol5sHTIjhc/UAuNKSQrjDeNxIqcibh4mG0pXogB9zPFpfE NSFUirs0FDXe1cBWeLErXwf9Bl9mNRLHqvtbKSC2x1vDGNYhLmpPoAcG2JOJkuAs8AsV Aafa4SQMBTM3Wdp5IOUow7aSaKRnFLJGZEnreVwAYOXQr8/okcmr+FFGeeAhN+Zd2go3 vGaUaMYeW7UVmspI4pA7s1XALWG54oWq/XpU2O5kTlfUt53pAt828Bttf0oFFE+wMtCW UxEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i67si13604378pfb.117.2019.03.19.14.16.31; Tue, 19 Mar 2019 14:16:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727546AbfCSVQ3 (ORCPT + 31 others); Tue, 19 Mar 2019 17:16:29 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:40313 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726712AbfCSVQ3 (ORCPT ); Tue, 19 Mar 2019 17:16:29 -0400 Received: from wuerfel.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPA (Nemesis) id 1N01hu-1gm3aw2RhG-00x1eV; Tue, 19 Mar 2019 22:16:24 +0100 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] 3c515: fix integer overflow warning Date: Tue, 19 Mar 2019 22:15:58 +0100 Message-Id: <20190319211621.3466443-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:Br1gpG0HzUNciC09SPVA7dwsqMQJVJxDJB1m72WcRRx1Em5zUa/ OC+CWkRvGR/bpqzo6I/UHerAO8gExi8T7J2E806P0Fl9+copCKrCig4gci8qg99Q2dGYOIr ZMYEVmGAMLLsp0+mDW5rwXckNuoc2DiNLo4TheWGcRnoXH+aGa5lV7awnLl4QeW1ql0fNYi PQLvp4CWZcqYJVoweuq8A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:nQ/zHLbCGm8=:N1aJuCA7ITCWYTSuQ2dLfB 1W7dEYlSbdCcWk0pNXc6V4g73fSZDRzD7QNS4gtGfnuk6OHhmygyqhUrVf0vDQimoS7iE3prX nBfVyNUcCxQ1mQXm0Bhp+dXuFvY0pIYHZvay56iZY7l/iV44qJ1bA3NqeGhB5ceTsBuZvdmyX B5lpEfV5qam/RTiCpBkh48x4796egXmbOmbHpsiiSZ7FO+xAOKK3/vnf6TAzjDZqRITByMjyG W9GW9tebTnxgkkaLwtSrsGoYyCU7FbwUQ6aHKydKBBMtaGHLDgrnVvQcRMhEOXrI4QVj5EwkG HdjAC5a0t/JKWtRMBJM3h7GpVfrQM8tokD3Rc3eFhSD4PcpqkWYCdCELTIIhGd3H+oVeRrryz aqckJpP4zmLzpOkraf71xX3/wsfqtfl4S6bh6b9zXyI5kwNG3qzYi4wXQBuYUVAzQoGsPeSg3 dKSbYiob481TupAxel6ODuytou5HSHK3XqUhkzLR7RQo/bppM95GiTgtrVKgN8pxTl1Vsp4Bu LCYpNvSfYsCTQvlsnl6LJH6nSKroUMUnpzHce1B94JP1QzjNm4iSjuismqMVCQWR7RZcw1YWE U+uwGPWlRCM04K31qgeFPt53HiR4uiAbegZjD5T9Qwnz7VWip1d9vXRfbeCt845hJ6RU7isOm QXTGug0V1cbTblouKZWDEyhn3gio6hKzhocJNDfXr6z9PTItvte194kh2MWd0l3Jwtp4qt5is hkowFjjsGA9gfPxYfflAQFjY+NwXRxnlt8EIUg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clang points out a harmless signed integer overflow: drivers/net/ethernet/3com/3c515.c:1530:66: error: implicit conversion from 'int' to 'short' changes value from 32783 to -32753 [-Werror,-Wconstant-conversion] new_mode = SetRxFilter | RxStation | RxMulticast | RxBroadcast | RxProm; ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ drivers/net/ethernet/3com/3c515.c:1532:52: error: implicit conversion from 'int' to 'short' changes value from 32775 to -32761 [-Werror,-Wconstant-conversion] new_mode = SetRxFilter | RxStation | RxMulticast | RxBroadcast; ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ drivers/net/ethernet/3com/3c515.c:1534:38: error: implicit conversion from 'int' to 'short' changes value from 32773 to -32763 [-Werror,-Wconstant-conversion] new_mode = SetRxFilter | RxStation | RxBroadcast; ~ ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ Make the variable unsigned to avoid the overflow. Fixes: Linux-2.1.128pre1 Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/3com/3c515.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 diff --git a/drivers/net/ethernet/3com/3c515.c b/drivers/net/ethernet/3com/3c515.c index 808abb6b3671..b15752267c8d 100644 --- a/drivers/net/ethernet/3com/3c515.c +++ b/drivers/net/ethernet/3com/3c515.c @@ -1521,7 +1521,7 @@ static void update_stats(int ioaddr, struct net_device *dev) static void set_rx_mode(struct net_device *dev) { int ioaddr = dev->base_addr; - short new_mode; + unsigned short new_mode; if (dev->flags & IFF_PROMISC) { if (corkscrew_debug > 3)