From patchwork Tue Apr 30 11:37:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 163110 Delivered-To: patch@linaro.org Received: by 2002:a92:7e86:0:0:0:0:0 with SMTP id q6csp3130494ill; Tue, 30 Apr 2019 05:01:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqwXPm1MpyxXXRXJCOyEt6O6tLLffYKCxB3L0GmwaGiFTtGhKycg+Y0Zd3C4y133/YFO8kAZ X-Received: by 2002:a65:4183:: with SMTP id a3mr65730755pgq.121.1556625719877; Tue, 30 Apr 2019 05:01:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556625719; cv=none; d=google.com; s=arc-20160816; b=KYzCHsY4tJKb/vtfYMCNvv4C725gLvNfY13tDVxLPBEtcjX+1wq339BEBSKadawcjU skbPymkIMNhBXFKHVxr+/HxlMXEKDW4xi+lZgntDfcnLQZ/yc1Ea8jOnVQigsON7GHvU zf7y3WXPM2GJSRGafeEiilPf7QTFnUN71B3nQZ9k3AEKYLLSHOuguuAZYDzcsLitDSge 8ZUN8pPHOAT7Z6E1i/RmuKxWP4JmJhP5Syk1O9SZtivcp9UpFefcGqh9A7v07+HRAqV2 ryKEDRpge2RDP/rwxZwY/ben3iNVPHn2vNiXTkNA64OEsPJo77YGYMvtHtB71w/E0YIk KUMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ot9GoE7PN3Xcsagv3xwuybkfXyuAjhkc1TmwYKFneSY=; b=DK5TYw5qveuGopRXByRpB6IhRxmZPximODolb0e7IXxoNJ8YsqJWe8DCbFEAo8K1et ZduDsn+qy28PZojH6OC94cC1sWg8JNi0oV3psFXcWhLLboACG406+NRpZqLGwsv7D1S/ 08DGZMn3RNuaQ8gKDaAp+xihA3+yPBuUwik53YlEcou79cftrFUDAU7O99OngS2wZEkM LyL6ZxDcDgBvPG9N8yBQF9TQ0sg2UTwJmoXXOdU7r5fjjnyf95RPCaSSeXssHVmOH4AT PLPr4AIbhZJYHB4qf4debkM+W8SJW1ACVRyaNeB7D6FdwKRMFsOiaWtiz+S0ygdFbCr4 UGqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LOU+UOJp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j4si38062195pfc.101.2019.04.30.05.01.59; Tue, 30 Apr 2019 05:01:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LOU+UOJp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728898AbfD3Loc (ORCPT + 30 others); Tue, 30 Apr 2019 07:44:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:55822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728632AbfD3Lo3 (ORCPT ); Tue, 30 Apr 2019 07:44:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAE962177B; Tue, 30 Apr 2019 11:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556624669; bh=TsZdpmCy1pcPB5gfC6C686aDfKiW4WLiHwcWOX4x58w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LOU+UOJp2HDKLNV0Sx/U5bhyNo4HEugxWPguMk4vTPz/S4Hv+4IXSlwvigs6MIfdo BxL+kqdCUu1nr+/zC9Hd5BHhN9gkx/sz1QMAYD1mckgnDQUMt2s6/LGg18sZuiw3qk 30PlA7Q5zp7m/9zVbTonEukynIccN1DJMinc7BJo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Baolin Wang , Linus Walleij Subject: [PATCH 4.19 027/100] gpio: eic: sprd: Fix incorrect irq type setting for the sync EIC Date: Tue, 30 Apr 2019 13:37:56 +0200 Message-Id: <20190430113610.145108698@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430113608.616903219@linuxfoundation.org> References: <20190430113608.616903219@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Baolin Wang commit 102bbe34b31c9159e714432afd64458f6f3876d7 upstream. When setting sync EIC as IRQ_TYPE_EDGE_BOTH type, we missed to set the SPRD_EIC_SYNC_INTMODE register to 0, which means detecting edge signals. Thus this patch fixes the issue. Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support") Cc: Signed-off-by: Baolin Wang Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-eic-sprd.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpio/gpio-eic-sprd.c +++ b/drivers/gpio/gpio-eic-sprd.c @@ -414,6 +414,7 @@ static int sprd_eic_irq_set_type(struct irq_set_handler_locked(data, handle_edge_irq); break; case IRQ_TYPE_EDGE_BOTH: + sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0); sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 1); irq_set_handler_locked(data, handle_edge_irq); break;