From patchwork Mon May 6 14:32:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 163414 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:81:0:0:0:0 with SMTP id l1csp70719ilm; Mon, 6 May 2019 07:53:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqzrWcUAbNspgp06QYsmU7ye/rHBYNjJH5smQ//iLN+xK8Z6FoL21T4TV2vGJXCjXjT/1EZl X-Received: by 2002:a63:fd4a:: with SMTP id m10mr8017814pgj.302.1557154402767; Mon, 06 May 2019 07:53:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557154402; cv=none; d=google.com; s=arc-20160816; b=kDhNO+lVyZZKm2wxISyJJdvGA/3AyQoxBCwQh7QQgtnp3Ok6xaBSo1dKvwe3fPktzj o412kU7f05yqdgEWkjIDrgYijAdDwXOQ+9S0RMU6yzhjRenQ5GlLRAyuUSqFTwseNN+R bmZ6UQ3gsIb6UYM0OQ+6hIsKxn5TQ4UZ2ADbNBvLNL+nDEY2cYivm75pYDJGwpnHgMsu Jeh2vRM2uUXNTWpXu+JN7YlNiFTp4PT/0B2YpzAbhsh7f2AkvzQzHQEUDMFWd1MIMITu IMlQOHqmVNFOBEMcOe2KYqy16DI1nf1RvjIlqInL9mq8wRSnknhUymwUVOoX5DeDEFQX BpEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=793cLtw3HLHmuUR38m9SG7aHo3wnwmakxoLW5VIW/Ho=; b=WsH9YNpeRXDJBnrFL2DMsk1VMP94nHdtnkiEsxdpMSPIPdGw+vwcUQ5byW+KcF0thb ZDA8iL7krjLqn/aW3R8FLwJChDf1JO+nbpuwuRLKnbMp+jOXrt284JZRZMTUUqUCPECR LkKqnZS3//ok+uT37VNCWTLGWHk+b2lCw7hBjUJPxycay3D+X5SOMWGRJ86V3JVnqIby xeHZA3IZSYJ2hZIXEx3FgYR+sOHQwAaCqQ4t3/ad/LrEMDPHUJXgB++WGx6hgQcZ6bKr pSM0X2fKz8HYQKfMsz3Bgd3vAi58aF6GSlROcWIzVAPXW/XWcafUjJMkY0tglaPQVQMj v4/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=a9qkcwul; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l11si15789622plb.370.2019.05.06.07.53.22; Mon, 06 May 2019 07:53:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=a9qkcwul; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729326AbfEFOrg (ORCPT + 30 others); Mon, 6 May 2019 10:47:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:46292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727382AbfEFOrT (ORCPT ); Mon, 6 May 2019 10:47:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC8FC20449; Mon, 6 May 2019 14:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557154038; bh=vbPwdDLTa7OrWI0SflkBBJ7iLeQtCJf62w+l948vi5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a9qkcwulZLKR6zNcFJBYvGoS9Xa56qiqjXrNsesEpaB3rmDEXXbl8KAXRluVy8hle rO44TB43iCc3+OmsN3u+kvcHY1rn2isUbsVvM6ZP3QfOkBLl18dP5f9YeWvCG1LWx1 xf421H83RbfifHERmKsKj3kgKGX4nLlWCgRHL36s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Alexander Potapenko , Andrey Ryabinin , Dmitry Vyukov , Andrew Morton , Linus Torvalds , Andrey Konovalov Subject: [PATCH 4.9 15/62] kasan: avoid -Wmaybe-uninitialized warning Date: Mon, 6 May 2019 16:32:46 +0200 Message-Id: <20190506143052.384495640@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190506143051.102535767@linuxfoundation.org> References: <20190506143051.102535767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann commit e7701557bfdd81ff44cab13a80439319a735d8e2 upstream. gcc-7 produces this warning: mm/kasan/report.c: In function 'kasan_report': mm/kasan/report.c:351:3: error: 'info.first_bad_addr' may be used uninitialized in this function [-Werror=maybe-uninitialized] print_shadow_for_address(info->first_bad_addr); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/kasan/report.c:360:27: note: 'info.first_bad_addr' was declared here The code seems fine as we only print info.first_bad_addr when there is a shadow, and we always initialize it in that case, but this is relatively hard for gcc to figure out after the latest rework. Adding an intialization to the most likely value together with the other struct members shuts up that warning. Fixes: b235b9808664 ("kasan: unify report headers") Link: https://patchwork.kernel.org/patch/9641417/ Link: http://lkml.kernel.org/r/20170725152739.4176967-1-arnd@arndb.de Signed-off-by: Arnd Bergmann Suggested-by: Alexander Potapenko Suggested-by: Andrey Ryabinin Acked-by: Andrey Ryabinin Cc: Dmitry Vyukov Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Andrey Konovalov Signed-off-by: Greg Kroah-Hartman --- mm/kasan/report.c | 1 + 1 file changed, 1 insertion(+) --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -302,6 +302,7 @@ void kasan_report(unsigned long addr, si disable_trace_on_warning(); info.access_addr = (void *)addr; + info.first_bad_addr = (void *)addr; info.access_size = size; info.is_write = is_write; info.ip = ip;