From patchwork Tue May 21 06:09:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunyan Zhang X-Patchwork-Id: 164683 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp1208856ili; Mon, 20 May 2019 23:15:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6p5qZKWAuJnXVCWHqy+hNwHeEis1CEZLVfGBPv1TxunIHT8xHN8U3PUV7euB1z/4wgBT7 X-Received: by 2002:a63:da14:: with SMTP id c20mr18488082pgh.191.1558419355869; Mon, 20 May 2019 23:15:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558419355; cv=none; d=google.com; s=arc-20160816; b=E7i13AuUTpXVD/rWf7zX3kbAJ6kTCsrROjNSoJGms3GEAK81CxOPKvw9D2bjA4d78R Vow1QNUfQa6Drmkji+pNJoufKejbIo1loIJVaMvpgzHvUFr68MRk/SuOnvL2jXAvZNpe /Frb5Tm+3Ga2N343I6yhe8fXlW/QpU/8CxFps5ovwtxZvQF1w/PxOBXYkp8tc8OqgFiA 2WcWRHhZYfrGBey6dTh6fPqLozFpgfr/i/IrVRyp0ncvNBw6/W1Irp/4E9mlFJ/kuU50 RWbVaqg/OP18h8Jxuv+T6X1T1swEptWUkQTJVyZ5F12dlWvYpPafcefjnptPdXDlP6a1 EpwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=4R0Z1avkl5DcwArAEdYF5RKsOqx23+ElfNwQfhlhU8U=; b=BiT7+K3YDEwqRIP5nLpVNCarDmxxaZT1YmEXPTS2mhbyv6lXKWsSWgzdtj3TK4L2zv ifPDLyq8wp76z1sqcgV5BAzxPYVo83L/Sm8Q38NOjcXzsIzNuDd+ijdXxNBf1chCCaOl zTQ4kkOGzV1Zw4VNb3n/wcCV1NyAp+eK/gf4C7YtNZZVh68LZFgJYcxWRT3dsivwDPZt lzR9+lUNiqkfnHimtfXu/KxClO3g+kItC9I/iTp3Jq74oKxufqf1yVUYUaDfvOxyXaXI F8H1AVc0arFmaAbOD4dSNt+G7IZsFRfZ5Xz+Mfj/2Ef5hLAqVAfxfy22fy2uVFAsUX5H v7pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rWBEaPbO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f7si3518340pgv.105.2019.05.20.23.15.55; Mon, 20 May 2019 23:15:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rWBEaPbO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727962AbfEUGPy (ORCPT + 30 others); Tue, 21 May 2019 02:15:54 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:36128 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbfEUGPx (ORCPT ); Tue, 21 May 2019 02:15:53 -0400 Received: by mail-pl1-f196.google.com with SMTP id d21so7913170plr.3 for ; Mon, 20 May 2019 23:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4R0Z1avkl5DcwArAEdYF5RKsOqx23+ElfNwQfhlhU8U=; b=rWBEaPbOv0Ze4QP+zKqhgDJLjfQzgBZRlveZ5KKv6jzAPxoKfCAc9mSKLdMx/9jL3v nFmY67X/QCW8SlSFYYtgtr2TOtMrAz6nEGWK5x5dVRjLFh50dq7JDUw3s7bj6SzJ/E8I Himrhy2bu8WjqyccmLGj1r/JBcUBmkSVcN5j03XkSzrLQHubwWAiU/iwEml7Aezz4Rfq iZrUP6ztMtgo70T0vL607ynlVJImepQp5080ijDfWbjzF7kV/qvfOP6gDITJnzPftl63 g1SpLgLn40kDNPNGJq5iNOEPcyabqIhbNJdrg+RJCt1/gxr4Zr+zuxsJQoz/T8vnXL2R LJ2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4R0Z1avkl5DcwArAEdYF5RKsOqx23+ElfNwQfhlhU8U=; b=CNEO7b2fCW9MR3rg6YpTiFaOp6wcLvRBLgOhE45YyU7bg5AyOTFru3Xus9eWrFhjLY q3cAgHUjk+fAb5kAWiSXG6pPy8WWT07aHO1xtvhzXDJSyQDgBBiucTMNXHJjD6njnY8i eRLypXoRudKd410Zp+VadFD0cpVyg+Wtbmf8O0Fxy0TGWD9BFVi8OShFKI6atBlqrt2e T3QziWrIHBdJkTcU76aslEchbGOFMrxaPxax0CV7uIypm6bpLBBBiTXQYEYkIZCrfehZ /qg5Q+P6S06doCxKb0/icy05mu//YQ9ZsTi8oSJ1F6vsk5EU2vO1wU/wCkQDw3Ze6Wow wChA== X-Gm-Message-State: APjAAAU+Jk/fWQrD3H+qrMw3AOgfKtamKmilq1DXREwelWXbfdd8D34g hP/hMYYPr0lD0f1AEvKd46vezw== X-Received: by 2002:a17:902:1cb:: with SMTP id b69mr54576811plb.158.1558419352754; Mon, 20 May 2019 23:15:52 -0700 (PDT) Received: from ubt.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id k9sm23064259pfa.180.2019.05.20.23.15.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 23:15:52 -0700 (PDT) From: Chunyan Zhang To: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Orson Zhai , Chunyan Zhang , Baolin Wang Subject: [PATCH 2/2] clk: sprd: Add check for return value of sprd_clk_regmap_init() Date: Tue, 21 May 2019 14:09:52 +0800 Message-Id: <20190521060952.2949-3-zhang.chunyan@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190521060952.2949-1-zhang.chunyan@linaro.org> References: <20190521060952.2949-1-zhang.chunyan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sprd_clk_regmap_init() doesn't always return success, adding check for its return value should make the code more strong. Signed-off-by: Chunyan Zhang --- drivers/clk/sprd/sc9860-clk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.17.1 Reviewed-by: Baolin Wang diff --git a/drivers/clk/sprd/sc9860-clk.c b/drivers/clk/sprd/sc9860-clk.c index 9980ab55271b..1ed45b4f2fe8 100644 --- a/drivers/clk/sprd/sc9860-clk.c +++ b/drivers/clk/sprd/sc9860-clk.c @@ -2031,7 +2031,9 @@ static int sc9860_clk_probe(struct platform_device *pdev) } desc = match->data; - sprd_clk_regmap_init(pdev, desc); + ret = sprd_clk_regmap_init(pdev, desc); + if (ret) + return ret; return sprd_clk_probe(&pdev->dev, desc->hw_clks); }