From patchwork Tue Jun 11 18:57:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 166471 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp2718943ilk; Tue, 11 Jun 2019 11:59:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqwEbIXYTRc6dCM1MEsX82oW3ACFgRb2IEdpb+yBqHmsruuNW8gvGAx3AONuu0lpXMVfZDsZ X-Received: by 2002:a17:90a:1904:: with SMTP id 4mr9078859pjg.116.1560279582566; Tue, 11 Jun 2019 11:59:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560279582; cv=none; d=google.com; s=arc-20160816; b=w0ImljL8w2oqIo6tD7c5yVO7ckawJkz4/2p7Mdz15YNyGFcJx0ktyTxKNb+YVBmSWT dWac2vlPcQuq5D8rbOchR5KArc90Rz9pg6Tj8DpgpvKRtF+e6Mcu1/vMrbW2xH1W1IOK yg4qVBy6MUF12wOMy/XjAImRAQooQfCxatiIIaT6j7so1cloXNYVF2gIjdJUeHFGg1WQ BJA6elh3qCqSYJW9xgzxSiL7hyBgCw3XSrAMvvfKzrlQCJ56Ruof83kpNO3Hl759pECG OtrQV3QjncRx9yE1h9HZC9P+HlmmTkTU/EmYtFPXG1MSUfjvoeLLypnlYD/I0YJ+oaBH V9Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DdkQsMmUg8ShoPkXbSsLepPH3MPIu2KDDdrAGWzVtL8=; b=SHcBcPr8/MhfYrmmr3Xh5MRa6yAYMuxqOTwdmDxvrplkrLo6sWGj5Rcmj01rQ6a2on 8fiB2N1xQvOsOc/eaTptyB/kYmNbhWi6+ARuA6768lTSFLnUIcBjSOYQtXjuUcTqLXxH k4L8f+jSzX4PP2EYslhGUjFx9IecoDI4Ay59pYSFFIwLmdrcYrYHPAl0S3zqjSe/nWbc 5BmFfLgQEyhsLwrwca2LYz8EaDzKaAmmrp8IPch+57N0f+k8GtsiVsKfmhFSSgsbMtHK DXxG+j4gduqsUKO/I8ARBW9Ly+wO3mG3Lkj66SAY17aklypxaJLKILmIRhD51x2mOXad B+7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f2LXSAjz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s34si3136532pjc.2.2019.06.11.11.59.42; Tue, 11 Jun 2019 11:59:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f2LXSAjz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406991AbfFKS7l (ORCPT + 30 others); Tue, 11 Jun 2019 14:59:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:36434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392180AbfFKS7l (ORCPT ); Tue, 11 Jun 2019 14:59:41 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.35.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A2FA821852; Tue, 11 Jun 2019 18:59:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560279580; bh=2xQ+rYH0eY0Das/QD86dhs/72bS8PeZ5h8R2EDanUFw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f2LXSAjzgExKcSFhmqEdMLuhR/ne/MFPTcv/ARggPKvujED4ghqH4VCqAExzn0TGJ aaFqjMGGcTsn8Y5PbutdSetRnxi0QAKSX9vnuC0DsKPW/9uVMR+bVNmg8xxVounM2P 9y7Y19y1676NLCjmUPOW6FlmOXeGD+d1h/9EPX1Q= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Leo Yan , Alexander Shishkin , Jiri Olsa , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: [PATCH 05/85] perf symbols: Remove unused variable 'err' Date: Tue, 11 Jun 2019 15:57:51 -0300 Message-Id: <20190611185911.11645-6-acme@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190611185911.11645-1-acme@kernel.org> References: <20190611185911.11645-1-acme@kernel.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leo Yan Variable 'err' is defined but never used in function symsrc__init(), remove it and directly return -1 at the end of the function. Signed-off-by: Leo Yan Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20190530093801.20510-1-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/symbol-elf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.20.1 diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 4ad106a5f2c0..fdc5bd7dbb90 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -699,7 +699,6 @@ bool __weak elf__needs_adjust_symbols(GElf_Ehdr ehdr) int symsrc__init(struct symsrc *ss, struct dso *dso, const char *name, enum dso_binary_type type) { - int err = -1; GElf_Ehdr ehdr; Elf *elf; int fd; @@ -793,7 +792,7 @@ int symsrc__init(struct symsrc *ss, struct dso *dso, const char *name, elf_end(elf); out_close: close(fd); - return err; + return -1; } /**