From patchwork Sat Jun 22 16:07:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 167482 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp2095100ilk; Sat, 22 Jun 2019 09:07:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnM65OcXB7IhHEPXbIoNIrIhtryXbD3LjZK2d4XL4Wvugkwe9PHZDy/jFe32xI5KbP7iPP X-Received: by 2002:a63:81c2:: with SMTP id t185mr6099663pgd.448.1561219640564; Sat, 22 Jun 2019 09:07:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561219640; cv=none; d=google.com; s=arc-20160816; b=ANNjpPS+PXLn5kXKsLrOKOoZvqGSynHILwud/LlEomY51jSHeS58nCUiRruY0i+5+J 5OD6znlb7zrKG/wTlpPSHLQ1FtJTLZS9AsptSZ94DyKV9f/A+Toc4r3LvS88Yf3T/5K0 L/r/4h+2yakj0gRZKneaXIXM9tkBsZ9p2vEOYXqJ+4f+H4IV6Sy6vXWMPFAIMq/5/TUv NenrnDtEhQt6tlURI+cBrJ6F1KGkgP5YFPrnUUk+2ZP6c9Ds3F4ZHK4tM+Gup7SD0B/G 3iPeYYLXZdfl0/aGKp3qotJHBfbX0+A26H6ido/WV5VKUbvl8htCOamk/wqH/bPo0av0 kXrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=BrWzygOirnh6Vzzhfu7Gd4Vu22siU0gsu4JudlFjotY=; b=nOhGVCBehO7jtewqfAs9s36bXReqg85xHwI/OOzoA2mSp4Hlk8XRkY9a7fHFzQZwZ+ 09JNnc9gv9rQkS6ouHwvxJxxTIdQazpkCOlO4CbmwU70nMcd+8sYCVUQE4T1YDe/NRot ONdxkEWcugkA+8M9tDKceGLVV+n9XG8E8PlYKaGbQEyE+FG9QSjDdjAJ3yYY1pBUYL5z OH6wJm97jghU/ODGLRp77ydRqLFlh3qZTIc6aNSfCup7YlrTqMNwpOMghL46g1hHo6z5 hAZx5UmVyorPTc8Q0lMIIx2JLPk9imT6uIY/z6fPFvYU6s97FOAanOLQOesSWNNwTez3 i8yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="hEIwm/pt"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si5130575plp.361.2019.06.22.09.07.20; Sat, 22 Jun 2019 09:07:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="hEIwm/pt"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726351AbfFVQHN (ORCPT + 30 others); Sat, 22 Jun 2019 12:07:13 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:55073 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbfFVQHM (ORCPT ); Sat, 22 Jun 2019 12:07:12 -0400 Received: from grover.flets-west.jp (softbank126125154139.bbtec.net [126.125.154.139]) (authenticated) by conuserg-11.nifty.com with ESMTP id x5MG77ne010140; Sun, 23 Jun 2019 01:07:07 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com x5MG77ne010140 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1561219628; bh=BrWzygOirnh6Vzzhfu7Gd4Vu22siU0gsu4JudlFjotY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hEIwm/ptIqDFlBaDqP+pAnTTU3InHllPUGjYX0fcKWpWJiukEomYRDuJfYBgfxTAm 0DB/EuFTzo8CNeIKrKhaQ7ImdNWgWAC2qZUarboZQzgQ5pIzbf7jfJ4hmNARqHoipu quqv7AIPranMc7rcvif5v0hRULFR2soPafgK19FPR5gtR3cFc+gT5CySegkVb1oR9v APp3JMA9k6KloCtdyciaikmEV+LKkNnAlXBjeQN5VMpzSlEp8UdFTUx3/kIi1/sF8v Zv7siSAGTewl+FcTWBrdw4x6aI/adXmmkKqKN+jGayJdqfgRejaCHvUqeWgq7sl967 3gvIdyofqYWLw== X-Nifty-SrcIP: [126.125.154.139] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] kbuild: save $(strip ...) for calling any-prepreq Date: Sun, 23 Jun 2019 01:07:04 +0900 Message-Id: <20190622160705.17071-2-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190622160705.17071-1-yamada.masahiro@socionext.com> References: <20190622160705.17071-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The string returned by $(filter-out ...) does not contain any leading or trailing spaces. So, only the space that matters is the one between $(filter-out $(PHONY),$?) and $(filter-out $(PHONY) $(wildcard $^),$^) By removing it from the code, we can save $(strip ...) evaluation. This refactoring is possible because $(any-prereq) is only passed to the first argument of $(if ...), so we are only interested in whether it is empty or not. This is also the prerequisite for the next commit. Signed-off-by: Masahiro Yamada --- scripts/Kbuild.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index 4bec04c89750..0fa93f6de0b0 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -231,7 +231,7 @@ make-cmd = $(call escsq,$(subst $(pound),$$(pound),$(subst $$,$$$$,$(cmd_$(1)))) # Find any prerequisites that is newer than target or that does not exist. # PHONY targets skipped in both cases. -any-prereq = $(filter-out $(PHONY),$?) $(filter-out $(PHONY) $(wildcard $^),$^) +any-prereq = $(filter-out $(PHONY),$?)$(filter-out $(PHONY) $(wildcard $^),$^) # Execute command if command has changed or prerequisite(s) are updated. if_changed = $(if $(strip $(any-prereq) $(cmd-check)), \ @@ -274,7 +274,7 @@ ifeq ($(KBUILD_VERBOSE),2) why = \ $(if $(filter $@, $(PHONY)),- due to target is PHONY, \ $(if $(wildcard $@), \ - $(if $(strip $(any-prereq)),- due to: $(any-prereq), \ + $(if $(any-prereq),- due to: $(any-prereq), \ $(if $(cmd-check), \ $(if $(cmd_$@),- due to command line change, \ $(if $(filter $@, $(targets)), \