From patchwork Sat Jun 22 20:44:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 167513 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp2303167ilk; Sat, 22 Jun 2019 13:44:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqwxHaTCcEmuNJPR6CtiuCJvY+MYZp7bHgW170vMIPv/GXUzZbB3WzEVzIebwQoemVv560Id X-Received: by 2002:a63:2b47:: with SMTP id r68mr6720520pgr.352.1561236279906; Sat, 22 Jun 2019 13:44:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561236279; cv=none; d=google.com; s=arc-20160816; b=mDNDhKC1HefiZA2lf9ceVV+M7h4APCN6/kdyRtUtQDADjw2mp70mFd9onQ2qrAJrEI Qeuhn1MURPZWe2Aip1uZOy8xp3BKC/3j3WinAzZXyEo6N82xUyFNxQ+Y/IQdjc3NOUf/ FMac5c8xcAteSnX22Q1Jg9CdYpPoAy/fY60+SYNkokQEqcrphn5yLFzMYTQZFjWvGP02 4EmduGq6653WLWpEDa+Dif3jEgIWiwmU1LBb1uUxRSrdMNQ3ahBpS5Ll2BfArt/DfrE3 098WoQK830TUiVwQ2hx3tkkMUSM3KMhEAaziSgeJPlovWNANOFaK90nD9qE8GSSqS/5d vELw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9BG/7LnezII5mNtWEJv2o6z3Cg8xQRRiq9PY3GLO+LY=; b=Mv04jnM8+Rak1ZTFbgW8AZX/lQelBVFhtL1850uxSd8XDyArlXhezrWbVWgf8JGy5e LgyUiVKTzMjk7L40f54QDsKTZMd+MpWvyeUiY76mij0JRbUqzlWRaB26Z8m8t4ptM7Al 1LRGCzil3V7IsNLLbGOcCsMwB2RiyABYV3sRB9U/rOyxZXtECual4agF7qJUYp9g3HTP sVsdBm8oNqMb/YjVgJ3xD5RQwnHT59TCaiSClHkWP5ghXb2Jo/CTZa6RPiOvXhVGVsLT AdggbQcpgiwlEBwWSA2B4QK9YLR5lZSILcGXLYw0h3mJX/ijQcNBhXrANZLMnjDtwGsY Cz7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="CI5JLR/U"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d126si5681348pgc.46.2019.06.22.13.44.39; Sat, 22 Jun 2019 13:44:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="CI5JLR/U"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726397AbfFVUoh (ORCPT + 30 others); Sat, 22 Jun 2019 16:44:37 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38100 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726290AbfFVUog (ORCPT ); Sat, 22 Jun 2019 16:44:36 -0400 Received: by mail-wr1-f67.google.com with SMTP id d18so9818711wrs.5 for ; Sat, 22 Jun 2019 13:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9BG/7LnezII5mNtWEJv2o6z3Cg8xQRRiq9PY3GLO+LY=; b=CI5JLR/U6y44Ygrj+VvZ6E7p8O/SjHLTnzrOpgZkUVOfGLu7iqMa3du7L665qIt44n AMIAqVtuS+WUa862wI6sxSjBKryRs+o2ftKwk6f1H2Of2pZN/Chq1Nfrhw02jrwo9tKe rPD909rf+14Y+b7VZnSsMYEoutEKsX+QBYMmaFoxGWThYPmkt26uDpwpCIjriC7tiygQ vgeiuAYu8tdbyuDjygMrvysA2/mKFW0ivpxpqtJwk6ZmbvBxJnttLtpjkuNiU2WXUjZ0 41j+bkHwu5sZtUfWbRdTg+T0XF8H2NH83kLcdxIsgI3JKhJ0mxwtJ/AWf731hY1l6TMP e1CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9BG/7LnezII5mNtWEJv2o6z3Cg8xQRRiq9PY3GLO+LY=; b=Roncwx7TxNM7XU/URGXVhbEAY+8BlCzVjS+Jreos/DVKqRGifYyW/yfrKBRjy09+0G ACkMujbuV71gRYwwIXdsfF3LFaZk5BVnaxYns7JtrcL7XNEAXmCuVkoua7vzF9Yx3O/B 5mkJJjeX9TOSOPiwxTleq94KSxMBeMcRdJgCU4fdY1Qpl/FoUZjQc0VTpIx0Mjvr6IaA 9yYscaK3TW1uzDwl5eqTZLb+W3DDMCla6c71ytC806W4yhiZsWSSEdSJYUnFsFaC5L2t p2QF61ptSItdg3Y+zDnrM8o1eQdVJlMr+jr7/x6DjFG/3fXfq+zPUTz5LP7g7QmWJix8 covA== X-Gm-Message-State: APjAAAWcIqXMxzPRoRoNb/6/Rr+momf4aDkmayc6p2Nv4T3+j9Bl0mKF RHqrh28vnWk379a84sO4JNN/Ew== X-Received: by 2002:a05:6000:114b:: with SMTP id d11mr34771323wrx.167.1561236274447; Sat, 22 Jun 2019 13:44:34 -0700 (PDT) Received: from localhost.localdomain (88-147-39-13.dyn.eolo.it. [88.147.39.13]) by smtp.gmail.com with ESMTPSA id o20sm6779064wro.65.2019.06.22.13.44.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Jun 2019 13:44:33 -0700 (PDT) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, Paolo Valente Subject: [PATCH BUGFIX V2] block, bfq: fix operator in BFQQ_TOTALLY_SEEKY Date: Sat, 22 Jun 2019 22:44:16 +0200 Message-Id: <20190622204416.33871-1-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org By mistake, there is a '&' instead of a '==' in the definition of the macro BFQQ_TOTALLY_SEEKY. This commit replaces the wrong operator with the correct one. Fixes: commit 7074f076ff15 ("block, bfq: do not tag totally seeky queues as soft rt") Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index f8d430f88d25..f9269ae6da9c 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -240,7 +240,7 @@ static struct kmem_cache *bfq_pool; * containing only random (seeky) I/O are prevented from being tagged * as soft real-time. */ -#define BFQQ_TOTALLY_SEEKY(bfqq) (bfqq->seek_history & -1) +#define BFQQ_TOTALLY_SEEKY(bfqq) (bfqq->seek_history == -1) /* Min number of samples required to perform peak-rate update */ #define BFQ_RATE_MIN_SAMPLES 32