From patchwork Mon Jul 1 00:58:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 168193 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp2263762ilk; Sun, 30 Jun 2019 18:00:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHA66cREFLoJE6irm2bX74u9l2NChNU7vK/B7RQDv8N8PQg/r7jGiDZliFEGQBNkhx87JD X-Received: by 2002:a63:ab08:: with SMTP id p8mr4103202pgf.340.1561942833218; Sun, 30 Jun 2019 18:00:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561942833; cv=none; d=google.com; s=arc-20160816; b=o4cx466SZXdtPvl9h82ldSp9juy3+plDO2zOO0jFw6qOagpKAjc1xSpKg4drsWAu59 Q/h8xQ8GOk93wkoSTQfZij5J8ozoENkkEqUtKDlrPQA69cm6J7WlqOs2VZTK8Bmj3fs6 ugpaid2p+dsyrWf76u4uqyeOSHLHfEtaGdAt95pWxg/0PVqm2mcqg4/2WXTvBt0ILIm4 pAIZ5puMngTXYhU7kSDSiBQ0rigy1yi+GYPR6agWemh+PujwjZFJVdd9mIizD9Gf/+N6 GF7NXNbaHBjQaat6XiuuzC43bM0qiZB+67yFT3Tjr992TsxU4jS9yTVC4fCTNpn6LcHX hfiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=rM1OWC0NYjNzccPK//0F4tGu6ozRHQZMCkGhKTcJdWI=; b=hcY4xJjIekg30wPmvDeSUQER0630vIVWrbSlP/qlE5tY3uCQfNAw9Vaf7XkYKcZkyj 55xfY+XcQzJe0UnxZwrjzkBXQEOFeJa2oJetCOOsXXhf/VUH7k+jry4rD3CcWMCYQzdR fR5ojJ2p+ED/BgeghrqL5VlzJE/n2lBaUcC61ied2DBdPSZIv5UM8AV99JN33BoUMt7p diclBARJIxer5Bnn3D/RMIeTPQ348xbBcwKBjWku2jeQDOZm7SZhMIsV4/VIeHcw9XhR vtNlp2it6OsnAONnu56ZntQMmXb2hIL+qBXHbYi1Z6ReMBJjphI++opkoenbhb5/6SBz g2gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=oXq9dvO3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t2si8479736ply.133.2019.06.30.18.00.32; Sun, 30 Jun 2019 18:00:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=oXq9dvO3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727036AbfGABAZ (ORCPT + 30 others); Sun, 30 Jun 2019 21:00:25 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:60232 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbfGABAX (ORCPT ); Sun, 30 Jun 2019 21:00:23 -0400 Received: from grover.flets-west.jp (softbank126125154139.bbtec.net [126.125.154.139]) (authenticated) by conuserg-12.nifty.com with ESMTP id x610x4fu000634; Mon, 1 Jul 2019 09:59:09 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com x610x4fu000634 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1561942749; bh=rM1OWC0NYjNzccPK//0F4tGu6ozRHQZMCkGhKTcJdWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oXq9dvO3uZ/pRTSUNd0h3q4yicM3BbqFnLQVqEjcb7HmyXctmNJ2nn+yl2Ty+1Uov ImA9EKvIFO/neA8oRXsMtqtXZC1PC1cmt5YhrSxQUQOKcFO+dHjLvl5Iuq3x4TWPX1 YRYVx4D/vyv9kmWHdIXq3xhJZ3daUIuCfShIftHuqVbeciPIfGqBow1mxLO6k39jLg LB92YfjcbrmQ0HUTCtKm/IRC6SoOE5OsiL9wgm9QfoRTzMGzbp7Cxte6u0yK23M0JD IXJohMaxWWrs2IPIk+LyFQfcdeQHGiaFWbXjMv5RrCBrjy8D3QrXwshn3xFKsY9m8I JCa5bGO45B+RQ== X-Nifty-SrcIP: [126.125.154.139] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Sam Ravnborg , Joel Fernandes , Masahiro Yamada , linux-doc@vger.kernel.org, Jonathan Corbet , linux-kernel@vger.kernel.org, Michal Marek Subject: [PATCH 3/7] kbuild: do not create wrappers for header-test-y Date: Mon, 1 Jul 2019 09:58:41 +0900 Message-Id: <20190701005845.12475-4-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190701005845.12475-1-yamada.masahiro@socionext.com> References: <20190701005845.12475-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org header-test-y does not work with headers in sub-directories. For example, you may want to write a Makefile, like this: include/linux/Kbuild: header-test-y += mtd/nand.h This entry will create a wrapper include/linux/mtd/nand.hdrtest.c with the following content: #include "mtd/nand.h" To make this work, we need to add $(srctree)/include/linux to the header search path. It would be tedious to add ccflags-y. Instead, we could change the *.hdrtest.c rule to wrap: #include "nand.h" This works for in-tree build since #include "..." searches in the relative path from the header with this directive. For O=... build, we need to add $(srctree)/include/linux/mtd to the header search path, which will be even more tedious. After all, I thought it would be handier to compile headers directly without creating wrappers. I added a new build rule to compile %.h into %.h.s The target is %.h.s instead of %.h.o because it is slightly faster. Also, as for GCC, an empty assembly is smaller than an empty object. I wrote the build rule: $(CC) $(c_flags) -S -o $@ -x c /dev/null -include $< instead of: $(CC) $(c_flags) -S -o $@ -x c $< Both work fine with GCC, but the latter is bad for Clang. This comes down to the difference in the -Wunused-function policy. GCC does not warn about unused 'static inline' functions at all. Clang does not warn about the ones in included headers, but does about the ones in the source. So, we should handle headers as headers, not as source files. In fact, this has been hidden since commit abb2ea7dfd82 ("compiler, clang: suppress warning for unused static inline functions"), but we should not rely on that. Signed-off-by: Masahiro Yamada Acked-by: Jani Nikula Tested-by: Jani Nikula --- Changes in v4: None Changes in v3: None Changes in v2: - New patch .gitignore | 1 - Documentation/dontdiff | 1 - Documentation/kbuild/makefiles.txt | 3 +-- Makefile | 1 - scripts/Makefile.build | 10 +++++----- scripts/Makefile.lib | 2 +- 6 files changed, 7 insertions(+), 11 deletions(-) -- 2.17.1 diff --git a/.gitignore b/.gitignore index 4bb60f0fa23b..7587ef56b92d 100644 --- a/.gitignore +++ b/.gitignore @@ -22,7 +22,6 @@ *.elf *.gcno *.gz -*.hdrtest.c *.i *.ko *.lex.c diff --git a/Documentation/dontdiff b/Documentation/dontdiff index 554dfe4883d2..5eba889ea84d 100644 --- a/Documentation/dontdiff +++ b/Documentation/dontdiff @@ -19,7 +19,6 @@ *.grep *.grp *.gz -*.hdrtest.c *.html *.i *.jpeg diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt index ca4b24ec0399..5080fec34609 100644 --- a/Documentation/kbuild/makefiles.txt +++ b/Documentation/kbuild/makefiles.txt @@ -1023,8 +1023,7 @@ When kbuild executes, the following steps are followed (roughly): header-test-y specifies headers (*.h) in the current directory that should be compile tested to ensure they are self-contained, i.e. compilable as standalone units. If CONFIG_HEADER_TEST is enabled, - this autogenerates dummy sources to include the headers, and builds them - as part of extra-y. + this builds them as part of extra-y. --- 6.7 Commands useful for building a boot image diff --git a/Makefile b/Makefile index f23516980796..7f293b0431fe 100644 --- a/Makefile +++ b/Makefile @@ -1648,7 +1648,6 @@ clean: $(clean-dirs) -o -name '*.dwo' -o -name '*.lst' \ -o -name '*.su' \ -o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \ - -o -name '*.hdrtest.c' \ -o -name '*.lex.c' -o -name '*.tab.[ch]' \ -o -name '*.asn1.[ch]' \ -o -name '*.symtypes' -o -name 'modules.order' \ diff --git a/scripts/Makefile.build b/scripts/Makefile.build index ee0319560513..776842b7e6a3 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -294,14 +294,14 @@ quiet_cmd_cc_lst_c = MKLST $@ $(obj)/%.lst: $(src)/%.c FORCE $(call if_changed_dep,cc_lst_c) -# Dummy C sources for header test (header-test-y target) +# header test (header-test-y target) # --------------------------------------------------------------------------- -quiet_cmd_header_test = HDRTEST $@ - cmd_header_test = echo "\#include \"$*.h\"" > $@ +quiet_cmd_cc_s_h = CC $@ + cmd_cc_s_h = $(CC) $(c_flags) -S -o $@ -x c /dev/null -include $< -$(obj)/%.hdrtest.c: - $(call cmd,header_test) +$(obj)/%.h.s: $(src)/%.h FORCE + $(call if_changed_dep,cc_s_h) # Compile assembler sources (.S) # --------------------------------------------------------------------------- diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 3e630fcaffd1..55ae1ec65342 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -67,7 +67,7 @@ extra-$(CONFIG_OF_ALL_DTBS) += $(patsubst %.dtb,%.dt.yaml, $(dtb-)) endif # Test self-contained headers -extra-$(CONFIG_HEADER_TEST) += $(patsubst %.h,%.hdrtest.o,$(header-test-y)) +extra-$(CONFIG_HEADER_TEST) += $(addsuffix .s, $(header-test-y)) # Add subdir path