From patchwork Mon Jul 8 15:13:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 168663 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp7301801ilk; Mon, 8 Jul 2019 08:22:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxO7BoOAQCk0/ZXU1VCpWR379KH59UJnsOUiAfjQm5nKmHJySuxAAlv710geBZiGdBiDhlm X-Received: by 2002:a17:90a:220a:: with SMTP id c10mr19096051pje.33.1562599344173; Mon, 08 Jul 2019 08:22:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562599344; cv=none; d=google.com; s=arc-20160816; b=wfPheXCYl8rOteRt9zB+gNq/XaxfLol8jWhk02ZIU6Eh42A/8RkCSA6iy3x1BN+DJo 8kaKVQCoxyjuCPksRnTZfY2yJTw6vN05MVd7/4rxaKEsuMx4Dnx8JlZC3AGRS/hj2Evu ODGECOhCZ+oWgdJdjHyfcY/2r70Aa/31J1B1gzglNiGLPF2JZP36uJDYYt5leC0JOSxp Kzg7I3hxi3FXHfmgPhRI9hXGm5lU2fYlcw+TzZFhQJqOpQPsAtpG6A5U35XdcN9cnDQh ff/XPlj6f+LCptKKGFmuNiYTZ2n0IhX4MY1iAzojGmDUTG7p3aJfyUEngXS500fanOBO NA+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=yBkppgtYzuDSnIOxfa+M6BnO5lSJzFMlwXTl0J+GQrs=; b=jJPzmmxx5MynEv53RXIn3s8WgDQiRIxQpOrkwocRtIRDufvh8U9XVY0tfX8QS2X/tN 9BMfdANidP0mIs9FYIbl9CrQ9FB/TzD7SJSaozCcRbUcfu4qRuhDjIMagZ2k9sXV62ly TYCy9LHU3rw9bfO0QlA8HYlTtXv/hlzlL1nnjnmws3TNQcYlBe8OqRaGKSti2VNy0zMZ 2HdC9Z4VkLCsfosI1tlySMP41r1rezYF/9ElnVETqyA73IZWC3eKhA3vj++5mCwxxyZ0 qqWxrrb1r6z0T2ATF4Vj5dfs1Q1dtycNrCfMtlFAcZlVMXtKoIOt9yYTGm2EClqHoErt PCxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=n3ZDQ0NF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y15si18587348pjp.90.2019.07.08.08.22.23; Mon, 08 Jul 2019 08:22:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=n3ZDQ0NF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387941AbfGHPWW (ORCPT + 30 others); Mon, 8 Jul 2019 11:22:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:48684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387541AbfGHPWT (ORCPT ); Mon, 8 Jul 2019 11:22:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97547216C4; Mon, 8 Jul 2019 15:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562599338; bh=Nf2YQlA6/8uRbuf11XOZ+HRCsHe6fw5Z0BmejLtcxfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n3ZDQ0NF/RwvVw/wCPuINkm5H/wmyV+/SQBJMZSOFVJ7y4QE9oUyu4uXBrVO9LzGL Z4OUzVp96MkwdiwgogDineyjpuSriUiZZ7p11sEpwd27bmEGalDpy8MFzboX0usWjz RsOTtgtd7R62OR1SUfAZKoxW+0oTFtggehtXuISc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Maxime Ripard , Stephen Boyd Subject: [PATCH 4.9 082/102] clk: sunxi: fix uninitialized access Date: Mon, 8 Jul 2019 17:13:15 +0200 Message-Id: <20190708150530.716651984@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190708150525.973820964@linuxfoundation.org> References: <20190708150525.973820964@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann commit 4e903450bcb9a6bc90733b981d7cb8b3c4996a0e upstream. gcc-8 reports an uninitialized variable access in a code path that we would see with incorrect DTB input: drivers/clk/sunxi/clk-sun8i-bus-gates.c: In function 'sun8i_h3_bus_gates_init': drivers/clk/sunxi/clk-sun8i-bus-gates.c:85:27: error: 'clk_parent' may be used uninitialized in this function [-Werror=maybe-uninitialized] This works around by skipping invalid input and printing a warning instead if it ever happens. The problem was apparently part of the initiali driver submission, but older compilers don't notice it. Fixes: ab6e23a4e388 ("clk: sunxi: Add H3 clocks support") Signed-off-by: Arnd Bergmann Acked-by: Maxime Ripard Signed-off-by: Stephen Boyd Signed-off-by: Greg Kroah-Hartman --- drivers/clk/sunxi/clk-sun8i-bus-gates.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/clk/sunxi/clk-sun8i-bus-gates.c +++ b/drivers/clk/sunxi/clk-sun8i-bus-gates.c @@ -78,6 +78,10 @@ static void __init sun8i_h3_bus_gates_in clk_parent = APB1; else if (index >= 96 && index <= 127) clk_parent = APB2; + else { + WARN_ON(true); + continue; + } clk_reg = reg + 4 * (index / 32); clk_bit = index % 32;