From patchwork Mon Jul 8 15:47:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 168682 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp7331515ilk; Mon, 8 Jul 2019 08:48:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+rSrNrPAWvLod2D414ymwu4nkL9NcTbpBFmbr9Cncl1jNbOJnfEErjSEMgPkFiALEGC4U X-Received: by 2002:a63:1046:: with SMTP id 6mr25546746pgq.111.1562600891873; Mon, 08 Jul 2019 08:48:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562600891; cv=none; d=google.com; s=arc-20160816; b=hZHIoKtjAE1obOgIcVi8tNLi1CzDtqMEjp+pRW7GxcNVQ5xkLDYloMgFtAotPh9wX2 r1ErO0IHsvp1IjMDvx5rL0xiRiboej6v8lpazHOjCD4dq4l+f0qVVvxq5CZ0XjleBlP8 Hd1stBx7DzTOSX4TFEPszEqyXPYoHeh+UTipBc2a0fmCURWRelAYkyYb1QbY7SMF63Tr lUj3p4NC04u1rXI8B1IdFA3ytpTjYJ3L+5WT9JNTcDzWUmy4JP9NrCldKrKJ2eyQ/p73 Caq0GuC5Zb0L9zsqcc0ukgSBRnP9Y1ucQDm9tud3/hkTL2ThkhQhS0w6PVzm0wjDhrPr uPCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=A14YQaT5MvNTyqXk+fqrk3dMHZRdkvpc6074AquUoyQ=; b=KHMnr0rvSqVabzS5UqrjKG8wt7lOE4L9FdK90RePmIf+0E4q3i0vspt//jtll8tnTW SKQEM2b8I3MS1DedsTtTp91WzGxBXmvu+4lR1BBR4Srr0kTBsnFyY24cX/sy9VVY0G/b /kou8d2heEe5WyTyEF10l+shWppPkHX74cjjgrOaixU5DiqWtt0mGdac6dAxLFjpFmG7 LKjPUydGYkuKr0qpgi4ztEXrCkGEPG8CXuzyIyNlcLQfZLOhan1tLnH4B2SCPhbLxbfg DM1hzk73SI5erZmf0JiBqvbFlrmw97tDYxyfuETLdaCvnJ/TdZYRxg1l9xfoPbbRb4wJ qoAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s7si13060799plr.95.2019.07.08.08.48.11; Mon, 08 Jul 2019 08:48:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388299AbfGHPsK (ORCPT + 30 others); Mon, 8 Jul 2019 11:48:10 -0400 Received: from foss.arm.com ([217.140.110.172]:52412 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391308AbfGHPrx (ORCPT ); Mon, 8 Jul 2019 11:47:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 941A7152B; Mon, 8 Jul 2019 08:47:52 -0700 (PDT) Received: from usa.arm.com (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8FD363F59C; Mon, 8 Jul 2019 08:47:51 -0700 (PDT) From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla , linux-kernel@vger.kernel.org, Peng Fan , Jim Quinlan , Bo Zhang , Volodymyr Babchuk Subject: [PATCH 09/11] firmware: arm_scmi: Add asynchronous sensor read if it supports Date: Mon, 8 Jul 2019 16:47:28 +0100 Message-Id: <20190708154730.16643-10-sudeep.holla@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190708154730.16643-1-sudeep.holla@arm.com> References: <20190708154730.16643-1-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SENSOR_DESCRIPTION_GET provides attributes to indicate if the sensor supports asynchronous read. We can read that flag and use asynchronous reads for any sensors with that attribute set. Let's use the new scmi_do_xfer_with_response to support asynchronous sensor reads. Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/sensors.c | 30 +++++++++++++++++++++-------- include/linux/scmi_protocol.h | 2 ++ 2 files changed, 24 insertions(+), 8 deletions(-) -- 2.17.1 diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c index 1b5757c77a35..b8f226a365de 100644 --- a/drivers/firmware/arm_scmi/sensors.c +++ b/drivers/firmware/arm_scmi/sensors.c @@ -136,9 +136,10 @@ static int scmi_sensor_description_get(const struct scmi_handle *handle, } for (cnt = 0; cnt < num_returned; cnt++) { - u32 attrh; + u32 attrh, attrl; struct scmi_sensor_info *s; + attrl = le32_to_cpu(buf->desc[cnt].attributes_low); attrh = le32_to_cpu(buf->desc[cnt].attributes_high); s = &si->sensors[desc_index + cnt]; s->id = le32_to_cpu(buf->desc[cnt].id); @@ -147,6 +148,8 @@ static int scmi_sensor_description_get(const struct scmi_handle *handle, /* Sign extend to a full s8 */ if (s->scale & SENSOR_SCALE_SIGN) s->scale |= SENSOR_SCALE_EXTEND; + s->async = SUPPORTS_ASYNC_READ(attrl); + s->num_trip_points = NUM_TRIP_POINTS(attrl); strlcpy(s->name, buf->desc[cnt].name, SCMI_MAX_STR_SIZE); } @@ -214,8 +217,11 @@ static int scmi_sensor_reading_get(const struct scmi_handle *handle, u32 sensor_id, u64 *value) { int ret; + __le32 *pval; struct scmi_xfer *t; struct scmi_msg_sensor_reading_get *sensor; + struct sensors_info *si = handle->sensor_priv; + struct scmi_sensor_info *s = si->sensors + sensor_id; ret = scmi_xfer_get_init(handle, SENSOR_READING_GET, SCMI_PROTOCOL_SENSOR, sizeof(*sensor), @@ -223,16 +229,24 @@ static int scmi_sensor_reading_get(const struct scmi_handle *handle, if (ret) return ret; + pval = t->rx.buf; sensor = t->tx.buf; sensor->id = cpu_to_le32(sensor_id); - sensor->flags = cpu_to_le32(0); - - ret = scmi_do_xfer(handle, t); - if (!ret) { - __le32 *pval = t->rx.buf; - *value = le32_to_cpu(*pval); - *value |= (u64)le32_to_cpu(*(pval + 1)) << 32; + if (s->async) { + sensor->flags = cpu_to_le32(SENSOR_READ_ASYNC); + ret = scmi_do_xfer_with_response(handle, t); + if (!ret) { + *value = le32_to_cpu(*pval + 1); + *value |= (u64)le32_to_cpu(*(pval + 2)) << 32; + } + } else { + sensor->flags = cpu_to_le32(0); + ret = scmi_do_xfer(handle, t); + if (!ret) { + *value = le32_to_cpu(*pval); + *value |= (u64)le32_to_cpu(*(pval + 1)) << 32; + } } scmi_xfer_put(handle, t); diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h index 697e30fb9004..1be16d7730e2 100644 --- a/include/linux/scmi_protocol.h +++ b/include/linux/scmi_protocol.h @@ -145,6 +145,8 @@ struct scmi_sensor_info { u32 id; u8 type; s8 scale; + u8 num_trip_points; + bool async; char name[SCMI_MAX_STR_SIZE]; };