From patchwork Wed Aug 7 05:39:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 170708 Delivered-To: patch@linaro.org Received: by 2002:a92:512:0:0:0:0:0 with SMTP id q18csp6660607ile; Tue, 6 Aug 2019 22:40:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxj57ExwajfNWA3NC8hOQBcju0zx09ZhBPapSt62y+pnl8VPoqUcrPOUogAua+nv8A36R44 X-Received: by 2002:a17:90a:9905:: with SMTP id b5mr6932231pjp.70.1565156405742; Tue, 06 Aug 2019 22:40:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565156405; cv=none; d=google.com; s=arc-20160816; b=k9mBN6x3XfR3X3s2BfmjTsQfnMkWaghYzlgegyEZELSwL60fxXHO0/JssJoN9nWwvF AFapBhDBqTxxM6AuM+w5YidtLKUfCjrhhs/ILGPFlZAqNvqB+DknNKO3AplK3GNs8NAS c9l4i33P8mk2QTW5RKf3oxoZJ704d2bBoOAQcAiGyVIA2Rzcz+HeCL8UVpFvpFwfgeyx CKVYvxAO5k6izJ1WtYGVXda0p0lkJZgfZ8r5FVoCPxoo0YqdFM80IwDGkG8hTC9KJ28Z JMf3YNn+2ApkEAOOyAJSUx0N+OCIgftt/iGUjHaie93hVwIWgz55JNBp9qFPH5ZFVncG bGUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=fsAZ/nMaAQwkSV7ok0DKoJTylqdRDHaUnbG8Kv9af6Y=; b=Unbo0FrBnvwoUYgde7TXy2DSbQJ5WPgKAhI+YIezni6Fbg4dtUU7zQO2gwgb8+gn9n QuRgNrQMfsRvVLwFyPZB9yASXpW5ozg0PPfWvLTbu2p1Sc62YlwGgjMGSJbMukSXlakP cApPeZuCGkSEqNVJvNw5Y5tp1VqYwXVFfKtg7KvuJkdEHMUBpyT6/4DpNJ7YSAiHH3BW dH0s0YMJN3IpJAXpheANmXGIH/YNlb2YdT9VmWtfNcygcu3IuatuMuE+3VjVqhC4FPQG mkehGQwJAEQyIi/l0RQ5pLlfLg6Tyl9KXlRkUZY2OKOXelHPDfJYAz1/onDVTQ6CRRqO KUQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o7CDKF6Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b73si16522077pjc.53.2019.08.06.22.40.05; Tue, 06 Aug 2019 22:40:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o7CDKF6Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727420AbfHGFkE (ORCPT + 28 others); Wed, 7 Aug 2019 01:40:04 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:40085 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727258AbfHGFjz (ORCPT ); Wed, 7 Aug 2019 01:39:55 -0400 Received: by mail-pl1-f195.google.com with SMTP id a93so38877683pla.7 for ; Tue, 06 Aug 2019 22:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fsAZ/nMaAQwkSV7ok0DKoJTylqdRDHaUnbG8Kv9af6Y=; b=o7CDKF6Q9zJTqEn21bYLJqPajiZGXPc5Y9e/zNWTyKu0+rkskbOrSSsGUkphqHIUHC L4OHacF4qz/6w8cQ32lfzrB1nkoknbDFJxBpQiIYgvrd88hm7N8DOaHYJb3Tah3UL39o t83/EM7kkNOm1uCsLc/QzL7k1O0ncR/5mxsy9z5vIslOVkpGjT63wF7ZjwgNvZ4UAjr/ ljBgWOJYrDHfa2DfV7GeuAnipqrKg99clqucGsPDtJ0t79TgUtVilCHfVXmeE6bTTU/a 2UjvkV3Pjiy5/OfMi72US0LbfusZ5Hd2hdKpVi+UsbQWJZMhxWKYWLonDywV2YhG8l5o N8pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fsAZ/nMaAQwkSV7ok0DKoJTylqdRDHaUnbG8Kv9af6Y=; b=m9xNHMBPNX0natIGWpVk+TduOO7/3WImhaI3BJGgCO0T3UpLX7ZjWh/NxbvWXOTX6H lwfGrH9fbURXEG+gnDsbd/T1GAkPHPfrwCorrTq0MHRzhX6hQvA7+5j/B+RbVn0fdrD3 AUuTWlsdKf3br45X63uIqhQh7rB806rOZ0+GNPjQFEQTHpS8UKIeASc6NSQiilzgQNCy ra//ydUWXSAUkYnmJwU5N8Kb1SERiYUkqdxgkivouBd82DoK+6hm8YtfbcCaKdMK9Biz oiFPDIvMnTJxw2ZC4V3BinsTCFcHfqKfHmLLzVeM14UIJvLAMFPCgNBllyescEPAXBlF /pxA== X-Gm-Message-State: APjAAAVNxBle166ohS2nK38BiyNC30KNeArFJV0arDmxHFon7yE8fXL4 x4xKyCfheRJEVU1gpsTNRJSZfg== X-Received: by 2002:a62:198d:: with SMTP id 135mr7484409pfz.169.1565156395121; Tue, 06 Aug 2019 22:39:55 -0700 (PDT) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id u7sm86070777pfm.96.2019.08.06.22.39.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Aug 2019 22:39:54 -0700 (PDT) From: Bjorn Andersson To: Ohad Ben-Cohen , Bjorn Andersson Cc: Andy Gross , Sibi Sankar , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: [PATCH 8/9] remoteproc: qcom: q6v5: Add common panic handler Date: Tue, 6 Aug 2019 22:39:41 -0700 Message-Id: <20190807053942.9836-9-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20190807053942.9836-1-bjorn.andersson@linaro.org> References: <20190807053942.9836-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a common panic handler that invokes a stop request and sleep enough to let the remoteproc flush it's caches etc in order to aid post mortem debugging. Signed-off-by: Bjorn Andersson --- drivers/remoteproc/qcom_q6v5.c | 19 +++++++++++++++++++ drivers/remoteproc/qcom_q6v5.h | 1 + 2 files changed, 20 insertions(+) -- 2.18.0 diff --git a/drivers/remoteproc/qcom_q6v5.c b/drivers/remoteproc/qcom_q6v5.c index 0d33e3079f0d..0aebae893362 100644 --- a/drivers/remoteproc/qcom_q6v5.c +++ b/drivers/remoteproc/qcom_q6v5.c @@ -6,6 +6,7 @@ * Copyright (C) 2014 Sony Mobile Communications AB * Copyright (c) 2012-2013, The Linux Foundation. All rights reserved. */ +#include #include #include #include @@ -15,6 +16,8 @@ #include #include "qcom_q6v5.h" +#define Q6V5_PANIC_DELAY_MS 200 + /** * qcom_q6v5_prepare() - reinitialize the qcom_q6v5 context before start * @q6v5: reference to qcom_q6v5 context to be reinitialized @@ -162,6 +165,22 @@ int qcom_q6v5_request_stop(struct qcom_q6v5 *q6v5) } EXPORT_SYMBOL_GPL(qcom_q6v5_request_stop); +/** + * qcom_q6v5_panic() - panic handler to invoke a stop on the remote + * @q6v5: reference to qcom_q6v5 context + * + * Set the stop bit and sleep in order to allow the remote processor to flush + * its caches etc for post mortem debugging. + */ +void qcom_q6v5_panic(struct qcom_q6v5 *q6v5) +{ + qcom_smem_state_update_bits(q6v5->state, + BIT(q6v5->stop_bit), BIT(q6v5->stop_bit)); + + mdelay(Q6V5_PANIC_DELAY_MS); +} +EXPORT_SYMBOL_GPL(qcom_q6v5_panic); + /** * qcom_q6v5_init() - initializer of the q6v5 common struct * @q6v5: handle to be initialized diff --git a/drivers/remoteproc/qcom_q6v5.h b/drivers/remoteproc/qcom_q6v5.h index 7ac92c1e0f49..c37e6fd063e4 100644 --- a/drivers/remoteproc/qcom_q6v5.h +++ b/drivers/remoteproc/qcom_q6v5.h @@ -42,5 +42,6 @@ int qcom_q6v5_prepare(struct qcom_q6v5 *q6v5); int qcom_q6v5_unprepare(struct qcom_q6v5 *q6v5); int qcom_q6v5_request_stop(struct qcom_q6v5 *q6v5); int qcom_q6v5_wait_for_start(struct qcom_q6v5 *q6v5, int timeout); +void qcom_q6v5_panic(struct qcom_q6v5 *q6v5); #endif