From patchwork Sun Oct 6 17:20:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 175295 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp3307273ill; Sun, 6 Oct 2019 10:42:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqz0oEYz2hMCdvTTpTmoFEwNk+tIuOgwmAQJLNn4uoEqx1De0tZco5315uqLUX3jBllK3vl/ X-Received: by 2002:a17:906:1152:: with SMTP id i18mr20753342eja.113.1570383727309; Sun, 06 Oct 2019 10:42:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570383727; cv=none; d=google.com; s=arc-20160816; b=nZzMB/wY8fqBMmeATazuqeE3WGAxwseWhLbRkZZo4WECihphOKj+tjx01Lpn7QXpND +2gSVxG7iO5DArHWV4DmlUWUzzEXiGUB2v8RlovE4wPxH2FR5ki1+kB5cvtyucJIXAtm rpoKJ/DrDqFmOx0qeT5WVCXh6ZLWdnKzS/KaQUhlQW2fub0JguZ/wa010uCOuxaXeQF1 qeZ3LlzmQBirftTaplhYetPS90Bi1kFM/7o+Vf+KhdtIfnR6kl/WFB+dxWl0UYvWmilg asK0ywncJQvkn39hhpDpAXcmRs59yQiX+FFp77LnOyLPUskIy8Kf8K4Bv4OTYytWCEk8 L0Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=B0TT0lrvsXSmkfPiW6IQ7hVHNK5RQU7jUGQEHnIE1bA=; b=uVC56sCwXY6g6RGiqndIYGy/wURr61AUL4Iv+N/k/x0+21uWKNr6jCVt34c6NJiauw NFjGBQzfLZfAV76ANaZ+OruPNJlhXfzpul2IkAoyT0u3C0nUUddg8+R9jvhCNp6Es4tM PelGke0p38DK3ZydqsoOq26mIyXB2ygTeT3Q9Za8McgQHbMtRiZyd/8LZrSOGwDrIMI4 uVf6VY7jFkxqGkLEElE4eSdwSLj79Xmgt5EPn+S61mk9mIzh1Vjoa41rYslcsFXHuNf+ TUP/50nKn0NxrBl3R/vsIcjB6TIlsNsh8FgoQx4o9NoPufgMMlg7jYUvP04y0RzjNfJD c91A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u4cVwoFE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c26si7518233edx.353.2019.10.06.10.42.06; Sun, 06 Oct 2019 10:42:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u4cVwoFE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730906AbfJFRmC (ORCPT + 27 others); Sun, 6 Oct 2019 13:42:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:41704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730882AbfJFRmA (ORCPT ); Sun, 6 Oct 2019 13:42:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 07FFC20700; Sun, 6 Oct 2019 17:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383719; bh=oZ/CdR4pk54TSdx6nW2duEampafCF/90uNe4q3GZa9I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u4cVwoFEe7dqN2L4qq1ne4ePPgRb99YYoW0xOOg/MIbu8ltHB/GYfdyGnbkMPQ9F7 IY5ikJY8thQ+ZqsoYigAL7zPnADtMYUZHkdVDQhN9kyvI/6D44OpUaxyHgLhVvlsox Mujk4oyX9jXKI8r1072LRHUreW5xaJOUYlVZNJ1k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mark Brown , Linus Walleij , Arnd Bergmann , Sasha Levin Subject: [PATCH 5.3 069/166] ARM: dts: dir685: Drop spi-cpol from the display Date: Sun, 6 Oct 2019 19:20:35 +0200 Message-Id: <20191006171219.185398266@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171212.850660298@linuxfoundation.org> References: <20191006171212.850660298@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Walleij [ Upstream commit 2a7326caab479ca257c4b9bd67db42d1d49079bf ] The D-Link DIR-685 had its clock polarity set as active low using the special SPI "spi-cpol" property. This is not correct: the datasheet clearly states: "Fix SCL to GND level when not in use" which is indicative that this line is active high. After a recent fix making the GPIO-based SPI driver force the clock line de-asserted at the beginning of each SPI transaction this reared its ugly head: now de-asserted was taken to mean the line should be driven high, but it should be driven low. Fix this up in the DTS file and the display works again. Link: https://lore.kernel.org/r/20190915135444.11066-1-linus.walleij@linaro.org Cc: Mark Brown Fixes: 2922d1cc1696 ("spi: gpio: Add SPI_MASTER_GPIO_SS flag") Signed-off-by: Linus Walleij Signed-off-by: Arnd Bergmann Signed-off-by: Sasha Levin --- arch/arm/boot/dts/gemini-dlink-dir-685.dts | 1 - 1 file changed, 1 deletion(-) -- 2.20.1 diff --git a/arch/arm/boot/dts/gemini-dlink-dir-685.dts b/arch/arm/boot/dts/gemini-dlink-dir-685.dts index bfaa2de63a100..e2030ba16512f 100644 --- a/arch/arm/boot/dts/gemini-dlink-dir-685.dts +++ b/arch/arm/boot/dts/gemini-dlink-dir-685.dts @@ -72,7 +72,6 @@ reg = <0>; /* 50 ns min period = 20 MHz */ spi-max-frequency = <20000000>; - spi-cpol; /* Clock active low */ vcc-supply = <&vdisp>; iovcc-supply = <&vdisp>; vci-supply = <&vdisp>;