From patchwork Fri Nov 29 19:05:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 180495 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp1972417ile; Fri, 29 Nov 2019 11:06:13 -0800 (PST) X-Google-Smtp-Source: APXvYqw9ODvw1aQpdoqevnEWpSbbjY1gembEFleyWja90T8rU7diPgWotS8sh0SDxGkI22Uwk/6e X-Received: by 2002:a17:906:16d1:: with SMTP id t17mr16100298ejd.41.1575054373575; Fri, 29 Nov 2019 11:06:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575054373; cv=none; d=google.com; s=arc-20160816; b=N3n4jPHUxnAOcnAnVZ/qqQaF8g462ZPsDFVUNHHnJWkSk57ETBZuQllYzh88ZSVTI5 +VsN120r/58bZMB7BlB1+/1a2MLr/uuN1r4KJ/VQ30oS3vvbkY4xrvVDM7Nnz3eD/6ZY /jFVL970rE8Jaj0LPB/NsEy8efSM48luCZT43xF4foqLvRTqChQe7CdqnQ+b4hnOvWvv pPT7by/4QcMDI27WOVMXMzvRr+NgGsDSsN5S5w1li+8eW4mPLfRcsOxjb2f10rcbAqZP w21jQZUbvHj/1N37jpHLvc/UhiR1y+XlxbFAuH/5mzuprdwuq6zZ+4f7kVM1cgPAws+M VffQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=DmYsGklBxODi9ZXzG+eZphEo00SJ3Wr36G+fPUJuOQI=; b=z+JSUrG+CtnzWnYcPze0Qmv3QtJpSHB5VvJxzIWMvZeqGQ5qdY/g8BQHMRL8Z9gyAR +HnuYQHf5rjTxz2V/4d7Xgk7NEG/6+CIBQdNb9JuEV5XxYyvTSFq17cvQXLWlVXHF4Tg mOZ+LKZbr6Ubt3kLjTrQnjeghMX2KM4ul0+RVQCvrJDCYKpRArOaOaiQqeMOxL0ROuzE QUSWM+nP7fWFbruE1D0jj3BL9AMvkc0AnCyrTZT8agFNIodD2RMUVI/pZ6Jyhg7xRanK Ofhs0gtewV0Dv/Nnywny0EVLnS7v9CWtQcLBRxOiJ8Ffvae/nnIJeXa22daqAoTT04aM ntSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zT92KeHe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s19si17275317edw.235.2019.11.29.11.06.13; Fri, 29 Nov 2019 11:06:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zT92KeHe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727198AbfK2TGM (ORCPT + 27 others); Fri, 29 Nov 2019 14:06:12 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:39123 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727096AbfK2TGL (ORCPT ); Fri, 29 Nov 2019 14:06:11 -0500 Received: by mail-pf1-f196.google.com with SMTP id x28so14996608pfo.6 for ; Fri, 29 Nov 2019 11:06:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DmYsGklBxODi9ZXzG+eZphEo00SJ3Wr36G+fPUJuOQI=; b=zT92KeHeKw8smYn0Wg/ZkYYS3HUIgVo/BEAonyLQotvdGPO9EoJrWytsnE7ricRaJE 4dmmdhb4xHRJX+WKgQfGSe87j8EJk7d7XspMM+7qbebFTHlJavhgkTy6RXPJIaYDb3yq tVRGekzSoLjKN/4vMCyMr7qynj7lOQCKfGYNmezHByEt4fVM9QbjTQBUo7G0A08urYjl XoQ071BJ4RlUh7bgcrpKik6D9P4l8BWS+I0XZ394b7OO5cadlj2iKTCWi/c1DMJkZIcX JpxqJ/nOA8jViQj6VyS4RXGUJUOm+kheO8cyp1mOWT4beaJ0EXk16are4Eoazv7Vf1SR Ufbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DmYsGklBxODi9ZXzG+eZphEo00SJ3Wr36G+fPUJuOQI=; b=Mg7zxoeHdMR61agvTfNvME0kLZ9arL5eJmqjq6QQp/fFtqI3pDoQHtRIMkR+41h7OB nfRJZfbC8qFfchIubxdOjNHRn1qY86ffOqmmaUYgTsHnJjPlcr/6DHd7BaMvGhy7SzM2 f4pKkMQXEJWUssPfCqKDHw+AOtRKeNQOXzXUmIVobolLfoAYqQAQzv5T2OAnnJuhpMjC 7GfQsqarQhJapys4E+OYHjJykjeJy6MolfKdF1eg8Lmz8PII8oS/jXlQU9YMkOTbzpWR fw2TKY9Coypwh/4yo1ZX8xfppMHD+We5/SYan8t8CabK10qWXR2KyAJCghfaW1iRqAAR 0EKw== X-Gm-Message-State: APjAAAVgfds2BWuIXLYRBiNOZvpmJaNHIkleuoJfqzAw7efaYPvJVBfi Ce74lFkLn3kyKFZGxIfUtpyL X-Received: by 2002:a65:5307:: with SMTP id m7mr18546705pgq.113.1575054370197; Fri, 29 Nov 2019 11:06:10 -0800 (PST) Received: from localhost.localdomain ([2409:4072:638d:cc55:d006:f721:cde2:1059]) by smtp.gmail.com with ESMTPSA id h9sm25159974pgk.84.2019.11.29.11.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2019 11:06:09 -0800 (PST) From: Manivannan Sadhasivam To: mchehab@kernel.org, sakari.ailus@iki.fi Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, peter.griffin@linaro.org, Manivannan Sadhasivam Subject: [PATCH 3/5] media: i2c: imx290: Add RAW12 mode support Date: Sat, 30 Nov 2019 00:35:39 +0530 Message-Id: <20191129190541.30315-4-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191129190541.30315-1-manivannan.sadhasivam@linaro.org> References: <20191129190541.30315-1-manivannan.sadhasivam@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IMX290 is capable of outputting frames in both Raw Bayer (packed) 10 and 12 bit formats. Since the driver already supports RAW10 mode, let's add the missing RAW12 mode as well. Signed-off-by: Manivannan Sadhasivam --- drivers/media/i2c/imx290.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) -- 2.17.1 diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index e218c959a729..d5bb3a59ac46 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -75,6 +75,7 @@ struct imx290 { struct clk *xclk; struct regmap *regmap; int nlanes; + u8 bpp; struct v4l2_subdev sd; struct v4l2_fwnode_endpoint ep; @@ -98,6 +99,7 @@ struct imx290_pixfmt { static const struct imx290_pixfmt imx290_formats[] = { { MEDIA_BUS_FMT_SRGGB10_1X10 }, + { MEDIA_BUS_FMT_SRGGB12_1X12 }, }; static const struct regmap_config imx290_regmap_config = { @@ -265,6 +267,18 @@ static const struct imx290_regval imx290_10bit_settings[] = { { 0x300b, 0x00}, }; +static const struct imx290_regval imx290_12bit_settings[] = { + { 0x3005, 0x01 }, + { 0x3046, 0x01 }, + { 0x3129, 0x00 }, + { 0x317c, 0x00 }, + { 0x31ec, 0x0e }, + { 0x3441, 0x0c }, + { 0x3442, 0x0c }, + { 0x300a, 0xf0 }, + { 0x300b, 0x00 }, +}; + /* supported link frequencies */ static const s64 imx290_link_freq[] = { IMX290_DEFAULT_LINK_FREQ, @@ -550,6 +564,21 @@ static int imx290_write_current_format(struct imx290 *imx290, dev_err(imx290->dev, "Could not set format registers\n"); return ret; } + + imx290->bpp = 10; + + break; + case MEDIA_BUS_FMT_SRGGB12_1X12: + ret = imx290_set_register_array(imx290, imx290_12bit_settings, + ARRAY_SIZE( + imx290_12bit_settings)); + if (ret < 0) { + dev_err(imx290->dev, "Could not set format registers\n"); + return ret; + } + + imx290->bpp = 12; + break; default: dev_err(imx290->dev, "Unknown pixel format\n"); @@ -910,6 +939,9 @@ static int imx290_probe(struct i2c_client *client) goto free_err; } + /* Default bits per pixel value */ + imx290->bpp = 10; + mutex_init(&imx290->lock); v4l2_ctrl_handler_init(&imx290->ctrls, 4);