From patchwork Tue Dec 3 22:31:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 180748 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp2152741ile; Tue, 3 Dec 2019 14:46:58 -0800 (PST) X-Google-Smtp-Source: APXvYqy+LQqzqjOL2EFzHHeCzaztqi1oEcBbUwPAuz99YVLogrkrb15IUwvVmDGR1CeE3z1ezxe4 X-Received: by 2002:aca:60c1:: with SMTP id u184mr320265oib.75.1575413218527; Tue, 03 Dec 2019 14:46:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575413218; cv=none; d=google.com; s=arc-20160816; b=mqMMNKGphcKuMwkgqCLhhp2bOlOr1/+c6AojDSID393uFBOIdCrcG5/s5TcbCw+cp0 PhY6ZHMv5cOwCxHP4ToR0H04kZOxfd986/Sos83esSnX78rRtQhz+MN4Nigg3dHMBJ2v 4eKLEkZeec5JFkoXHGOqRSOP5WVjbc/yF0jYeHPlU8xQvXIy0F9LsLbhO15vimnhGdNL v1nAq9OXX+l3dDqHAAnEBmlJMjeibauld4LKI1ooq3OF0mVHslYUB9SoYxxCWNqJW6ut tk1itDthG4Wd1bbx+K1z6MF8H2rYXzpId5KmoGGKevf+4jCOm0m0dnLu4IPC3/IlbQju Rozg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+cvpA14HddYoVLghS762PGcRIyNxb3sMuCIwasVsX5U=; b=aFDrd9H0GXvCwdyH2l13rkYw9jmqQ2SrKZz8GPpyyv+j+Yy89MjLu6NMEL49qYclqh BAXNhHOT1bb5xh+3YDe0NnX+JRRD2O4Xrpim3fUzUGtcI8w/uDmfxu0Gq/cq+bQ/U2Yx 3Gs3xbjOb8yp47UruTcYcRZ/ZqzvRgA0ngAYbFSb4C3S/xTkqeoXdktNthybKnXZ4Ymz Whl/DYBxmIczMZO4KHBHnH4McPQHS+XFOXRTD8XPYBl6FoVk2GKs9VDHSuhGpth2KTTZ HwrqOeekUC8Ie2VbIkspXBQP8ZZLim7uSkidirp0UbsC6AowozEyaF/0dNYOkIhnFOUi B/Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ONQFrvRd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t142si2236239oih.242.2019.12.03.14.46.58; Tue, 03 Dec 2019 14:46:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ONQFrvRd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728984AbfLCWq5 (ORCPT + 27 others); Tue, 3 Dec 2019 17:46:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:36848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728928AbfLCWqy (ORCPT ); Tue, 3 Dec 2019 17:46:54 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CED32084B; Tue, 3 Dec 2019 22:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413213; bh=IILRwKX5JU4fvX0qq9X62rY/7UubGIGOWqV7gSA4zR8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ONQFrvRd4Zy5KtsF/DqUzUJpoyzq70O+22vXyQkOiKxCKx8DsBWNNCRjei1qFa8PN LqT20j/r+5rTmYpp434V8Jb1xRXTafc7MIXjb2k20NLfKsZ4nzfCjNWRkVsSzOxT9p FMnXgwWNzYMVpyAGpeCTwqdKI30otPLnrbKFmquc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kishon Vijay Abraham I , Philipp Zabel , Sasha Levin Subject: [PATCH 4.19 005/321] reset: Fix memory leak in reset_control_array_put() Date: Tue, 3 Dec 2019 23:31:11 +0100 Message-Id: <20191203223427.401475019@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kishon Vijay Abraham I [ Upstream commit 532f9cd6ee994ed10403e856ca27501428048597 ] Memory allocated for 'struct reset_control_array' in of_reset_control_array_get() is never freed in reset_control_array_put() resulting in kmemleak showing the following backtrace. backtrace: [<00000000c5f17595>] __kmalloc+0x1b0/0x2b0 [<00000000bd499e13>] of_reset_control_array_get+0xa4/0x180 [<000000004cc02754>] 0xffff800008c669e4 [<0000000050a83b24>] platform_drv_probe+0x50/0xa0 [<00000000d3a0b0bc>] really_probe+0x108/0x348 [<000000005aa458ac>] driver_probe_device+0x58/0x100 [<000000008853626c>] device_driver_attach+0x6c/0x90 [<0000000085308d19>] __driver_attach+0x84/0xc8 [<00000000080d35f2>] bus_for_each_dev+0x74/0xc8 [<00000000dd7f015b>] driver_attach+0x20/0x28 [<00000000923ba6e6>] bus_add_driver+0x148/0x1f0 [<0000000061473b66>] driver_register+0x60/0x110 [<00000000c5bec167>] __platform_driver_register+0x40/0x48 [<000000007c764b4f>] 0xffff800008c6c020 [<0000000047ec2e8c>] do_one_initcall+0x5c/0x1b0 [<0000000093d4b50d>] do_init_module+0x54/0x1d0 Fixes: 17c82e206d2a ("reset: Add APIs to manage array of resets") Signed-off-by: Kishon Vijay Abraham I Signed-off-by: Philipp Zabel Signed-off-by: Sasha Levin --- drivers/reset/core.c | 1 + 1 file changed, 1 insertion(+) -- 2.20.1 diff --git a/drivers/reset/core.c b/drivers/reset/core.c index d1887c0ed5d3f..f7bf20493f23e 100644 --- a/drivers/reset/core.c +++ b/drivers/reset/core.c @@ -607,6 +607,7 @@ static void reset_control_array_put(struct reset_control_array *resets) for (i = 0; i < resets->num_rstcs; i++) __reset_control_put_internal(resets->rstc[i]); mutex_unlock(&reset_list_mutex); + kfree(resets); } /**