From patchwork Sun Dec 29 17:22:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 182557 Delivered-To: patch@linaro.org Received: by 2002:a92:815a:0:0:0:0:0 with SMTP id e87csp5460152ild; Sun, 29 Dec 2019 09:46:24 -0800 (PST) X-Google-Smtp-Source: APXvYqx2gS1JkdFGliOLB9N30wyffA47XbOcSFEAdg30QhaEuFxK5HgKkFWnH1OawZM4JdWAbvby X-Received: by 2002:a9d:518b:: with SMTP id y11mr66340365otg.349.1577641584258; Sun, 29 Dec 2019 09:46:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577641584; cv=none; d=google.com; s=arc-20160816; b=kT8wa2tCFSFN090sI/1O1FZAEXan2LMZCRhl5mLYd+G5VQ8iam2S6MuPNJBzGG/PXk sDFrdtnvDMyF7OkqYhzzwL5lrRCXfWES7E+6CAApKOTjstZg2joUnPwf04pTnmakr76X LtXBBYTjhXmLsBoksJD1KD95bcl4a0CZ++fE9l6bti+zxdJbhTlbzyjFVtKrF28sY1mg 4480IQky2OXq72zxLo7LOX3EjKOJ2y9avrKSbSE5tyIxVKqUwUtk6vyieWqOLy+zQqlD o1I+yBAw0IPkXOfpUStUXBF42C9RRDt8YkNxjRjaDzeghQJIygGPYwNVNANoOsgijati xalg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Bh5BSbW2we0lVWWUbwHFx62PtQh4ZlkZH1jeG/5nQi0=; b=RBW+ZyyseWF03x5t12QwMxFxVVOzXP3Xam4njXc27XOITO9Kq60iI6kQi82g4EhsRy A1XDsbRZH17dguB7wNeI5A5yApyvRIrbEBLcDuV5Gw6Pjiqp1/1zxE6JeWobY5cOq/nu 4NYhHipdug5wCId7o0l+LjFp5x8Kw03Xl1nJ3UdYdqhHyyHWsRfyUa/5//h8kg5MtIqI iPAOZrfkS3DcePsLOZBC8OVzxyhXMV+PIeEr664N2RIPXIsl7tVrVyslWnG2kI0As/fr XKHXi7UGsj0eKwnZ2RpllH6qFdVOoxz9uAjl9fFmRjteWEbmYDfStPPj4wtTFEq+gAzk LRGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wnZdZOiU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b18si9406078oib.170.2019.12.29.09.46.23; Sun, 29 Dec 2019 09:46:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wnZdZOiU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731061AbfL2RqW (ORCPT + 27 others); Sun, 29 Dec 2019 12:46:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:55928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731047AbfL2RqR (ORCPT ); Sun, 29 Dec 2019 12:46:17 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 262D824670; Sun, 29 Dec 2019 17:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641576; bh=hXZmK+bkVoyydZcV2t6icF7qk4k967/iyGDHo0RHLoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wnZdZOiUoTFUkL/jiNdEa+6ORfKTjZxvfFOiI8bVibpx43aAAe1MnSnN/9l8geAIb qB9mz7RNQyoXef7qs8P0orZCTpxibHPRDtR6X76gia8sA7+B7xSnD/Yd2yW74RIdmQ Q6YHVRIYxHxRhsSxsq1A75545PNGbPcLn51x9zJk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Pascal van Leeuwen , Herbert Xu , Sasha Levin Subject: [PATCH 5.4 123/434] crypto: inside-secure - Fix a maybe-uninitialized warning Date: Sun, 29 Dec 2019 18:22:56 +0100 Message-Id: <20191229172709.865939809@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229172702.393141737@linuxfoundation.org> References: <20191229172702.393141737@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 74e6bd472b6d9e80ec9972989d8991736fe46c51 ] A previous fixup avoided an unused variable warning but replaced it with a slightly scarier warning: drivers/crypto/inside-secure/safexcel.c:1100:6: error: variable 'irq' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] This is harmless as it is impossible to get into this case, but the compiler has no way of knowing that. Add an explicit error handling case to make it obvious to both compilers and humans reading the source. Fixes: 212ef6f29e5b ("crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n") Signed-off-by: Arnd Bergmann Acked-by: Pascal van Leeuwen Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/inside-secure/safexcel.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1 diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index 294debd435b6..991a4425f006 100644 --- a/drivers/crypto/inside-secure/safexcel.c +++ b/drivers/crypto/inside-secure/safexcel.c @@ -1120,6 +1120,8 @@ static int safexcel_request_ring_irq(void *pdev, int irqid, irq_name, irq); return irq; } + } else { + return -ENXIO; } ret = devm_request_threaded_irq(dev, irq, handler,