From patchwork Wed Mar 25 11:34:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 184804 Delivered-To: patches@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp505780ile; Wed, 25 Mar 2020 04:34:29 -0700 (PDT) X-Received: by 2002:a2e:3a01:: with SMTP id h1mr1665226lja.161.1585136069044; Wed, 25 Mar 2020 04:34:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585136069; cv=none; d=google.com; s=arc-20160816; b=b8DM4IEX/cSrVcs051hISu4PNpnfMNLU1xviN6XqMOPN7lFMz9dO0NyyaTI3k0qe1w zxOOxYUDs4QmGmdkXOUiU+Mn5TXNifr/V49Acmp2w22UAo2vYfE5Xnq7cDmlHgImETZx wbGtufBXysTgTTYDaseWC4e+77kEOfmSvUETP57fu888HvvakJhaauw8GVKDIoFZ1qrL jKTCb5VfiEt2mlzCGoJhx1DUTV6Rk7f6m3DmvhvFJVwq/pYNCpf6y9b0k2BFhdvlb+Ht 7L8rFX2esIqIrc8d4Mp9oWTtE8ssvm1ychmqVPx4mGiJevaS0Lk4bjnEnWe2xOW3opBr z9nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=QPegYuSfHcA3EBvl8rBN548IrIHva7Siiqx3+i9i/fk=; b=pq/DjHmBPx8JCDp7wl5qTTk6Yh+0fo0GugAAR59Gy/OerUv2XcU88nVl+3/0CRbPbV KyyXbqUDWzxSeE1MokrNa/boTwg+1dnfdKILsttYYeN6UWzXaz+RWK6Fh2wrYEzCLqzR wgh7ZdajRZPgwrbuROJnZfsBfPz1icSfvRuNnaYG1YXiTazLtZ9tbuWqCPRAf3z6kc/q 5roM1b7dz6heot/e5j8caJSzGQblBtYUXemZByYnG8YNpZnxLF1am9S30hAn/bV2HVsK 9z0k5VHZOESaYQTQqigLwOS6AovZ1gCfrHjqNM3iVdD9aYXfz8Y58QT14M/R+jj6foWC tJFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aXIfbdqk; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u15sor175647lfq.19.2020.03.25.04.34.28 for (Google Transport Security); Wed, 25 Mar 2020 04:34:29 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aXIfbdqk; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QPegYuSfHcA3EBvl8rBN548IrIHva7Siiqx3+i9i/fk=; b=aXIfbdqkfrWHNMJxk7rgpfQnHosJstUgv+nPJg8nxRo+9pKouM26WAI5jitlKG5zYm dZx7N6OfzJ8B8lp5AR5Z/nKynJm5BIZo5mfsjpnAouFOVrITTq+MpsKOdTK1TnVZGr6J ZXD2xs25UMtjG5Seqi4Yh5xID9TbudX70og/9CFMxinK3V+PWmxJYgvnCCYaBfOylFDU sGLI80eAP38UiXXmS6eBcqtzZVijLUoii6AuDKzHfZGoxLxCvXIxIjGTYuwjdAwTyjxy RcJsKyFXDpgd4yPdbiI4DwWjQrdAE5T9nhViX9NpC7LDGEGvjepXCx2QLRJr9XWlR41n bh0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QPegYuSfHcA3EBvl8rBN548IrIHva7Siiqx3+i9i/fk=; b=H7rR5XjH5nSWDUVDOl6d8Tzv+8Y/bVQ/grfKxPE6ycGsz97607qxDgxpGq/agP1JF4 XlVtc9wcumDUjoueOKww6JN/RoSSbOjZD8IxpWt6jaUwX6cqN91UEz5an0brYJNf7lYw +fzkuaNLgHbA7FH7Xr1hV3RoLIhBh4YsYSlia+WQzjC8+jHsDS+g8pqTm4nbqQk6eaX/ CB/ZoUERsik164D1vhCyfYtqv3BmpEjTMocUvn678jj1Xj8o42SCYBR7I4rOYTfT53s6 6r623tvgVdOmqKr0Z0IThWbHqVj6BQwkOP2IgkdP8g1sIW38FyIsT5cI5fVEEEzEwK4B VLyw== X-Gm-Message-State: ANhLgQ2T82T++qLIDO063GRpWCdojW5mQOkE0KWGYUhKeti1M8PC2mZm dTBRWctxc3yDvh7DyCWM+zkzdsfT X-Google-Smtp-Source: ADFU+vuRSm6/etAQz80VrEgGUDZc5VTTv9FpBEJTzRn3gDVEDfDCfTlInPIezeIUpXLoXiDhoHUYOw== X-Received: by 2002:a19:4cc2:: with SMTP id z185mr2098414lfa.0.1585136068643; Wed, 25 Mar 2020 04:34:28 -0700 (PDT) Return-Path: Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id v22sm3920009ljc.79.2020.03.25.04.34.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2020 04:34:28 -0700 (PDT) From: Ulf Hansson To: Greg Kroah-Hartman , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Christoph Hellwig , Russell King , Linus Walleij , Vinod Koul , Haibo Chen , Ludovic Barre , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, Ulf Hansson , stable@vger.kernel.org Subject: [PATCH 1/2] driver core: platform: Initialize dma_parms for platform devices Date: Wed, 25 Mar 2020 12:34:06 +0100 Message-Id: <20200325113407.26996-2-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200325113407.26996-1-ulf.hansson@linaro.org> References: <20200325113407.26996-1-ulf.hansson@linaro.org> MIME-Version: 1.0 It's currently the platform driver's responsibility to initialize the pointer, dma_parms, for its corresponding struct device. The benefit with this approach allows us to avoid the initialization and to not waste memory for the struct device_dma_parameters, as this can be decided on a case by case basis. However, it has turned out that this approach is not very practical. Not only does it lead to open coding, but also to real errors. In principle callers of dma_set_max_seg_size() doesn't check the error code, but just assumes it succeeds. For these reasons, let's do the initialization from the common platform bus at the device registration point. This also follows the way the PCI devices are being managed, see pci_device_add(). Suggested-by: Christoph Hellwig Cc: Signed-off-by: Ulf Hansson --- drivers/base/platform.c | 1 + include/linux/platform_device.h | 1 + 2 files changed, 2 insertions(+) -- 2.20.1 diff --git a/drivers/base/platform.c b/drivers/base/platform.c index b5ce7b085795..46abbfb52655 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -512,6 +512,7 @@ int platform_device_add(struct platform_device *pdev) pdev->dev.parent = &platform_bus; pdev->dev.bus = &platform_bus_type; + pdev->dev.dma_parms = &pdev->dma_parms; switch (pdev->id) { default: diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h index 041bfa412aa0..81900b3cbe37 100644 --- a/include/linux/platform_device.h +++ b/include/linux/platform_device.h @@ -25,6 +25,7 @@ struct platform_device { bool id_auto; struct device dev; u64 platform_dma_mask; + struct device_dma_parameters dma_parms; u32 num_resources; struct resource *resource;