From patchwork Tue Jun 2 05:25:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 187357 Delivered-To: patches@linaro.org Received: by 2002:a92:5b0a:0:0:0:0:0 with SMTP id p10csp3657768ilb; Mon, 1 Jun 2020 22:25:39 -0700 (PDT) X-Received: by 2002:a17:90a:224a:: with SMTP id c68mr3152460pje.21.1591075539370; Mon, 01 Jun 2020 22:25:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591075539; cv=none; d=google.com; s=arc-20160816; b=bFQGNBK19ZAWp/KOyHBN73D2u8keTuuXPaXK6zsmjtaKIa/MWuvxZRUtzoZ9jwX3p+ dmqS5ZRtWLuroH7qIJ99K1/0iwxtyvS/0UilHqskR7bt4BiyBvdyjEkNIT7K2v7hbgFU HPH3U5SwgLk+Pv4po290u+P8JBuYM5nc/u1NVV+Y4PUMmr9z5HeIX/FgWc07edU+evt4 Hns3fZYYtX5yJbN12lriDmuBnwvtZI6DAJLc5rD4QTMcnoIX+o6YY/27KTuovS6nYBdr YnOYr8qIu7FA4e+r63hUkmkXlvZgNda7bmLlQCAMI5DNxRTEg2kaUrVx7/9fJOiIWROg Uo+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=pmTQ2J+ewmzAEXPhfQy/+hCxdmaweoAFACeDccmRGl0=; b=0gC5gNrzxui7Kmz0157cFUn8x8BQ1jXoRpjhC7jpP2oNBMhQvGIOdKN+6QKFGGzRtS awknMrhl0OHB6Mqk2P7bJHkW+XpHP7529fnBv9a7Wfp3PTXkDZOl953TFD5XAAVZL8UT yVMUYr16rKhZfHa17yRFXxkjdMiygDoI0ATYE03rRs7grSm4xUNCrScknfJxQGXgu4SU iSKTe9vnKM7q/ilXXEqURaonRKIpuVYVqxo9TwDYW7UCbatLXeIFnQLCHynPze7rZyVC 40ka5ozVDTlTIWwn8U1EUxT4o9hDja7sc3KU0vg2/WIoFI3eg29xoNKVAAst7yk6ioFR wyIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h5yZkA2l; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id i6sor1553901pgn.44.2020.06.01.22.25.39 for (Google Transport Security); Mon, 01 Jun 2020 22:25:39 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h5yZkA2l; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=pmTQ2J+ewmzAEXPhfQy/+hCxdmaweoAFACeDccmRGl0=; b=h5yZkA2l+Mg+kNUOWElvwFJjm2e1UB14Z+QBIySxys0830XZ9MF/dClCMu0l+DtKGE o9SyVR1BIDZ3dTL5vmbUYfxj5uQDWDVnQkYbK3iVMAeELega+0qsbn2jRbtwi7O+/WVX BSeQ5q/IdE+Epsq46jRoijqjDQ4CM0PTYlNMvNfB62aHj+0NTnLn4zQ7KK2DkAgUXeTd GDhhQQEK3NpJp5a2mmHIYUmj+UQN7VgW+hpPJViUZJoPX3HTgTeSSz5YCXSAdly87wOB iFISROlBAuTNkdchyO4pMVuAJdtWnq0kIUOHdMMad4/APHraiQ0dY9xK/7xJbS4e03CO ZPUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pmTQ2J+ewmzAEXPhfQy/+hCxdmaweoAFACeDccmRGl0=; b=DhtzudFR1ny0ky/xzUuIbZ/ju5dXRUMAq+8T6UUn01HyNhsZuAwgSXfUHj1dsam03f 4m+XUs62t6OceDdlPRA2awiSMSYimT5X41kyKLKeZdfBMr2z4XTSkCaKCFCN5EZgYrBR M6DiIXPdppxu8EDpYe2Q7Ho/1ZbsH2ICR5cvR6pvTgENZsoRm/CS162rdCw/VdH7/lAW 6DLzsRYH9PBbfd7CJRRaP/DLULwAD5t4tw7Rs7TRHYHyFvkzusVPCMIvvMUD716TVERj TdL+bLtfahKeS/DyeupMVpM0UHhFVi1h7oDHrcBqxabdvaYNamERWxifgB+TBuQjNFPH QISg== X-Gm-Message-State: AOAM530GYQlJ3/NYfv2vH2W1VfPBh6mLRXyY1lEGAzG7/6UZikrdDIJX jB10tMDfBc/yZt3QaMph/SCSaRj0 X-Google-Smtp-Source: ABdhPJym62I5PYrbey5hKJ41iA2hotYaRo67Whb7YuRi7XclxNuXaWayAK5GxIE0maNqAf41WqvcwA== X-Received: by 2002:a65:6795:: with SMTP id e21mr22870328pgr.282.1591075538931; Mon, 01 Jun 2020 22:25:38 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id f7sm1031988pjp.24.2020.06.01.22.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 22:25:38 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Rakesh Pillai , Govind Singh , Bjorn Andersson , Niklas Cassel , Manivannan Sadhasivam , Amit Pundir , Brian Norris , Kalle Valo , ath10k@lists.infradead.org Subject: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot Date: Tue, 2 Jun 2020 05:25:33 +0000 Message-Id: <20200602052533.15048-1-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 Ever since 5.7-rc1, if we call ath10k_qmi_remove_msa_permission(), the db845c hard crashes on reboot, resulting in the device getting stuck in the usb crash debug mode and not coming back up wihthout a hard power off. This hack avoids the issue by returning early in ath10k_qmi_event_server_exit(). A better solution is very much desired! Feedback and suggestions welcome! Cc: Rakesh Pillai Cc: Govind Singh Cc: Bjorn Andersson Cc: Niklas Cassel Cc: Manivannan Sadhasivam Cc: Amit Pundir Cc: Brian Norris Cc: Kalle Valo Cc: ath10k@lists.infradead.org Reported-by: Amit Pundir Signed-off-by: John Stultz --- drivers/net/wireless/ath/ath10k/qmi.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.17.1 diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c index 85dce43c5439..ab38562ce1cb 100644 --- a/drivers/net/wireless/ath/ath10k/qmi.c +++ b/drivers/net/wireless/ath/ath10k/qmi.c @@ -854,6 +854,11 @@ static void ath10k_qmi_event_server_exit(struct ath10k_qmi *qmi) struct ath10k *ar = qmi->ar; struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); + /* + * HACK: Calling ath10k_qmi_remove_msa_permission causes + * hardware to hard crash on reboot + */ + return; ath10k_qmi_remove_msa_permission(qmi); ath10k_core_free_board_files(ar); if (!test_bit(ATH10K_SNOC_FLAG_UNREGISTERING, &ar_snoc->flags))