From patchwork Tue Jun 16 06:13:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 187970 Delivered-To: patches@linaro.org Received: by 2002:a92:cf06:0:0:0:0:0 with SMTP id c6csp3370329ilo; Mon, 15 Jun 2020 23:13:46 -0700 (PDT) X-Received: by 2002:a62:3183:: with SMTP id x125mr755580pfx.3.1592288026490; Mon, 15 Jun 2020 23:13:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592288026; cv=none; d=google.com; s=arc-20160816; b=XFyIWpF95u2Tt/AHuwds0BakxfKayFWloBMPe3eZ4aae6CHPfoCVbzXjA7JqMNrOAd nfWhjTKokDBZ+KBht30d3QRYi1rWCzyCe/kbvmwoonGlhLoCgseN0eCy7EvwMGlFPzWE zqcKY4wepeI9uvuh06AOIwHdgYcZec8lnsWd7QtPolg4cRCyErlmFpGL7SmQVyX+cYN2 9/DAvy97JM9VTJApvT1DVCFaYaE/J7ghnFOehZq8b56JHOKIqPu3lSM/gSDygxEp3Ssq L/y7dI/64ZVGtQh/2RhNvuWCTbOtt1kGM0S4KYfe1wWlGuKEXZkNMdo1eoEw1QbekSrb XEgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=M2uJULnvxDpfHs89lgaTRTB9rey6NHbhAifKB1x72gQ=; b=nevVSrES1VDIFcb27VWV6WQQ7D1bZoz4EUwi3gvZOZ/XRKVnbjWgJ/uh4ls6Rh+/yl soDWfuk0NcXqKvN1MFPpBj2yyAqNS8UzULishffsCt5kjkltQtdj4+BFlCPkQeiPyQM/ oM5JntkdflS5XcvTv0WhLCXFvQb7NB+spqV4bzh+o+AT0/PQiR/LPWTq/rYS0aCFSB+B JvO4tZH/JNrYKhvZAM3x8vuAYDyBGckjHehR3L5ypveG+3MVO7UwbgxbOImG/rZQRtW5 3WxDiGpk8bD7eIm7xk5mGuXiMSd/s+sLWW2JQ84CD7MhvoT4dqnVWe+CsmGLA+X46r1X rKyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HS2MKGAs; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id d8sor2206150pja.1.2020.06.15.23.13.46 for (Google Transport Security); Mon, 15 Jun 2020 23:13:46 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HS2MKGAs; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M2uJULnvxDpfHs89lgaTRTB9rey6NHbhAifKB1x72gQ=; b=HS2MKGAsNdjUxJ+yy27jcpiH1bk7koug2OAXwLJHoTgucSozWnIJSObeAki8dM05am DLCS+qX0P1LSqKwIln1ckxouXz0KbXo3o0tpFiRBYmK+NPiqKE6pDzuqc9M+Woh0UQ59 0qIqzR0HzmFta9njqekXv2RYydZQgrYMTxUNtcLireoA0iUhs07M+xTESQi6DDO/vBQo bSM6fZK5iqdLi0jpB6PQWvFyk1ti/AJVyzKrfiIVqCShGFceJ3mF8PFRVhuFFpNV+gJ8 6/V4j3vwecDwCtqKeIWENohJF3zGujG5GiKGDkkY7rGGOJZOxBk/IL493YOcEiEuhVBI PAjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M2uJULnvxDpfHs89lgaTRTB9rey6NHbhAifKB1x72gQ=; b=kMDnKgBJKSBcGPDyOviQuuF94/pGwgq8NOciFFsI+53uRoTVcVF5ujSg1SjwmhomAb 73kPA/Q1lCGuLPYaFsBz5qxq41UfFkHNLnbrUXBOoG05cJPAj8V3CSm6OEgvIFqaOX77 CVr9JgJ+bU3F3XtzmJaBHdFAogPaXb7f0SVG7E5ZxRPwm8/hu/KaaY0IaCyXj3KmSOwm sKgbmd2q2+MNyQocmIAQ47J+rtKJN2fnu+d7B+f1ANKwnMEDA5PqrZfP0xlQ7XVQG8/M VvlJaDsJiZI12tHkMfvBYRwulgLsW2ZwF0KeS7Tm9Zyt88eypT2T7PoN+VhESx5kHNmj /+/g== X-Gm-Message-State: AOAM531gg81bHQpq9iGHeedUtPeLcB4KntmjRHAInIDG04mGiSTtuqti NMmnWMJVOzjGZqgSvmJ5wmbqEAYE X-Google-Smtp-Source: ABdhPJw2m1e+LDbBPxO7NdX9TwT/7AlJxXRrPGMYRWdq75cFQWSCTf4uPSRnj0rAwyp+oCkFUZF2jQ== X-Received: by 2002:a17:90b:238d:: with SMTP id mr13mr1308289pjb.19.1592288025969; Mon, 15 Jun 2020 23:13:45 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id i26sm15642032pfo.0.2020.06.15.23.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 23:13:45 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Andy Gross , Bjorn Andersson , Joerg Roedel , Thomas Gleixner , Jason Cooper , Marc Zyngier , Linus Walleij , Lina Iyer , Saravana Kannan , Todd Kjos , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-gpio@vger.kernel.org Subject: [RFC][PATCH 3/5] irqchip: Allow QCOM_PDC to be loadable as a perment module Date: Tue, 16 Jun 2020 06:13:36 +0000 Message-Id: <20200616061338.109499-4-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200616061338.109499-1-john.stultz@linaro.org> References: <20200616061338.109499-1-john.stultz@linaro.org> Allows qcom-pdc driver to be loaded as a permenent module Also, due to the fact that IRQCHIP_DECLARE becomes a no-op when building as a module, we have to add the platform driver hooks explicitly. Thanks to Saravana for his help on pointing out the IRQCHIP_DECLARE issue and guidance on a solution. Cc: Andy Gross Cc: Bjorn Andersson Cc: Joerg Roedel Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier Cc: Linus Walleij Cc: Lina Iyer Cc: Saravana Kannan Cc: Todd Kjos Cc: Greg Kroah-Hartman Cc: linux-arm-msm@vger.kernel.org Cc: iommu@lists.linux-foundation.org Cc: linux-gpio@vger.kernel.org Signed-off-by: John Stultz --- drivers/irqchip/Kconfig | 2 +- drivers/irqchip/qcom-pdc.c | 30 ++++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 29fead208cad..12765bed08f9 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -425,7 +425,7 @@ config GOLDFISH_PIC for Goldfish based virtual platforms. config QCOM_PDC - bool "QCOM PDC" + tristate "QCOM PDC" depends on ARCH_QCOM select IRQ_DOMAIN_HIERARCHY help diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c index 6ae9e1f0819d..98d74160afcd 100644 --- a/drivers/irqchip/qcom-pdc.c +++ b/drivers/irqchip/qcom-pdc.c @@ -11,7 +11,9 @@ #include #include #include +#include #include +#include #include #include #include @@ -430,4 +432,32 @@ static int qcom_pdc_init(struct device_node *node, struct device_node *parent) return ret; } +#ifdef MODULE +static int qcom_pdc_probe(struct platform_device *pdev) +{ + struct device_node *np = pdev->dev.of_node; + struct device_node *parent = of_irq_find_parent(np); + + return qcom_pdc_init(np, parent); +} + +static const struct of_device_id qcom_pdc_match_table[] = { + { .compatible = "qcom,pdc" }, + {} +}; +MODULE_DEVICE_TABLE(of, qcom_pdc_match_table); + +static struct platform_driver qcom_pdc_driver = { + .probe = qcom_pdc_probe, + .driver = { + .name = "qcom-pdc", + .of_match_table = qcom_pdc_match_table, + }, +}; +module_platform_driver(qcom_pdc_driver); +#else IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init); +#endif + +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Power Domain Controller"); +MODULE_LICENSE("GPL v2");