From patchwork Mon Nov 23 22:23:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 330690 Delivered-To: patches@linaro.org Received: by 2002:a17:907:2110:0:0:0:0 with SMTP id qn16csp3882417ejb; Mon, 23 Nov 2020 14:24:03 -0800 (PST) X-Received: by 2002:a17:90a:7504:: with SMTP id q4mr1172455pjk.213.1606170242987; Mon, 23 Nov 2020 14:24:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606170242; cv=none; d=google.com; s=arc-20160816; b=lQMd3MvAYxh4Sp7227sjvjsNAgFX1Ow/MVP49RhJ2XzmcugBTQApbXL+F/EKEkGp1V wdiB4bGULvi97UJi2YJdQLGFp2VLLXmqEjHamWgGWNsYUPwmSXcMPVHSuXVsqJQtq7CC HiYUp3S+t2SyjUFNXZkioHBzRsLr6AxWfJ609K0HdpTOrbckdJUU74NTlJuRGZF89k/r FZLrEV0u+PbEnCCPBtuRZGywSAkwCGR6suwTA+FOw/oq6sSNBhNmddhH9DB6VqwY01l4 2FzwbJ0gkYza39ONoxDqR5wBhKIP4dqUtOrOj5e86OXIoI/rGcXU1sGn7Tmip8nA44u3 13xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=sYmwP8t7TxHJ62xKzIUva7lVBCpyFaPUSVAcVVKAMoc=; b=j73e41fSu+BZ9+ePcMbXAUDTUlGtmBjN3EGGBBtbv3fYAQirfJXGEhI1chIQZcVnCH xAkl4FJUW2NDOufRDqD86c5wUGK+oQGo2/IEJSrCGcRlzzKuVj95rlgi5CGBGRaOtE0L EVN6xTaFwxGg5420ATl6ClmlidUj23XVDrvfuexl9S3EnlS9LBfiHhhVrEE/Hji6KcBR aVklGarz2sXTY6/VZ5S+nnjIoUDY/taLQjOvBOtbuoO+H8qvuv1a2Jr+7IXRlCUYveyG SDaK2/cMDHsZVXaWkNN0Ryvga6t3CGNhfa1TI2FQ1RuDslrYz5O6SZntONsKKJiucVlH l8Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aOqJMx++; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id m1sor435158pjl.1.2020.11.23.14.24.02 for (Google Transport Security); Mon, 23 Nov 2020 14:24:02 -0800 (PST) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aOqJMx++; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=sYmwP8t7TxHJ62xKzIUva7lVBCpyFaPUSVAcVVKAMoc=; b=aOqJMx++sC+xT7/75CuI3FlV95QEjv3cRGoU1BWcQeShqdvzjNc2247deUlkdkBiMI T6aLg5cjgySA5tL2TsTbeL1s+TZI1N8mSgTln4ta865ol7ARUbNv1KhJ5k2vZFyT+P8m /fJbrBQXyLZBnkYrl9cgwJFVasnGS9EimQjWlhV7eoJ5tIh0xEYNFe6D2NFOmLVoLewO gKM4RZZwvgHOOPcVRL/sR+WiE3TqPrNC4KylQKYWssg5Ng38C6mjUwAeIrcPedHqSAPo RWKlGf40b80K7i3Vwza1VCY/kQxHwoaFCZgsiJNCzck/qbbp/MUBi5ygVeESoSXursQZ LY1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=sYmwP8t7TxHJ62xKzIUva7lVBCpyFaPUSVAcVVKAMoc=; b=P4+aW3LZZFgRkdJBaHDHP81mS/Y9lTIL5KCJL5kWJ6ZWawhPjjqE12v3yQZ/0MMQgr qmJIyO+WCmxdjW1X/MmgDuEmasgmvcowLFla1sBubQeFbtaO/FHubHwFeW8RB+SE/52I yhwXSNMPlF2vNd4zfiXvZjCqXKXj3IZI0ZFDR+8WLOduVH0XA+7jCgD+SnEmDrORu3S4 PGUY/15c67NommhZGCeZ3Ob8brE833fG1AWv9yX1Qsb6/Bvn0c0r2EdyXTVxUDEO+3cR E9qbBnJOOL49vlHwj/f43JZapkNwqu0imO+aK2cPnFhhhitzsFlZXPGlh8ZJPu7XfcA8 v7Zw== X-Gm-Message-State: AOAM5335ck4kpRX5bVY8d+OIY+NDkMKNDTxQ8zmd7gCi8HTA0hp5GbbR H+LmU8asNw5KpKytyDtgeiA7eZ7r X-Google-Smtp-Source: ABdhPJyu9Uo9CrcFwMhgI4t9O9QAE3zTseSTSA2FM03Uq9woUurMxRBsbIeTJdDmDSwKdP+xMoWIQQ== X-Received: by 2002:a17:90a:ee8c:: with SMTP id i12mr1182810pjz.204.1606170242542; Mon, 23 Nov 2020 14:24:02 -0800 (PST) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id ge21sm416029pjb.5.2020.11.23.14.24.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 14:24:01 -0800 (PST) From: John Stultz To: lkml Cc: John Stultz , Todd Kjos , Saravana Kannan , Andy Gross , Bjorn Andersson , Rajendra Nayak , Maulik Shah , Stephen Boyd , Liam Girdwood , Mark Brown , linux-arm-msm@vger.kernel.org Subject: [PATCH v2] regulator: Kconfig: Fix REGULATOR_QCOM_RPMH dependencies to avoid build error Date: Mon, 23 Nov 2020 22:23:59 +0000 Message-Id: <20201123222359.103822-1-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 The kernel test robot reported the following build error: All errors (new ones prefixed by >>): xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel': qcom-rpmh-regulator.c:(.text+0x270): undefined reference to `rpmh_write' xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request': qcom-rpmh-regulator.c:(.text+0x2f2): undefined reference to `rpmh_write' xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel': >> qcom-rpmh-regulator.c:(.text+0x274): undefined reference to `rpmh_write_async' xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request': qcom-rpmh-regulator.c:(.text+0x2fc): undefined reference to `rpmh_write_async' Which is due to REGULATOR_QCOM_RPMH depending on QCOM_RPMH || COMPILE_TEST. The problem is that QOM_RPMH can now be a module, which in that case requires REGULATOR_QCOM_RPMH=m to build. However, if COMPILE_TEST is enabled, REGULATOR_QCOM_RPMH can be set to =y while QCOM_RPMH=m which will cause build failures. The fix here is to add (QCOM_RPMH=n && COMPILE_TEST) to the dependency. Feedback would be appreciated! Cc: Todd Kjos Cc: Saravana Kannan Cc: Andy Gross Cc: Bjorn Andersson Cc: Rajendra Nayak Cc: Maulik Shah Cc: Stephen Boyd Cc: Liam Girdwood Cc: Mark Brown Cc: linux-arm-msm@vger.kernel.org Reported-by: kernel test robot Signed-off-by: John Stultz --- v2: Switch dependency logic as suggested by MarkB --- drivers/regulator/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index 020a00d6696b..481c7b10133b 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -843,7 +843,7 @@ config REGULATOR_QCOM_RPM config REGULATOR_QCOM_RPMH tristate "Qualcomm Technologies, Inc. RPMh regulator driver" - depends on QCOM_RPMH || COMPILE_TEST + depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST) help This driver supports control of PMIC regulators via the RPMh hardware block found on Qualcomm Technologies Inc. SoCs. RPMh regulator