From patchwork Wed Sep 19 22:20:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 147049 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp1232856ljw; Wed, 19 Sep 2018 15:20:48 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdaaxl3431P8KRgn+2fuLaVSa2oBZV296quB5ZHdarhK+D6wKP4xLYo0m3bSoyKZXZpm2QV/ X-Received: by 2002:a62:3909:: with SMTP id g9-v6mr37928541pfa.176.1537395648728; Wed, 19 Sep 2018 15:20:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537395648; cv=none; d=google.com; s=arc-20160816; b=VEzYWYZfJplEjlc1CjtF+SSTpR7Xq27yLzAgw/suqFKwow53vxad+IfOKWIeVehEux z72NJIe8hC9ouz9tdR9ltgl8w8yNN+JSSx6wqJONDVlDl+tmlxtyILFqbuA0GzzXQl06 dC+oXS1qb8pybyhS1RLACTYUHyWbR/KQxBycMnZ8Kx5GjanS7isNSL0MWqTsUiI3aMZ6 v4xprLzsGLofgNR0jmzR5K7yDZccFBVhYzDmvQ6puOO2AMCWllj04Rg4i9pAcpHXg9/S LQ2dDyzzn7X+gz2AcZmv+uD+uhsz+mA2otUg969U0/CiSlCcOI928Mi6puzGxpYo3FD7 H6lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=/7A+jgDIUZCGxGLhoGYTieLMUMpj5eaMcqaxJhDr4YA=; b=y3g2Hg8+cvVUNn6GheXD3K/xwi38LUWDw8/+5pYhx5an47ogabyTYZrjys+vYuWPHk f8taLbiuAVLlndKu97liMb8l8ul6q9mD4EQ1df3KwWMDRXhmY88eDYoGLtAYLUPr3zJ1 wR+/3/FWmweWE+cIj9trnSuDbomH3Qe4JTkWGnLj4Z7IuQcUzVP37crhrqZwTNlF2xzA R9FwUvOqA385cade2fcuEvQofjhrLAOd00gv3soRrW0BnLzPbUH2ry8lh04WOD6yGlPW 4HpV6+TYKMMJGlByQM33oIHEtrRm2pC/ppL0w6fat7N594wxfkfnQZxMPJiBEPcul+/N nYzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BXitjeAa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b30-v6si22112844pgm.389.2018.09.19.15.20.48; Wed, 19 Sep 2018 15:20:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BXitjeAa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726296AbeITEAr (ORCPT + 32 others); Thu, 20 Sep 2018 00:00:47 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:41893 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725784AbeITEAp (ORCPT ); Thu, 20 Sep 2018 00:00:45 -0400 Received: by mail-pf1-f196.google.com with SMTP id h79-v6so3343686pfk.8 for ; Wed, 19 Sep 2018 15:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=/7A+jgDIUZCGxGLhoGYTieLMUMpj5eaMcqaxJhDr4YA=; b=BXitjeAafq8N0RjL/QUGy9m5AifOy3d1uuIkG/hOfeQrnNf1WzTljTy2lUbyaBJPfO KWqpu6n98jyuWmA6R4w0PI0OnZNlmgjAe6EbRFKFcFfc9UYON/AX0QI+KcTeF2k123a9 dNbuUEn9RMaKtaFqrXV+FqWr/1kr/Im2EfI5Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=/7A+jgDIUZCGxGLhoGYTieLMUMpj5eaMcqaxJhDr4YA=; b=bjc0rKBmEH9u/MOLxA2YpCKcdjzTTpmXKeYcccQ47LDIoBlaJpfIpfU9JWgOHrO4qJ wRreMb5w+dZsEtt9ctx8gl7SJU0ItAJB0XeH7sMruoka6PIEf8vkBbBk5YRemJ7q3P9/ IrLvkizu7/bRnAA29j14s8GgtOtf2l566KJlV3eHnF7vzUhvH9/cGLcI3fViFOQQ8t+R Bu9yBB+748QT7EWWvomlK2UFjrRLwxpyoNjPxC73sRu9uN4ZH1fLWIrzXizYxZC1WB5F kdPWchpaf+f6mSCNnBR203yljf0SpoFU4bxvp+mj4oQOPMtsLtPGcDT4drD0ZMBdddOH o7pw== X-Gm-Message-State: APzg51D4v5QYkwAwHZIH30YWOv9S7ceacgMGR4oHoAP4Ku4gmICHX6fQ 65jlhblPuMfUWezA4YF7dCIdnA== X-Received: by 2002:a65:5284:: with SMTP id y4-v6mr32790902pgp.283.1537395644376; Wed, 19 Sep 2018 15:20:44 -0700 (PDT) Received: from localhost ([209.121.128.187]) by smtp.gmail.com with ESMTPSA id f13-v6sm21489306pgq.63.2018.09.19.15.20.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Sep 2018 15:20:43 -0700 (PDT) From: Viresh Kumar To: Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: Viresh Kumar , Rafael Wysocki , linux-pm@vger.kernel.org, Vincent Guittot , "4 . 18" , Niklas Cassel , linux-kernel@vger.kernel.org Subject: [PATCH V2 01/12] OPP: Free OPP table properly on performance state irregularities Date: Wed, 19 Sep 2018 15:20:20 -0700 Message-Id: <2fbb8670b4ff4454f1c0de510f788d737edc4b90.1537394233.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The OPP table was freed, but not the individual OPPs which is done from _dev_pm_opp_remove_table(). Fix it by calling _dev_pm_opp_remove_table() as well. Cc: 4.18 # v4.18 Fixes: 3ba98324e81a ("PM / OPP: Get performance state using genpd helper") Tested-by: Niklas Cassel Signed-off-by: Viresh Kumar --- drivers/opp/of.c | 1 + 1 file changed, 1 insertion(+) -- 2.14.1 diff --git a/drivers/opp/of.c b/drivers/opp/of.c index 7af0ddec936b..20988c426650 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -425,6 +425,7 @@ static int _of_add_opp_table_v2(struct device *dev, struct device_node *opp_np) dev_err(dev, "Not all nodes have performance state set (%d: %d)\n", count, pstate_count); ret = -ENOENT; + _dev_pm_opp_remove_table(opp_table, dev, false); goto put_opp_table; }