From patchwork Mon Jan 21 09:42:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 156191 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp6178004jaa; Mon, 21 Jan 2019 01:43:34 -0800 (PST) X-Google-Smtp-Source: ALg8bN5/5anQjs9DhQm0J1HTLqU0v8svCUtYMQRhDaUkLHXSTdBnheFxX06AWPLSPUqClYKu/iR0 X-Received: by 2002:a62:3adc:: with SMTP id v89mr28627578pfj.109.1548063814524; Mon, 21 Jan 2019 01:43:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548063814; cv=none; d=google.com; s=arc-20160816; b=JAl2N7t4S1lYpbxi5V7aLY5dRxMa8kXvXfxCHYB2LcArQJPsIhWAy3WlG+pp2E/+mD nAtECrE/sSGhcC7B3AKJJtJJfFd1TtityFVU3wA/54b5d8hyiL4OQ5BO6bBHOiK1nV7+ Z1kuSAtbBKPFGCPlxe5yZpMeN+6FeDP0Qp3Klo/hfJsvjSBPmray3UkbPYZFMPe4sayh ZyKs3KfejSCbjQYVsGLedcy9KYzLyu9XxnJv/l0qL/3LPy9zrggp4dM70KtsjhLz0sHq jKxbkmD5tEFy+SLWcPE1aq6T3rbMBp1zE+mPyq6db0PD3ZxtYtcNj/5Ml6eV/unvZNhH r8qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=/iO1px23azz4XYlqPGK4I0M/7XGc7/WM1npHE+nRfKQ=; b=IAUFA/RSrk/x7npcgqYSQxfVpl6UqSThI4+ZtUeqDkh434cCEs4du7MCwAj9GMPyZ0 eo4Y/MHlBDj6+tMv48emNClikmQyrITwHFV24Rvj/V56IaIcqtbe0xM4vQSrrGY958cK 8viocTNrpZDlMwE/JSzrJadksWDL/eTVUwokYlW+L4vRBz/dvBn/gJJLEAUJe/Vzw0ek iKRkPj5eYsgYdbps1mduua7p/N/NtyYBpjSgex3RWswurJKBbaA6j3C6mK+oVSpXAzRq IytViROxknkLPqn5WRSV/OhBxE1CvhKTtUUlErexdkAUp7qtPOp5zkyVM1Pr2IXoYn+M l/Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q5qZut8L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h5si12320577pfg.233.2019.01.21.01.43.34; Mon, 21 Jan 2019 01:43:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q5qZut8L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728388AbfAUJnc (ORCPT + 24 others); Mon, 21 Jan 2019 04:43:32 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45712 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728264AbfAUJna (ORCPT ); Mon, 21 Jan 2019 04:43:30 -0500 Received: by mail-wr1-f66.google.com with SMTP id t6so22420026wrr.12 for ; Mon, 21 Jan 2019 01:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=/iO1px23azz4XYlqPGK4I0M/7XGc7/WM1npHE+nRfKQ=; b=Q5qZut8Lgm+vBQ73S0qqM8ppV+bIgxmc+vcYzE971tIRrk72Vd3G/jhIEKcRSWs9rC tTPt7FjACaJfomCX3gvrmn4yZBbJtmJd4BswDHbvFuhyBdHL6gC3WX/bWQ6hYw44J5uo qgkDJb7tGyafICJ1phnejx+7AJPBr2E4EEr8M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=/iO1px23azz4XYlqPGK4I0M/7XGc7/WM1npHE+nRfKQ=; b=ns2uwOB/ziC3cTjzq6anPYqDjTosd2cx5OA/AucSrgX311ubR0LOGLHNzx5N33GYKU z/Ypzh5t34r5YF04ar3gHkwNcKCrq/6m1Tgx2IryYnovCmnA/QUkV3zBwrcplqycK/2w nfq1I0DDlEOjRaLbjV4DfYU7pFEJ1WVsJnSPkhfcoaUbxImFmcuOoriP9Qq+q0FRj5mR UrqXdOshrULZam3QMGc5lcxcAnD/HWAZUhT7Xji3SPeU3j5cuxZz6ZBbOy+owDI4Heo9 7k0Bb2+ZbOWba2RWGVzuatOfY3O7gPpLJ7auS5cQLy3d3fbJvjd/f2EL5iTbVd9OqvUm /BjQ== X-Gm-Message-State: AJcUukdiBEPFPNm4kKj/qNZc0tnl1ufP271eJM9Ag5KDexkOIUEEMTx8 ymR51RTzvg/nBDC/csHVn3NtOQh2Ws8= X-Received: by 2002:adf:ce86:: with SMTP id r6mr28491308wrn.257.1548063808552; Mon, 21 Jan 2019 01:43:28 -0800 (PST) Received: from localhost ([49.248.61.1]) by smtp.gmail.com with ESMTPSA id t76sm52767896wme.33.2019.01.21.01.43.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 01:43:27 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, edubezval@gmail.com, swboyd@chromium.org, Amit Daniel Kachhap , Viresh Kumar , Zhang Rui , Daniel Lezcano , linux-pm@vger.kernel.org Subject: [PATCH v1 2/2] thermal: cpu_cooling: Clarify error message Date: Mon, 21 Jan 2019 15:12:23 +0530 Message-Id: <3812a31a821981eb36858852d2f66c018c8fa0d4.1548063429.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make it clear that it is a failure if the cpufreq driver was unable to register as a cooling device. Makes it easier to find in logs and grepping for words like fail, err, warn. Signed-off-by: Amit Kucheria Acked-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index dfd23245f778..6fff16113628 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -774,7 +774,7 @@ of_cpufreq_cooling_register(struct cpufreq_policy *policy) cdev = __cpufreq_cooling_register(np, policy, capacitance); if (IS_ERR(cdev)) { - pr_err("cpu_cooling: cpu%d is not running as cooling device: %ld\n", + pr_err("cpu_cooling: cpu%d failed to register as cooling device: %ld\n", policy->cpu, PTR_ERR(cdev)); cdev = NULL; }