From patchwork Sat Sep 29 05:49:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 147818 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp1575296lji; Fri, 28 Sep 2018 22:50:15 -0700 (PDT) X-Google-Smtp-Source: ACcGV60+1j9o59FzicIoN1+NmI+NohZRyT5ksG7q8wwb9ptyQLXegg7JsIzoyxKTVvXp4c/N8kTN X-Received: by 2002:a63:81c8:: with SMTP id t191-v6mr1557394pgd.399.1538200215058; Fri, 28 Sep 2018 22:50:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538200215; cv=none; d=google.com; s=arc-20160816; b=BQWw1jNg+ZOfJkbkZGhsoB9mZM4MjcBLNW2LkJC+aQPmjAFnwaYch/esLdG/k3inRv KqfeTLiEDbYrGlpwth8rw3ccvntvvx2rxX3Deo9w3phGfEZriWsDgeM59nrbfHTFDRDA dOjvDm1bnJVWic6tvNXhR4A7m/Q/jflkltIwO5T6jHcOh7CRIMpM0t8A1C+3dxp5UtWX TChUhUrlD+fXVY8oRBNOJM35BcdVFCzgn4veQYtjbhaDt6QJLJFA82HGUfG7RY8AMFUv ol5VVUag4rjifcrpYvT58jTJ1ieOYikWIOt1UmUMf5fx9G22q/bcV+BPq4XTcyYYmz6Z EoTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=VKu6Lyuuq1HCg2vjK0SKqBKedEZKBAaQkFejaBLFPf0=; b=BsBkfjweU9CZYdiXCiuYTuzpAy/8pRKDDGopBGCSG6emPixkDkZMZcr+0U7ctRsJ9/ WvtmKWqpAJBV+3GfbzUKlCr0YiVqIHB7+mEcioq4VeeKHSZEg/+9dC0VlCuPT1Bt3JVk sNtwr1U1jyvkc1Btx4gE/M/Q4Fs3P/pfug1jUQgLQHnkUsgcncNm7iM6vb+BSorl8Pbi nHGexm3H4fRQSuL0O/tvVnikPKk+jWaa4nNIkii8do/NQIuzoKsqxkahTehD1HNjBb7v XSKGzocJgEcm0BD9J48I0jd0/nloIhDZTnRovF1Wnn8O6uKlatRNKMyA5+bj29GiNjK5 ZxOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Qb2H0IiX; spf=pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=dmaengine-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q10-v6si6576963pgl.522.2018.09.28.22.50.14; Fri, 28 Sep 2018 22:50:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Qb2H0IiX; spf=pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=dmaengine-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727528AbeI2MRQ (ORCPT + 3 others); Sat, 29 Sep 2018 08:17:16 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:45380 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727393AbeI2MRQ (ORCPT ); Sat, 29 Sep 2018 08:17:16 -0400 Received: by mail-pg1-f193.google.com with SMTP id t70-v6so5864954pgd.12 for ; Fri, 28 Sep 2018 22:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=VKu6Lyuuq1HCg2vjK0SKqBKedEZKBAaQkFejaBLFPf0=; b=Qb2H0IiXPCuD8odQfq1Yamo/SKGFNg2b7kL6xEAWg3+elPiIo4YbrXHFPwc3cSSSfb q5M3wEb87m24TQLVuaaEphVnaC/QLNnL+kolsOklPoVk6MvA7pYqVwOf67gY4YrNAfoy rUtJiy++oR54JMpkDsSVi0K12BLUvfCetQB+I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=VKu6Lyuuq1HCg2vjK0SKqBKedEZKBAaQkFejaBLFPf0=; b=cvGaIt7BMhxLBuWzSH14LnhsnbonTo4kxc4AUqw1RbgGU15KqoHDUl/OGOkwDl8PnB nhHD7l+gPHXXjZCfhQZ+irUVcyxlv56GKDivTaEcX2A8jWgagQ8TV+/5Qn1yl+H8A+Bq KRQ3cici5EL3lyTzwGvHBwdyO5pvbtGNqh9W28J0AphHwnP4ARo86NYa0jBeLopZB64K BobQ4cAQZ2pAeZuALzvE0cJMaHk8cmKoWh0pLz6uUUHzC9rpugUKRz5J9T7bosnIds97 xlXQf3MN1sFHT6WIp4VOFsXI28kc3L9x85XWV4pJ3GatewqW94j8m3dViRpH9mmfT2dq GgdA== X-Gm-Message-State: ABuFfoivi71thg+ipDq7qXiVxJS9IuyTgqieAEHmebuMZTh0rlswoXZk gF4xiNSBP2zBzFCzPQxP5AGLTw== X-Received: by 2002:a62:c42:: with SMTP id u63-v6mr1737797pfi.43.1538200212273; Fri, 28 Sep 2018 22:50:12 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id i80-v6sm11118049pfi.87.2018.09.28.22.50.09 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 28 Sep 2018 22:50:11 -0700 (PDT) From: Baolin Wang To: dan.j.williams@intel.com, vkoul@kernel.org, eric.long@spreadtrum.com Cc: broonie@kernel.org, baolin.wang@linaro.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] dmaengine: sprd: Set cur_desc as NULL when free or terminate one dma channel Date: Sat, 29 Sep 2018 13:49:02 +0800 Message-Id: <3a42dff7df19aa14d61b95f81ff22a7e16939ecd.1538199697.git.baolin.wang@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: In-Reply-To: References: Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org From: Eric Long It will be failed to start one new transfer if the channel started one none interrupt transfer before, since we will only set the schan->cur_desc as NULL depending on the transfer interrupt now. Thus we should set schan->cur_desc as NULL when free or terminate one dma channel to avoid this issue. Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- drivers/dma/sprd-dma.c | 1 + 1 file changed, 1 insertion(+) -- 1.7.9.5 diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index e6a74dc..1b39661 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -439,6 +439,7 @@ static void sprd_dma_stop(struct sprd_dma_chn *schan) sprd_dma_stop_and_disable(schan); sprd_dma_unset_uid(schan); sprd_dma_clear_int(schan); + schan->cur_desc = NULL; } static bool sprd_dma_check_trans_done(struct sprd_dma_desc *sdesc,