From patchwork Fri Mar 17 05:49:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 95406 Delivered-To: patch@linaro.org Received: by 10.140.89.134 with SMTP id v6csp156174qgd; Thu, 16 Mar 2017 22:51:27 -0700 (PDT) X-Received: by 10.98.202.195 with SMTP id y64mr14688289pfk.225.1489729887845; Thu, 16 Mar 2017 22:51:27 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11si7514209pgo.307.2017.03.16.22.51.27; Thu, 16 Mar 2017 22:51:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751043AbdCQFvO (ORCPT + 11 others); Fri, 17 Mar 2017 01:51:14 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:32859 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbdCQFvN (ORCPT ); Fri, 17 Mar 2017 01:51:13 -0400 Received: by mail-pg0-f47.google.com with SMTP id n190so36022789pga.0 for ; Thu, 16 Mar 2017 22:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=ckHyzM2EsO0ENb83v2YDCPNKItJGwYWWljcfOMknPrE=; b=WwRbRV34VeXuV/cnTUwRNObZBlxGLz9XoFYS67oFmDC35CEU2FfIx/JyW30pWjt9hf nMouPI1fbykZCdTsrU2OFIzkiSscIx8JmS6veW/J1JZz5axSKMX4XCTksza0nB8NQBCU 6P/CmlANznJ1AgxuX3ycuiLnJPFNP05pSS2yY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ckHyzM2EsO0ENb83v2YDCPNKItJGwYWWljcfOMknPrE=; b=leWDvJ7dofHLnGAsZ2ogRfdVnloEFmX6Q2OD6ZElSY0Oz/zWEXAfghtws7bW5nu0lT do/GFfWvvA7vS1l4Hu/u+UXjfVvswdlMpanjKp+Xz1fP9nSEbwf4Q7aLeOEcCHjHEQUx BmNSAJRNNa6DL+0k/qFg69ncnTBGsgNYzJ2sHf6uoa6a79Yg1FVDAzSSGGrvDPXGVgIG 0DF+xYyXaxbBk2mzGjFsJX41cVD3YNatv1RQL63VC2ZYHZPgBo6xJ/wIBUt90y4dKCDA l4fLGBbP+qzd2APiYtqPrwRxNog1fHKPZphrpMIZkr1xH1xc8NG+CVofaYb9rNUQTgS5 cMjw== X-Gm-Message-State: AFeK/H0FJoZIwIhX0jAq2KQNu7sN/cwMjdAua3D1d9n66SM0hvvdF4zxLUVLtcjEw+a5AUJT X-Received: by 10.84.229.137 with SMTP id c9mr17585346plk.41.1489729771946; Thu, 16 Mar 2017 22:49:31 -0700 (PDT) Received: from localhost ([122.171.239.200]) by smtp.gmail.com with ESMTPSA id c64sm1649395pfc.83.2017.03.16.22.49.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Mar 2017 22:49:31 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , Viresh Kumar Subject: [PATCH] PM / Domain: remove conditional from error case Date: Fri, 17 Mar 2017 11:19:21 +0530 Message-Id: <4e38240a7a65b5a7de90d4a0feb2dac277024aa6.1489729740.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.12.0.432.g71c3a4f4ba37 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no point running the conditional 'if' statement if the genpd isn't present. Signed-off-by: Viresh Kumar --- drivers/base/power/domain.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.12.0.432.g71c3a4f4ba37 diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 202effbebfd1..03dd7a61f08a 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -1789,12 +1789,12 @@ int of_genpd_add_provider_simple(struct device_node *np, mutex_lock(&gpd_list_lock); - if (pm_genpd_present(genpd)) + if (pm_genpd_present(genpd)) { ret = genpd_add_provider(np, genpd_xlate_simple, genpd); - - if (!ret) { - genpd->provider = &np->fwnode; - genpd->has_provider = true; + if (!ret) { + genpd->provider = &np->fwnode; + genpd->has_provider = true; + } } mutex_unlock(&gpd_list_lock);