From patchwork Fri Sep 5 09:16:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guodong Xu X-Patchwork-Id: 36787 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f199.google.com (mail-pd0-f199.google.com [209.85.192.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 90639202E4 for ; Fri, 5 Sep 2014 09:17:36 +0000 (UTC) Received: by mail-pd0-f199.google.com with SMTP id v10sf8880533pde.10 for ; Fri, 05 Sep 2014 02:17:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type:content-transfer-encoding; bh=22o0gWkZTgjisqo3U9FkU+Re8cWD8p4FKcOGgNjEP0Q=; b=QJ9O36gkGlaSjFmiJjqzxBPPaJc3tEXi6yugNYbXXJtRF+CHRSXUl+dm3vSZwxHKzP vg6Ln4iYv4EdcA22oizyIb9F0765ozrLE0dk3X9V0QG8bCZKPid19FCeYxYuE0fe2/gF ThrXAem4XzdfX7m2VWLuBgvV0VfDuEVRwAKllHArCVJbGC/em2S1WVl/NOvaljpA3QRo IXsI3t5wnVV+3+p6bB9JerdY9iCnFkB9EEosTurf+9xxe25e5aEaXwhWPvirDX2ufHK5 df0YY1LjPXp1YXGFwjjZJU+hJW1uH/jLIHuBD3sYrfuic3w3hU5YWwGp/QQFKlqMZYsD V0sg== X-Gm-Message-State: ALoCoQmB8J6lrZpsQ2gvEkyvRGma4QUxJunkO9Cyeue/0oAYlctJsZvLTZi0By3SsJNLWajBaUu+ X-Received: by 10.66.66.3 with SMTP id b3mr5938521pat.6.1409908648612; Fri, 05 Sep 2014 02:17:28 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.27.242 with SMTP id 105ls670323qgx.17.gmail; Fri, 05 Sep 2014 02:17:28 -0700 (PDT) X-Received: by 10.220.95.132 with SMTP id d4mr437558vcn.33.1409908648475; Fri, 05 Sep 2014 02:17:28 -0700 (PDT) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id c6si218906vcq.82.2014.09.05.02.17.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Sep 2014 02:17:28 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id im17so11890442vcb.41 for ; Fri, 05 Sep 2014 02:17:28 -0700 (PDT) X-Received: by 10.220.114.5 with SMTP id c5mr9216806vcq.28.1409908648365; Fri, 05 Sep 2014 02:17:28 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp53599vcb; Fri, 5 Sep 2014 02:17:27 -0700 (PDT) X-Received: by 10.66.180.98 with SMTP id dn2mr16717731pac.83.1409908647467; Fri, 05 Sep 2014 02:17:27 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pw4si2800998pac.91.2014.09.05.02.17.24 for ; Fri, 05 Sep 2014 02:17:26 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756431AbaIEJRG (ORCPT + 26 others); Fri, 5 Sep 2014 05:17:06 -0400 Received: from mail-ie0-f171.google.com ([209.85.223.171]:63782 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756363AbaIEJRE (ORCPT ); Fri, 5 Sep 2014 05:17:04 -0400 Received: by mail-ie0-f171.google.com with SMTP id rp18so13442286iec.16 for ; Fri, 05 Sep 2014 02:17:03 -0700 (PDT) X-Received: by 10.70.42.135 with SMTP id o7mr18948025pdl.141.1409908622071; Fri, 05 Sep 2014 02:17:02 -0700 (PDT) Received: from [10.0.0.27] ([119.9.85.21]) by mx.google.com with ESMTPSA id sp2sm1265842pbc.23.2014.09.05.02.16.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Sep 2014 02:17:01 -0700 (PDT) Message-ID: <54097F87.1030009@linaro.org> Date: Fri, 05 Sep 2014 17:16:55 +0800 From: Guodong Xu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Axel Lin , Mark Brown , Liam Girdwood CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] regulator: hi6421: Fix misleading comment References: <1409879666.5208.2.camel@phoenix> In-Reply-To: <1409879666.5208.2.camel@phoenix> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: guodong.xu@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Thanks. Could you also change the comments in macro defines, like here: Thanks. Best regards, Guodong Xu On 09/05/2014 09:14 AM, Axel Lin wrote: > Signed-off-by: Axel Lin > --- > drivers/regulator/hi6421-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/hi6421-regulator.c b/drivers/regulator/hi6421-regulator.c > index e389920..a8c362c 100644 > --- a/drivers/regulator/hi6421-regulator.c > +++ b/drivers/regulator/hi6421-regulator.c > @@ -37,7 +37,7 @@ struct hi6421_regulator_pdata { > * struct hi6421_regulator_info - hi6421 regulator information > * @desc: regulator description > * @mode_mask: ECO mode bitmask of LDOs; for BUCKs, this masks sleep > - * @eco_microamp: eco mode load upper limit (in mA), valid for LDOs only > + * @eco_microamp: eco mode load upper limit (in uA), valid for LDOs only > */ > struct hi6421_regulator_info { > struct regulator_desc desc; > --- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/regulator/hi6421-regulator.c b/drivers/regulator/hi6421-regulator.c index e389920..156d0d1 100644 --- a/drivers/regulator/hi6421-regulator.c +++ b/drivers/regulator/hi6421-regulator.c @@ -37,7 +37,7 @@ struct hi6421_regulator_pdata { * struct hi6421_regulator_info - hi6421 regulator information * @desc: regulator description * @mode_mask: ECO mode bitmask of LDOs; for BUCKs, this masks sleep - * @eco_microamp: eco mode load upper limit (in mA), valid for LDOs only + * @eco_microamp: eco mode load upper limit (in uA), valid for LDOs only */ struct hi6421_regulator_info { struct regulator_desc desc; @@ -164,7 +164,7 @@ static const struct regulator_ops hi6421_buck345_ops; * emask - enable mask * odelay - off/on delay time in uS * ecomask - eco mode mask - * ecoamp - eco mode load uppler limit in mA + * ecoamp - eco mode load uppler limit in uA */ #define HI6421_LDO(_id, v_table, vreg, vmask, ereg, emask, \ odelay, ecomask, ecoamp) \ @@ -200,7 +200,7 @@ static const struct regulator_ops hi6421_buck345_ops; * emask - enable mask * odelay - off/on delay time in uS * ecomask - eco mode mask - * ecoamp - eco mode load uppler limit in mA + * ecoamp - eco mode load uppler limit in uA */ #define HI6421_LDO_LINEAR(_id, _min_uV, n_volt, vstep, vreg, vmask, \ ereg, emask, odelay, ecomask, ecoamp) \ @@ -237,7 +237,7 @@ static const struct regulator_ops hi6421_buck345_ops; * emask - enable mask * odelay - off/on delay time in uS * ecomask - eco mode mask - * ecoamp - eco mode load uppler limit in mA + * ecoamp - eco mode load uppler limit in uA */ #define HI6421_LDO_LINEAR_RANGE(_id, n_volt, volt_ranges, vreg, vmask, \ ereg, emask, odelay, ecomask, ecoamp) \