From patchwork Mon Feb 23 17:48:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 44908 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f70.google.com (mail-wg0-f70.google.com [74.125.82.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id EECA321562 for ; Mon, 23 Feb 2015 17:49:02 +0000 (UTC) Received: by wggy19 with SMTP id y19sf173696wgg.1 for ; Mon, 23 Feb 2015 09:49:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:subject:references:in-reply-to:content-type :content-transfer-encoding:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=4pK/mw2GRqjUEsvkFL56LQTuHAJIUWY3jksP7XAgK20=; b=f6w/u1z5IzGCDyXEbe6JbpNV8YUbzmm0XYeDqj0W3RD9BFFWFzjpl+LW1IMNvxOFeA w/ei6eKDrAT5waQEWdWV+ubvFJBvPhcMp+hnJD3jhwG+9SoOw83V9cQUROJ6ECcUagS3 LShA1L2InsA7FQm8QLGSnstwiNaROQhvosbXF0ZjGZJAv+7EVp/qjnw59wDuA4+GP9qT WyLZe4ZPacjRx8Xny9V70QaL1uhmEc4fwm/gn/EDEJJYYhenTjRO52uR5tPcorKR7s++ Dts5NIz0i4hEbNd/esh4lc7wv+34rhXXj31QZug0LJJFKTQHmjMp5X9A7IqPrezzlATG o2JA== X-Gm-Message-State: ALoCoQk0CJYJsiP+Lq1j8YEO/UKUblUIWWMiLdnmg9FsL6tcYLN4+f3m/7/rhNuX+9ObHLPqUrEZ X-Received: by 10.112.174.36 with SMTP id bp4mr1502303lbc.15.1424713742206; Mon, 23 Feb 2015 09:49:02 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.116.9 with SMTP id js9ls593176lab.69.gmail; Mon, 23 Feb 2015 09:49:02 -0800 (PST) X-Received: by 10.152.25.132 with SMTP id c4mr10934041lag.101.1424713742027; Mon, 23 Feb 2015 09:49:02 -0800 (PST) Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com. [209.85.217.169]) by mx.google.com with ESMTPS id f9si5827547lam.60.2015.02.23.09.49.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 09:49:02 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.169 as permitted sender) client-ip=209.85.217.169; Received: by lbiz11 with SMTP id z11so20080014lbi.8 for ; Mon, 23 Feb 2015 09:49:01 -0800 (PST) X-Received: by 10.152.87.3 with SMTP id t3mr10949388laz.19.1424713741897; Mon, 23 Feb 2015 09:49:01 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp1415857lbj; Mon, 23 Feb 2015 09:49:01 -0800 (PST) X-Received: by 10.70.96.145 with SMTP id ds17mr15807558pdb.153.1424713739958; Mon, 23 Feb 2015 09:48:59 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id iv4si1462147pbb.65.2015.02.23.09.48.58; Mon, 23 Feb 2015 09:48:59 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbbBWRsy (ORCPT + 28 others); Mon, 23 Feb 2015 12:48:54 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:45918 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbbBWRsx (ORCPT ); Mon, 23 Feb 2015 12:48:53 -0500 Received: by wgha1 with SMTP id a1so278553wgh.12 for ; Mon, 23 Feb 2015 09:48:52 -0800 (PST) X-Received: by 10.194.176.33 with SMTP id cf1mr23513217wjc.19.1424713730527; Mon, 23 Feb 2015 09:48:50 -0800 (PST) Received: from ?IPv6:2001:41d0:fe90:b800:3cf4:398e:cdd:d309? ([2001:41d0:fe90:b800:3cf4:398e:cdd:d309]) by mx.google.com with ESMTPSA id dj5sm56553750wjb.28.2015.02.23.09.48.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 09:48:49 -0800 (PST) Message-ID: <54EB67FF.5050908@linaro.org> Date: Mon, 23 Feb 2015 18:48:47 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Guenter Roeck , Oleksij Rempel , linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH] clocksource: whitelist asm9260_timer driver for ARM References: <54D9F61E.6040206@roeck-us.net> <1423583876-32758-1-git-send-email-linux@rempel-privat.de> <54E43C96.6060008@roeck-us.net> In-Reply-To: <54E43C96.6060008@roeck-us.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.lezcano@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 02/18/2015 08:17 AM, Guenter Roeck wrote: > On 02/10/2015 07:57 AM, Oleksij Rempel wrote: >> For now it is easier to allow only tested platforms, instead of >> fighting with different platform specific issues. >> >> This patch is fixing compile error on ARCH=SPARC and SPARC64: >> >> Building sparc64:allmodconfig ... failed >> -------------- >> Error log: >> drivers/built-in.o: In function `asm9260_timer_init': >> asm9260_timer.c:(.init.text+0x60d4): undefined reference to >> `of_io_request_and_map' >> >> Tested-by: Guenter Roeck >> Reported-by: Guenter Roeck >> Signed-off-by: Oleksij Rempel > > The problem solved by this patch has affected linux-next > for almost a month, the problem is now in mainline, yet > I have not seen feedback from anyone about it. > > Did the patch get lost, or is there some problem with it ? Hi Guenter, Oleksij, so I reviewed the patch more in detail. The sparc/sparc64 configuration shouldn't select this timer. What do you think about the following patch ? > >> --- >> drivers/clocksource/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index bfaaae4..39d5c11 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -231,7 +231,7 @@ config CLKSRC_MIPS_GIC >> >> config ASM9260_TIMER >> bool "Alphascale ASM9260 timer driver" >> - depends on GENERIC_CLOCKEVENTS >> + depends on GENERIC_CLOCKEVENTS && ARM >> select CLKSRC_MMIO >> select CLKSRC_OF >> default y if MACH_ASM9260 >> > diff --git a/arch/arm/mach-asm9260/Kconfig b/arch/arm/mach-asm9260/Kconfig index 8423be7..5224120 100644 --- a/arch/arm/mach-asm9260/Kconfig +++ b/arch/arm/mach-asm9260/Kconfig @@ -2,5 +2,7 @@ config MACH_ASM9260 bool "Alphascale ASM9260" depends on ARCH_MULTI_V5 select CPU_ARM926T + select ASM9260_TIMER + select GENERIC_CLOCKEVENTS help Support for Alphascale ASM9260 based platform. diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 72a3827..f9c1995 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -60,6 +60,11 @@ config VT8500_TIMER config CADENCE_TTC_TIMER bool +config ASM9260_TIMER + bool + select CLKSRC_MMIO + select CLKSRC_OF + config CLKSRC_NOMADIK_MTU bool depends on (ARCH_NOMADIK || ARCH_U8500) @@ -235,15 +240,4 @@ config CLKSRC_MIPS_GIC bool depends on MIPS_GIC select CLKSRC_OF - -config ASM9260_TIMER - bool "Alphascale ASM9260 timer driver" - depends on GENERIC_CLOCKEVENTS - select CLKSRC_MMIO - select CLKSRC_OF - default y if MACH_ASM9260 - help - This enables build of a clocksource and clockevent driver for - the 32-bit System Timer hardware available on a Alphascale ASM9260. - endmenu