From patchwork Mon May 6 02:19:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 163381 Delivered-To: patch@linaro.org Received: by 2002:a92:3d95:0:0:0:0:0 with SMTP id k21csp1327432ilf; Sun, 5 May 2019 19:19:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqybydsHR6V3/m0aXMfTQMz+oWmtZXayGnmqvRgaPTiwk717O9HrA/jF1ikfUBa9PpPCu9ry X-Received: by 2002:a63:8449:: with SMTP id k70mr28908772pgd.53.1557109195571; Sun, 05 May 2019 19:19:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557109195; cv=none; d=google.com; s=arc-20160816; b=J6uI6ScxpdRV26gkMfcQg4zzCAcCD7uMwEFoCv/nLEyvNEiUSmpwpjpl2Hz2XyH2pS HHAn22E/KM4YoiqJ6N4nD/3HBm+xW93F1HuGMFnFpaElNJIWrLJROyFRlouWhEMAiGXH AzlO04U7T3bzZXkXSX0WyoQYCKEPK6/vOjuTU6/mFl4U928oApQ/tgrE7EUkFuMzmF++ p7gS/ruYJRabFLBFUMu8yWn43sdBUl5OHQGf+IkXekYdfN0ZJ1R/qB1bKKT2SBpKw8+f Vr2xJ+nLm4i2AHAPSKWLMXrMuNjlZsdRwNlNH2Bd9A00y9CPiz39QO6KTgPU4nFRC+h7 B+gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature:dkim-filter; bh=Vya/13bsWcbegIjw+dGbayHmf3WM/WFP+czE83gdy80=; b=yM8ecrYwjK+Lois/jcHVqnI8SIUPjKmdaO4hPmQGNM4uZMqjHTELDY+YjQM2AyeuWw kWFcUc/RoHht2zvshbIFkzhJHYZgD7vn7qf/3slLsg4eQ2vxEY24IIsoEGs0QnETyGc6 yJgBoaVgvzjUEmuKXfvIXT+89hTYItvTUqybI2ZVxmlygGRQLs/yxLmmxeWn412SWb1f AgV7glzZZ0wLO+l/dprOG1pS8WX/pRw1zhDWgIbfd7NF6LmvM7zVBjaJ35HdwQ9RAvcG IEEvr1e6udCLLLVwzdPY5hWYgBO+uIC1qaTh8NEvYcYx+9XUrx7HMQkPostUNS5VQhNg z2bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=vob8ntYV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y4si12016685pgv.154.2019.05.05.19.19.54; Sun, 05 May 2019 19:19:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=vob8ntYV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726037AbfEFCTr (ORCPT + 30 others); Sun, 5 May 2019 22:19:47 -0400 Received: from conssluserg-05.nifty.com ([210.131.2.90]:57598 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbfEFCTr (ORCPT ); Sun, 5 May 2019 22:19:47 -0400 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) (authenticated) by conssluserg-05.nifty.com with ESMTP id x462Jdw5003248; Mon, 6 May 2019 11:19:40 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com x462Jdw5003248 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1557109180; bh=Vya/13bsWcbegIjw+dGbayHmf3WM/WFP+czE83gdy80=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=vob8ntYVYqlBp6KqtMsWpwPA+xJsOkwSq6oXdeMUhqTjf2lOmAmyUZFv7ssxQ+pL2 SdAczp/EDK7W1WM2IDmzF5nKONgyZxJbc818rGuA0nfHgnDu7v8HlTks6LOefqFSzR cpUd/w7OGCIGpNTmV/40bA8NMXqyP+ZYMsSjpuLjKbAPF/F1Bz2ZiKKGEIXynNV4Ey fTzKbHIigMzufgzmBucoNXbJ5GyqPCyd7Y8uHhSiA+2mLizDXENLp5cxutyi8B46Zv vUaYZGoP+AhgMTMtE9KZf0oiWmetCIolMYWytypJ7p6l3KpPOEAyFauqmbRnVmsDX4 7E6zBsZZvCzrQ== X-Nifty-SrcIP: [209.85.222.47] Received: by mail-ua1-f47.google.com with SMTP id 49so701298uas.0; Sun, 05 May 2019 19:19:39 -0700 (PDT) X-Gm-Message-State: APjAAAV9BlHi2h6nU5YWVYKKOBy73C/uIyWCjwTbd4MbWkfe66hmIbKh ZXhN+VJNGxCSjgzfCJeSlAFfuKVlnTskQeJM0Rs= X-Received: by 2002:a9f:2d99:: with SMTP id v25mr10412617uaj.25.1557109178802; Sun, 05 May 2019 19:19:38 -0700 (PDT) MIME-Version: 1.0 References: <20190506094609.08e930f2@canb.auug.org.au> In-Reply-To: <20190506094609.08e930f2@canb.auug.org.au> From: Masahiro Yamada Date: Mon, 6 May 2019 11:19:02 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Fwd: linux-next: build failure after merge of the kbuild tree To: Paul Gortmaker Cc: Stephen Rothwell , Linux Kernel Mailing List , Linux-Next Mailing List Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, In today's linux-next build testing, more "make ... explicitly non-modular" candidates showed up. arch/arm/plat-omap/dma.c drivers/clocksource/timer-ti-dm.c drivers/mfd/omap-usb-host.c drivers/mfd/omap-usb-tll.c Would you send patches? I think EXPORT_SYMBOL_GPL() in omap-usb-tll.c are also unnecessary. Thanks. ---------- Forwarded message --------- From: Stephen Rothwell Date: Mon, May 6, 2019 at 8:51 AM Subject: linux-next: build failure after merge of the kbuild tree To: Masahiro Yamada Cc: Linux Next Mailing List , Linux Kernel Mailing List , Alexey Gladkov , Keshava Munegowda , Samuel Ortiz Hi Masahiro, After merging the kbuild tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from include/linux/module.h:18, from drivers/mfd/omap-usb-tll.c:21: drivers/mfd/omap-usb-tll.c:462:26: error: expected ',' or ';' before 'USBHS_DRIVER_NAME' MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); ^~~~~~~~~~~~~~~~~ include/linux/moduleparam.h:26:47: note: in definition of macro '__MODULE_INFO' = __MODULE_INFO_PREFIX __stringify(tag) "=" info ^~~~ include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO' #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias) ^~~~~~~~~~~ drivers/mfd/omap-usb-tll.c:462:1: note: in expansion of macro 'MODULE_ALIAS' MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); ^~~~~~~~~~~~ Caused by commit 6a26793a7891 ("moduleparam: Save information about built-in modules in separate file") USBHS_DRIVER_NAME is not defined and this kbuild tree change has exposed it. It has been this way since commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver") >From v3.7-rc1 in 2012. I have applied the following patch for today. From: Stephen Rothwell Date: Mon, 6 May 2019 09:39:14 +1000 Subject: [PATCH] mfd: omap: remove unused MODULE_ALIAS from omap-usb-tll.c USBHS_DRIVER_NAME has never been defined, so this cannot have ever been used. Signed-off-by: Stephen Rothwell --- drivers/mfd/omap-usb-tll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 -- Cheers, Stephen Rothwell -- Best Regards Masahiro Yamada diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c index 446713dbee27..1cc8937e8bec 100644 --- a/drivers/mfd/omap-usb-tll.c +++ b/drivers/mfd/omap-usb-tll.c @@ -459,7 +459,7 @@ EXPORT_SYMBOL_GPL(omap_tll_disable); MODULE_AUTHOR("Keshava Munegowda "); MODULE_AUTHOR("Roger Quadros "); -MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); +// MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");