From patchwork Thu Apr 23 20:10:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 47476 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5317420553 for ; Thu, 23 Apr 2015 20:10:34 +0000 (UTC) Received: by wgin8 with SMTP id n8sf7121589wgi.0 for ; Thu, 23 Apr 2015 13:10:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:content-type:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe; bh=Oth3uNnDAk2451hPFzpFmlw5NUJ0gXtaWPJpelx4V6Q=; b=W2gFpqCvY6j0DCq0RasMiyDRM4KmCDwQbQbAdqz9aPVsR9Ochj6P0qO7iB4Jwpbhh/ WmM9DJMv2cUI70SYh6BZgTg4Q7Gr75s6i8zZ24MnszJSOvyGGR1RxYkY5ESxnBg+dXdP sqkkPCzEwX73zpz3QoYX5s5F9SzNB6wRGX5Dpi0uEcZ6uFme33icXQhMFC0tpu3/amIo L3FgR0xy0cY5bSg3Yfgm54Acw+xn835ZSEHG/0X3HYpIasNpYvWCfRoGa0rDuLsBHJv8 RWhrYZojvUtVpwCLzOYqkhNsU61wNtp7Wjvy4ekmVWFfgInoIedrKh1tjp2TljWKwLgf AXCw== X-Gm-Message-State: ALoCoQlMfWOCvVRol3FVDwmqMkRd+NddlhEmMfGQCjLxTaytPU/KP/UJ7NwSLWYlMJAbfKRCmHeM X-Received: by 10.194.121.67 with SMTP id li3mr2227371wjb.3.1429819832569; Thu, 23 Apr 2015 13:10:32 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.45.6 with SMTP id i6ls406889lam.10.gmail; Thu, 23 Apr 2015 13:10:32 -0700 (PDT) X-Received: by 10.152.36.227 with SMTP id t3mr4103114laj.12.1429819832412; Thu, 23 Apr 2015 13:10:32 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com. [209.85.217.181]) by mx.google.com with ESMTPS id c5si6688723lag.135.2015.04.23.13.10.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2015 13:10:32 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) client-ip=209.85.217.181; Received: by lbbzk7 with SMTP id zk7so21739486lbb.0 for ; Thu, 23 Apr 2015 13:10:32 -0700 (PDT) X-Received: by 10.112.199.133 with SMTP id jk5mr4147786lbc.32.1429819831960; Thu, 23 Apr 2015 13:10:31 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp785413lbt; Thu, 23 Apr 2015 13:10:31 -0700 (PDT) X-Received: by 10.67.4.230 with SMTP id ch6mr8380830pad.137.1429819830213; Thu, 23 Apr 2015 13:10:30 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x16si14070588pdi.8.2015.04.23.13.10.29 for ; Thu, 23 Apr 2015 13:10:30 -0700 (PDT) Received-SPF: none (google.com: linux-crypto-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758318AbbDWUK2 (ORCPT ); Thu, 23 Apr 2015 16:10:28 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:36739 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758310AbbDWUK0 (ORCPT ); Thu, 23 Apr 2015 16:10:26 -0400 Received: by iebrs15 with SMTP id rs15so69495027ieb.3 for ; Thu, 23 Apr 2015 13:10:26 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.107.168.79 with SMTP id r76mr6316734ioe.47.1429819826095; Thu, 23 Apr 2015 13:10:26 -0700 (PDT) Received: by 10.36.125.5 with HTTP; Thu, 23 Apr 2015 13:10:26 -0700 (PDT) In-Reply-To: References: <20140804130339.GA1178@gondor.apana.org.au> <20141007131826.GA29688@gondor.apana.org.au> <20141211125119.GA12380@gondor.apana.org.au> <20150214094328.GA7457@gondor.apana.org.au> <20150415033951.GA1406@gondor.apana.org.au> <20150416024252.GA11558@gondor.apana.org.au> <20150416030713.GA11668@gondor.apana.org.au> Date: Thu, 23 Apr 2015 22:10:26 +0200 Message-ID: Subject: Re: Crypto Update for 4.1 From: Ard Biesheuvel To: Bobby Powers Cc: Linus Torvalds , Herbert Xu , Stephan Mueller , "David S. Miller" , Linux Kernel Mailing List , Linux Crypto Mailing List Sender: linux-crypto-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ard.biesheuvel@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 23 April 2015 at 21:27, Bobby Powers wrote: > Hello, > > Linus Torvalds wrote: >> Ok, this patch seems to fix it for me, so I undid my revert that I >> hadn't pushed out yet, and pushed out this instead. > > Commit e68410ebf62676dfb93aafff7c55b76644f37072 in Linus's tree from > this crpyto update (crypto: x86/sha512_ssse3 - move SHA-384/512 SSSE3 > implementation to base layer) causes a GPF on boot in > sha512_ssse3_finup for me on a Broadwell i7-5600U, rendering the > kernel unbootable. > > Reverting that commit enables me to boot. I don't know enough about > the code to comment. Config is attached, and I can provide a photo of > the reported Call Trace if thats helpful. It is quite reproducible > for me. > Hello Bobby, Would you be able to check whether the following patch fixes the crash? If not, please share the call trace and the content of /proc/cpuinfo Regards, Ard. --- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/crypto/sha512-avx2-asm.S b/arch/x86/crypto/sha512-avx2-asm.S index a4771dcd1fcf..1f20b35d8573 100644 --- a/arch/x86/crypto/sha512-avx2-asm.S +++ b/arch/x86/crypto/sha512-avx2-asm.S @@ -79,7 +79,7 @@ NUM_BLKS = %rdx c = %rcx d = %r8 e = %rdx -y3 = %rdi +y3 = %rsi TBL = %rbp