From patchwork Fri Jul 28 06:46:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 108872 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp31413qge; Thu, 27 Jul 2017 23:48:12 -0700 (PDT) X-Received: by 10.84.241.207 with SMTP id t15mr7222820plm.347.1501224492289; Thu, 27 Jul 2017 23:48:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501224492; cv=none; d=google.com; s=arc-20160816; b=ZfhM1Xamncw9P8pgobKztAFpdk+qATpu4fwAteOOpu5JZvuXIuCn/cQdFJhaXRWqVn TvYCoAY/8mhnPv1drJBwMRzkavdXEc4ROI8hYwDldPznnhTDEMUVJa8+NkLE0DDhtWYI E/0HGefcgntO2KNxhxXg2P7BQPf7ghd23Gbtfy494qHsbNgcWPS74v8TuT9Pp/z++wTt VUUFh2ELCos0YMU0CxPskVOlh0moVNerYW5L3A+BU1utpOU7y6hI7/vOe8SGXwiq8zlI bq8UO+A8T8FTmM1qCnNHBGowmMTgjF7/57hR/VCTc9QheOk9Dc0YclifQyDPv+aFb+OI a04A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=pXPIZ8LBfCHSI9VidJD+t0/ReHxsMA1X/FM5BhkTpxA=; b=ETV3n/ooecSPma5RWIDqFTuZqdjxaVwk+fv9R0t1o1K5lK6g8XPU/ADo6wuT84YZ6T IW8rV4SwUexgQ65E4PwSu6WRWtyJxRNdcYZdwb6QAUbHV+LDaPofl4ItipXPA9ewKNmC Z876ZisD8QBETGLZgm//5PpTK37aAT9xJGVigN50mUn8CYxIbIWZ6AKWDhKzIJSg65zu CBtwe/f6dXocRPGv7Ukr9z964U/gZXCaBaNgYyM+GH0w4x87gXu1kV2LQ2IqrWe4o6a9 pRVPckNJMylelpSDtkgjxSe2vqeyYLkoMCUaj+HptmAlFOYWwCszCTH1j8KSnXErwQv0 /9nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=MxppJz84; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b85si9853717pfc.659.2017.07.27.23.48.11; Thu, 27 Jul 2017 23:48:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=MxppJz84; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751748AbdG1GsH (ORCPT + 26 others); Fri, 28 Jul 2017 02:48:07 -0400 Received: from mail-pg0-f50.google.com ([74.125.83.50]:38742 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751787AbdG1Grw (ORCPT ); Fri, 28 Jul 2017 02:47:52 -0400 Received: by mail-pg0-f50.google.com with SMTP id k190so41965704pgk.5 for ; Thu, 27 Jul 2017 23:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=pXPIZ8LBfCHSI9VidJD+t0/ReHxsMA1X/FM5BhkTpxA=; b=MxppJz84Fczac+cr87LTQzU0hvy9QpTPdU6njeXX/sIheo9ZOsafJNru+BTQqk3mHx 3YNNlKaoBBjzxxvdr9cS9ExyGASx/HBpD0c5Bed+jkMpLUtNHKI7JS47dmrmjry6l/jD MpF8h6KFbTaRA5rbQJw+vR24VOxzXSQkMRa0k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=pXPIZ8LBfCHSI9VidJD+t0/ReHxsMA1X/FM5BhkTpxA=; b=EiDxMudLe1QFSatdLZbdC9qa6XV9Nm9HtsNpSaNGV0kmlqmFK06dsSdihZoXv0FN58 d6JYUq/7uuqa87wBPdOtYvOK619Hn6rHgv8CBORTnOUbcUb17yBye4Q/MWno3ah5Fss/ j7M+nEiSjEmBbChM1prcp0mCAxVZ75pmz8tbC+403m8u+QaWSlwfZ+LZPZu0MqCpykU+ aOLPWn5ABmpt2JaV1z2eDRE9o8VvLQsnuG3uNurdPoid3XFVBkNPU0NK6quzcqEXWkTB WDkmkOUBW+IoEJM5tL85DJhWYOBZX7HbzEkLN/HGKc/Rt3JP2lOdSRdE6T4avLs404D0 7OLA== X-Gm-Message-State: AIVw110QcDRxwuUdTcOkpt4VnSn/FdRH1NzfcKzWGAx/mOpuV0nddRSB nYnUrwQX2uicI7zx X-Received: by 10.98.155.133 with SMTP id e5mr6520573pfk.186.1501224471669; Thu, 27 Jul 2017 23:47:51 -0700 (PDT) Received: from localhost ([122.171.79.89]) by smtp.gmail.com with ESMTPSA id l17sm39411221pfk.146.2017.07.27.23.47.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jul 2017 23:47:51 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Peter Zijlstra , Viresh Kumar Cc: linux-pm@vger.kernel.org, Vincent Guittot , smuckle.linux@gmail.com, juri.lelli@arm.com, Morten.Rasmussen@arm.com, patrick.bellasi@arm.com, eas-dev@lists.linaro.org, skannan@codeaurora.org, joelaf@google.com, linux-kernel@vger.kernel.org Subject: [PATCH V5 2/2] cpufreq: Process remote callbacks from any CPU if the platform permits Date: Fri, 28 Jul 2017 12:16:39 +0530 Message-Id: X-Mailer: git-send-email 2.13.0.71.gd7076ec9c9cb In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On many platforms, CPUs can do DVFS across cpufreq policies. i.e CPU from policy-A can change frequency of CPUs belonging to policy-B. This is quite common in case of ARM platforms where we don't configure any per-cpu register. Add a flag to identify such platforms and update cpufreq_can_do_remote_dvfs() to allow remote callbacks if this flag is set. Also enable the flag for cpufreq-dt driver which is used only on ARM platforms currently. Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq-dt.c | 1 + include/linux/cpufreq.h | 18 ++++++++++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) -- 2.13.0.71.gd7076ec9c9cb diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index fef3c2160691..d83ab94d041a 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -274,6 +274,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) transition_latency = CPUFREQ_ETERNAL; policy->cpuinfo.transition_latency = transition_latency; + policy->dvfs_possible_from_any_cpu = true; return 0; diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index b3b6e8203e82..227cd0f13300 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -127,6 +127,15 @@ struct cpufreq_policy { */ unsigned int transition_delay_us; + /* + * Remote DVFS flag (Not added to the driver structure as we don't want + * to access another structure from scheduler hotpath). + * + * Should be set if CPUs can do DVFS on behalf of other CPUs from + * different cpufreq policies. + */ + bool dvfs_possible_from_any_cpu; + /* Cached frequency lookup from cpufreq_driver_resolve_freq. */ unsigned int cached_target_freq; int cached_resolved_idx; @@ -564,8 +573,13 @@ struct governor_attr { static inline bool cpufreq_can_do_remote_dvfs(struct cpufreq_policy *policy) { - /* Allow remote callbacks only on the CPUs sharing cpufreq policy */ - if (cpumask_test_cpu(smp_processor_id(), policy->cpus)) + /* + * Allow remote callbacks if: + * - dvfs_possible_from_any_cpu flag is set + * - the local and remote CPUs share cpufreq policy + */ + if (policy->dvfs_possible_from_any_cpu || + cpumask_test_cpu(smp_processor_id(), policy->cpus)) return true; return false;