From patchwork Fri Mar 17 06:19:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 95409 Delivered-To: patch@linaro.org Received: by 10.140.89.134 with SMTP id v6csp164071qgd; Thu, 16 Mar 2017 23:20:02 -0700 (PDT) X-Received: by 10.98.101.71 with SMTP id z68mr14306336pfb.25.1489731602538; Thu, 16 Mar 2017 23:20:02 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6si7605448pln.179.2017.03.16.23.20.02; Thu, 16 Mar 2017 23:20:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbdCQGT6 (ORCPT + 12 others); Fri, 17 Mar 2017 02:19:58 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:36676 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbdCQGTz (ORCPT ); Fri, 17 Mar 2017 02:19:55 -0400 Received: by mail-pg0-f51.google.com with SMTP id g2so36181560pge.3 for ; Thu, 16 Mar 2017 23:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=R6UNZB8lpUs0E/DF/qTVG8uRoEFpCAS+V0CI5QOr4tY=; b=EoL4eVYycMZ78kgZJeo7XrQz3QQqbaeGahG6WcSBeIk6R49mT/t/FZgX/x3cTMiS4K A81Mi32m6rBnOduHn4FoY2Osyx5R6xXeChkJHomdCdWK+eNLFCCtZJreHI1acdnZ4rAF sw3L1cigNexjWwA9d93UMfmOIwv0SlKoJp7k0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=R6UNZB8lpUs0E/DF/qTVG8uRoEFpCAS+V0CI5QOr4tY=; b=W/OMYhbAY1sDyHmFM/W/cvMId9JuQe6/RN0rLL6MbzNy/eD3W4feY0d5/47ouN2eaZ FHXD/0x0J0BvGkhcF5HyqgAM7BXhD+XYI9C5WhttBITquMM8UPJZSH4X/WUKqVGWuiE4 rJ8jxA9A1EtV/bqgmB7BQaPekojyra+MxsuHpZAassglG1P3hVWK9RZJKE8LYCp0Q3Zz he5cZyHpVIofox9DmPMzPaneqmjGsX7LcGcsmnCK6uca8K2l+5sASJXS+fyZDNse5ZWf +4SO+RCsQWuPt5ydmW+484iYd/grxu0Q2Br1rMDGVQu01o9TY6A7J66y56Pcz9GkcjsY 6H2A== X-Gm-Message-State: AFeK/H3OU454xM5EivIjKsyOE6a0cLJIRrd+/pLsZ+TkPaRGSnA4wDw+70zdCHNtBGl6ghPu X-Received: by 10.84.194.129 with SMTP id h1mr17386819pld.56.1489731589381; Thu, 16 Mar 2017 23:19:49 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id f21sm14078100pfj.111.2017.03.16.23.19.45 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 16 Mar 2017 23:19:48 -0700 (PDT) From: Baolin Wang To: balbi@kernel.org, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, neilb@suse.com, jun.li@nxp.com, peter.chen@freescale.com, broonie@kernel.org, baolin.wang@linaro.org Subject: [PATCH 2/2] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister Date: Fri, 17 Mar 2017 14:19:21 +0800 Message-Id: X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <479fef31f632df7454225056054c081bb7ef9bf9.1489731114.git.baolin.wang@linaro.org> References: <479fef31f632df7454225056054c081bb7ef9bf9.1489731114.git.baolin.wang@linaro.org> In-Reply-To: <479fef31f632df7454225056054c081bb7ef9bf9.1489731114.git.baolin.wang@linaro.org> References: <479fef31f632df7454225056054c081bb7ef9bf9.1489731114.git.baolin.wang@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since usb phy core has added common code to register or unregister extcon device, then phy-qcom-8x16-usb driver does not need its own code to register/unregister extcon device, then remove them. Signed-off-by: Baolin Wang --- drivers/usb/phy/phy-qcom-8x16-usb.c | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) -- 1.7.9.5 diff --git a/drivers/usb/phy/phy-qcom-8x16-usb.c b/drivers/usb/phy/phy-qcom-8x16-usb.c index fdf6863..b6a83a5 100644 --- a/drivers/usb/phy/phy-qcom-8x16-usb.c +++ b/drivers/usb/phy/phy-qcom-8x16-usb.c @@ -69,9 +69,6 @@ struct phy_8x16 { struct reset_control *phy_reset; - struct extcon_dev *vbus_edev; - struct notifier_block vbus_notify; - struct gpio_desc *switch_gpio; struct notifier_block reboot_notify; }; @@ -131,7 +128,8 @@ static int phy_8x16_vbus_off(struct phy_8x16 *qphy) static int phy_8x16_vbus_notify(struct notifier_block *nb, unsigned long event, void *ptr) { - struct phy_8x16 *qphy = container_of(nb, struct phy_8x16, vbus_notify); + struct usb_phy *usb_phy = container_of(nb, struct usb_phy, vbus_nb); + struct phy_8x16 *qphy = container_of(usb_phy, struct phy_8x16, phy); if (event) phy_8x16_vbus_on(qphy); @@ -187,7 +185,7 @@ static int phy_8x16_init(struct usb_phy *phy) val = ULPI_PWR_OTG_COMP_DISABLE; usb_phy_io_write(phy, val, ULPI_SET(ULPI_PWR_CLK_MNG_REG)); - state = extcon_get_state(qphy->vbus_edev, EXTCON_USB); + state = extcon_get_state(qphy->phy.edev, EXTCON_USB); if (state) phy_8x16_vbus_on(qphy); else @@ -289,15 +287,13 @@ static int phy_8x16_probe(struct platform_device *pdev) phy->io_priv = qphy->regs + HSPHY_ULPI_VIEWPORT; phy->io_ops = &ulpi_viewport_access_ops; phy->type = USB_PHY_TYPE_USB2; + phy->vbus_nb.notifier_call = phy_8x16_vbus_notify; + phy->id_nb.notifier_call = NULL; ret = phy_8x16_read_devicetree(qphy); if (ret < 0) return ret; - qphy->vbus_edev = extcon_get_edev_by_phandle(phy->dev, 0); - if (IS_ERR(qphy->vbus_edev)) - return PTR_ERR(qphy->vbus_edev); - ret = clk_set_rate(qphy->core_clk, INT_MAX); if (ret < 0) dev_dbg(phy->dev, "Can't boost core clock\n"); @@ -315,12 +311,6 @@ static int phy_8x16_probe(struct platform_device *pdev) if (WARN_ON(ret)) goto off_clks; - qphy->vbus_notify.notifier_call = phy_8x16_vbus_notify; - ret = devm_extcon_register_notifier(&pdev->dev, qphy->vbus_edev, - EXTCON_USB, &qphy->vbus_notify); - if (ret < 0) - goto off_power; - ret = usb_add_phy_dev(&qphy->phy); if (ret) goto off_power;