From patchwork Tue Jul 16 09:54:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 169043 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp618962ilk; Tue, 16 Jul 2019 02:55:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqynw8RL2IHNFIgQeh2ruD8E6sGdhZEx5e+fdLzilQHHoGg7Sw21YPfkAV4pYS31ydnC73Co X-Received: by 2002:a65:5348:: with SMTP id w8mr32030428pgr.176.1563270908299; Tue, 16 Jul 2019 02:55:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563270908; cv=none; d=google.com; s=arc-20160816; b=if3jKD3XeZZNMia9lCCs6xJL1Z3dsHcUP+Q3HslCIbaybRxIhGN8sOr5ULMW7AP8mQ AI4Skrr9zLUkp5dLZEySIq1zcPLTUOk8JPXV4s4D0qVQPENLohgBsI9+6qg4QlK2ZrAk TIA2r5a/UzC0Fg3bb/E4JPtU8pTTl3s51hyn34eL9GucTVXmKEW3KNFSPkt1YHvW1Ydu fkQP5IgaNlYxScJ5uEEgEY0dvBHdavPslvCSsxInOCqlNcKUAitWuek5flXQGlRVX2hd +KhksIqeBryixVP0/w3r9+xnr9gZUaAzsfC6JxHLucauQxaTomzWmCcNgVjQ1kAmwZCU h2Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QxH+UbD9tCF0KwHpPpNeLuejcWOqKPoBzOiXe/lF/gk=; b=Vu5qoHGn3Y8YsdalMCfOFub+uKvgWZLkbFOL8aKFcQ44DPmZbvc6jGJg+opkF0IItj NsYjt4n6SLYh+9438W7tHokpWAgQk3JsFt5KQBUUYSxr5ZE6mqXzELBK5fLuUi/2p3MW 9EcvMbFbsbDj/rnOI7RIDWBVbP/tMsRXH2d77ZsKpxzi5IsnyqfpZwycK28reENy3jPb NttuqoOp9f+FnA0RSzOEATa+fsCRGuJsjEoXw5aV7DvNpQCu+6JDbGc4gLlswSTtpuJ3 fw+/3+8fk4fXg7kT3MjyL3yWAV2dVfMw91bpS2JdYMJKPmyWqxEQRrU6kwQzcDxzf4Rj +XZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FbuySQDt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7si18937972plv.130.2019.07.16.02.55.08; Tue, 16 Jul 2019 02:55:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FbuySQDt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732644AbfGPJzH (ORCPT + 29 others); Tue, 16 Jul 2019 05:55:07 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40996 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732520AbfGPJzG (ORCPT ); Tue, 16 Jul 2019 05:55:06 -0400 Received: by mail-pf1-f196.google.com with SMTP id m30so8858951pff.8 for ; Tue, 16 Jul 2019 02:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QxH+UbD9tCF0KwHpPpNeLuejcWOqKPoBzOiXe/lF/gk=; b=FbuySQDtO2afso3Zxf3ISnrj/v2hbYkqAmDXCqX8MPUrL4zaHSiS5SY9RiGeUl4DBd QYFEwKX1LxMARj+z317ztFPrv0F4GtsdtsOHbWT6MhcS3V4/9MxUrlc/V3gklYoUHOs0 a0Spyg/DNkDb/ExzrNrp0C/TIFJvN5XdZaLcrQXHaPYP7DRkPij+Gm8j2iS8Iyt81NpU RYd8ZR0FhyMs9jTWMMD516MbMp+JLzFaFrHFq19l7iCxCkC2OJKVFaH838fVGVaiF5Eu OFM4DMWboMqSSpHzjsdkOte3wz2s1/FFebxDMVpx5oLeFUyRxm8T3ZLw1FKyPtdKY9IX KCQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QxH+UbD9tCF0KwHpPpNeLuejcWOqKPoBzOiXe/lF/gk=; b=OJisu7+HxeNKlbYKdHeV7wUIsqNYHy4btmRsserczKS4k0oxKs66pjNp0cVaZAsvcS g7k21B55BTEQlpHga69MEr+19QpiyYISDZT/rggsxLzu7tM17+MF5xKpj1w6QAXEvjcU nqgXhtgCG2MJ6lxuSA33+/uA2jWi0LQBSDj6AQkCs46YhC+Rdc6VhbhI/dmQpV1eqANI Hbktfd4yLfUI/nZTETshWZ9LgaokRe4r9fwa/9uTU2sN1xKPsxjWVQWAXxLwbhg7P+jM GDf+JN2FVk5WYYi5mqWWSYENbvKddb7jj5QbskRlFAyyETy1hxKxWHQr7jQnRj5c32ll OtIQ== X-Gm-Message-State: APjAAAU9K9NdPlUxe9LDdSODD01Zy6O8+OAxpajo2U7sgXJiioDgxbDE ktFIKE9i9g2d3UQMNZvlmdNoGA== X-Received: by 2002:a63:ad07:: with SMTP id g7mr30139354pgf.405.1563270905182; Tue, 16 Jul 2019 02:55:05 -0700 (PDT) Received: from localhost ([122.172.28.117]) by smtp.gmail.com with ESMTPSA id r188sm33754776pfr.16.2019.07.16.02.55.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jul 2019 02:55:04 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/10] video: pxafb: Remove cpufreq policy notifier Date: Tue, 16 Jul 2019 15:24:47 +0530 Message-Id: X-Mailer: git-send-email 2.21.0.rc0.269.g1a574e7a288b In-Reply-To: References: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cpufreq policy notifier's CPUFREQ_ADJUST notification is going to get removed soon. The notifier callback pxafb_freq_policy() isn't doing anything apart from printing a debug message on CPUFREQ_ADJUST notification. There is no point in keeping an otherwise empty callback and registering the notifier. Remove it. Signed-off-by: Viresh Kumar --- drivers/video/fbdev/pxafb.c | 21 --------------------- drivers/video/fbdev/pxafb.h | 1 - 2 files changed, 22 deletions(-) -- 2.21.0.rc0.269.g1a574e7a288b diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index 4282cb117b92..f70c9f79622e 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -1678,24 +1678,6 @@ pxafb_freq_transition(struct notifier_block *nb, unsigned long val, void *data) } return 0; } - -static int -pxafb_freq_policy(struct notifier_block *nb, unsigned long val, void *data) -{ - struct pxafb_info *fbi = TO_INF(nb, freq_policy); - struct fb_var_screeninfo *var = &fbi->fb.var; - struct cpufreq_policy *policy = data; - - switch (val) { - case CPUFREQ_ADJUST: - pr_debug("min dma period: %d ps, " - "new clock %d kHz\n", pxafb_display_dma_period(var), - policy->max); - /* TODO: fill in min/max values */ - break; - } - return 0; -} #endif #ifdef CONFIG_PM @@ -2400,11 +2382,8 @@ static int pxafb_probe(struct platform_device *dev) #ifdef CONFIG_CPU_FREQ fbi->freq_transition.notifier_call = pxafb_freq_transition; - fbi->freq_policy.notifier_call = pxafb_freq_policy; cpufreq_register_notifier(&fbi->freq_transition, CPUFREQ_TRANSITION_NOTIFIER); - cpufreq_register_notifier(&fbi->freq_policy, - CPUFREQ_POLICY_NOTIFIER); #endif /* diff --git a/drivers/video/fbdev/pxafb.h b/drivers/video/fbdev/pxafb.h index b641289c8a99..86b1e9ab1a38 100644 --- a/drivers/video/fbdev/pxafb.h +++ b/drivers/video/fbdev/pxafb.h @@ -162,7 +162,6 @@ struct pxafb_info { #ifdef CONFIG_CPU_FREQ struct notifier_block freq_transition; - struct notifier_block freq_policy; #endif struct regulator *lcd_supply;