From patchwork Tue Dec 1 15:08:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 57510 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp2242117lbb; Tue, 1 Dec 2015 07:19:30 -0800 (PST) X-Received: by 10.55.195.216 with SMTP id r85mr86093444qkl.4.1448983170348; Tue, 01 Dec 2015 07:19:30 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id y193si50619531qka.92.2015.12.01.07.19.30; Tue, 01 Dec 2015 07:19:30 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dkim=neutral (body hash did not verify) header.i=@linaro-org.20150623.gappssmtp.com Received: by lists.linaro.org (Postfix, from userid 109) id E408361D55; Tue, 1 Dec 2015 15:19:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 4721A61E84; Tue, 1 Dec 2015 15:11:50 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 80EB661E13; Tue, 1 Dec 2015 15:11:46 +0000 (UTC) Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com [209.85.215.53]) by lists.linaro.org (Postfix) with ESMTPS id 943DA61E13 for ; Tue, 1 Dec 2015 15:08:30 +0000 (UTC) Received: by lffu14 with SMTP id u14so12107124lff.1 for ; Tue, 01 Dec 2015 07:08:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Si4/OsCcMjvyCO+2uoFDy7WK4vAqno0ZqoDe7sfJ6DA=; b=UjSCmjUlmFQ+O4Rz+BxdZQ4uN2oXXDIjtw+rNZ/IZ9Hj4g1UPa/rTj9M88aFNTGNUl kLK0+vWZw258tyGzS6wEsAAF2ImKNL9jBbL/DSKU1FAmyarJ0LymZtEbXGdwvnqlz5Jd wGSPLuTUh6Fn7eTj7L79rjKbegDsu6Vm6YgJ7xHG4m/Cg6S3RJ8L2E6oEQlFqVCY9jEo XVwa/znKsp7MgMYum+vjswIvQGRKaQzZ+CSYUP36PgNogfVHioP0jr07n+PIjuz/7kFu g3FJCih3CMeLeiXfyzBh8/Tw3IJb0C5s4fWanTId7h3Zoyncen+g7EFy2cqbHxjE0Y2P IQEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Si4/OsCcMjvyCO+2uoFDy7WK4vAqno0ZqoDe7sfJ6DA=; b=DKlVFclyEtJDjuAK5DiSx0nuoGFe0qHRy6ciQiCRC/JKBZWA9k7ZFdD0g+nXnsSg6g y444gP8gZYsppZp6DkJbfMTTRj1dCmGf4CjV/ehgqDVtONnIHp8sYpKk8FJvOQMu0x7r gfNH0MaSC0dP8igsWHdxORjsQwhXL62fN0QkeKGH76HsRXYuRkrI2vwzfvIVcYN/EWrD veqMrwe5llz3TfZPcVJR2didnO4IqHcEKOiDMbw9yjIP3zldWzI024hysgZ2b3eE5TOG HHG17TYjDJsxrf/hKrMsApf7tPQsTyujYJsa+ZMk0qEWb1oF1lltwI9GsumiGdDTBMOw 5b7A== X-Gm-Message-State: ALoCoQnniW7ojSplUhfpKR2ShR9WeGk+zgENeI96iP9rZDqxPpzvIhdPtEiGv4/Lx5luQopM/Ffz X-Received: by 10.112.142.98 with SMTP id rv2mr28421297lbb.72.1448982509539; Tue, 01 Dec 2015 07:08:29 -0800 (PST) Received: from localhost.localdomain ([212.90.60.8]) by smtp.gmail.com with ESMTPSA id i194sm8278535lfg.20.2015.12.01.07.08.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Dec 2015 07:08:28 -0800 (PST) From: Ivan Khoronzhuk To: lng-odp@lists.linaro.org Date: Tue, 1 Dec 2015 17:08:12 +0200 Message-Id: <1448982493-8236-9-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1448982493-8236-1-git-send-email-ivan.khoronzhuk@linaro.org> References: <1448982493-8236-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Topics: patch Subject: [lng-odp] [API-NEXT PATCH v5 8/9] test/example: use local time API as wall time X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" The local time API is supposed to behave like wall time now, so correct it in examples and tests. Signed-off-by: Ivan Khoronzhuk --- example/generator/odp_generator.c | 10 +++++----- test/performance/odp_pktio_perf.c | 26 ++++++++++++-------------- test/validation/pktio/pktio.c | 21 ++++++++------------- 3 files changed, 25 insertions(+), 32 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index 9d79f89..2de530d 100644 --- a/example/generator/odp_generator.c +++ b/example/generator/odp_generator.c @@ -586,7 +586,7 @@ static void *gen_recv_thread(void *arg) */ static void print_global_stats(int num_workers) { - odp_time_t start, wait, diff; + odp_time_t cur, wait, next; uint64_t pkts, pkts_prev = 0, pps, maximum_pps = 0; int verbose_interval = 20; odp_thrmask_t thrd_mask; @@ -595,7 +595,7 @@ static void print_global_stats(int num_workers) continue; wait = odp_time_local_from_ns(verbose_interval * ODP_TIME_SEC_IN_NS); - start = odp_time_local(); + next = odp_time_sum(odp_time_local(), wait); while (odp_thrmask_worker(&thrd_mask) == num_workers) { if (args->appl.number != -1 && @@ -604,11 +604,11 @@ static void print_global_stats(int num_workers) break; } - diff = odp_time_diff(odp_time_local(), start); - if (odp_time_cmp(wait, diff) > 0) + cur = odp_time_local(); + if (odp_time_cmp(next, cur) > 0) continue; - start = odp_time_local(); + next = odp_time_sum(cur, wait); if (args->appl.mode == APPL_MODE_RCV) { pkts = odp_atomic_load_u64(&counters.udp); diff --git a/test/performance/odp_pktio_perf.c b/test/performance/odp_pktio_perf.c index 2e49f50..8737bc8 100644 --- a/test/performance/odp_pktio_perf.c +++ b/test/performance/odp_pktio_perf.c @@ -305,8 +305,8 @@ static void *run_thread_tx(void *arg) int thr_id; odp_queue_t outq; pkt_tx_stats_t *stats; - odp_time_t start_time, cur_time, send_duration; - odp_time_t burst_start_time, burst_gap; + odp_time_t cur_time, send_time_end, send_duration; + odp_time_t burst_gap_end, burst_gap; uint32_t batch_len; int unsent_pkts = 0; odp_event_t tx_event[BATCH_LEN_MAX]; @@ -336,21 +336,19 @@ static void *run_thread_tx(void *arg) odp_barrier_wait(&globals->tx_barrier); cur_time = odp_time_local(); - start_time = cur_time; - burst_start_time = odp_time_diff(cur_time, burst_gap); - while (odp_time_cmp(odp_time_diff(cur_time, start_time), - send_duration) > 1) { + send_time_end = odp_time_sum(cur_time, send_duration); + burst_gap_end = cur_time; + while (odp_time_cmp(send_time_end, cur_time) > 0) { unsigned alloc_cnt = 0, tx_cnt; - if (odp_time_cmp(odp_time_diff(cur_time, burst_start_time), - burst_gap) > 1) { + if (odp_time_cmp(burst_gap_end, cur_time) > 0) { cur_time = odp_time_local(); if (!odp_time_cmp(idle_start, ODP_TIME_NULL)) idle_start = cur_time; continue; } - if (odp_time_cmp(idle_start, ODP_TIME_NULL)) { + if (odp_time_cmp(idle_start, ODP_TIME_NULL) > 0) { odp_time_t diff = odp_time_diff(cur_time, idle_start); stats->s.idle_ticks = @@ -359,7 +357,7 @@ static void *run_thread_tx(void *arg) idle_start = ODP_TIME_NULL; } - burst_start_time = odp_time_sum(burst_start_time, burst_gap); + burst_gap_end = odp_time_sum(burst_gap_end, burst_gap); alloc_cnt = alloc_packets(tx_event, batch_len - unsent_pkts); if (alloc_cnt != batch_len) @@ -597,13 +595,13 @@ static int setup_txrx_masks(odp_cpumask_t *thd_mask_tx, */ static void busy_loop_ns(uint64_t wait_ns) { - odp_time_t diff; - odp_time_t start_time = odp_time_local(); odp_time_t wait = odp_time_local_from_ns(wait_ns); + odp_time_t cur = odp_time_local(); + odp_time_t end_time = odp_time_sum(cur, wait); do { - diff = odp_time_diff(odp_time_local(), start_time); - } while (odp_time_cmp(wait, diff) > 0); + cur = odp_time_local(); + } while (odp_time_cmp(end_time, cur) > 0); } /* diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index 0a6592c..002c26b 100644 --- a/test/validation/pktio/pktio.c +++ b/test/validation/pktio/pktio.c @@ -336,18 +336,16 @@ static int destroy_inq(odp_pktio_t pktio) static odp_event_t queue_deq_wait_time(odp_queue_t queue, uint64_t ns) { - odp_time_t start, now, diff; + odp_time_t wait, end; odp_event_t ev; - start = odp_time_local(); - + wait = odp_time_local_from_ns(ns); + end = odp_time_sum(odp_time_local(), wait); do { ev = odp_queue_deq(queue); if (ev != ODP_EVENT_INVALID) return ev; - now = odp_time_local(); - diff = odp_time_diff(now, start); - } while (odp_time_to_ns(diff) < ns); + } while (odp_time_cmp(end, odp_time_local()) > 0); return ODP_EVENT_INVALID; } @@ -355,14 +353,14 @@ static odp_event_t queue_deq_wait_time(odp_queue_t queue, uint64_t ns) static odp_packet_t wait_for_packet(pktio_info_t *pktio_rx, uint32_t seq, uint64_t ns) { - odp_time_t start, now, diff; + odp_time_t wait_time, end; odp_event_t ev; odp_packet_t pkt; uint64_t wait; - start = odp_time_local(); wait = odp_schedule_wait_time(ns); - + wait_time = odp_time_local_from_ns(ns); + end = odp_time_sum(odp_time_local(), wait_time); do { pkt = ODP_PACKET_INVALID; @@ -388,10 +386,7 @@ static odp_packet_t wait_for_packet(pktio_info_t *pktio_rx, odp_packet_free(pkt); } - - now = odp_time_local(); - diff = odp_time_diff(now, start); - } while (odp_time_to_ns(diff) < ns); + } while (odp_time_cmp(end, odp_time_local()) > 0); CU_FAIL("failed to receive transmitted packet");