From patchwork Fri Jan 22 15:07:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 60152 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp737667lbb; Fri, 22 Jan 2016 07:07:52 -0800 (PST) X-Received: by 10.50.137.98 with SMTP id qh2mr4003048igb.74.1453475271954; Fri, 22 Jan 2016 07:07:51 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id sd6si5703289igb.19.2016.01.22.07.07.51; Fri, 22 Jan 2016 07:07:51 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 2DE76617F1; Fri, 22 Jan 2016 15:07:51 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=fail reason="verification failed; unprotected key" header.d=linaro.org header.i=@linaro.org header.b=THe+PBRt; dkim-adsp=none (unprotected policy); dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id ED158617D9; Fri, 22 Jan 2016 15:07:43 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 3C3C6617ED; Fri, 22 Jan 2016 15:07:42 +0000 (UTC) Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com [209.85.217.176]) by lists.linaro.org (Postfix) with ESMTPS id D2C19616CC for ; Fri, 22 Jan 2016 15:07:40 +0000 (UTC) Received: by mail-lb0-f176.google.com with SMTP id bc4so42624598lbc.2 for ; Fri, 22 Jan 2016 07:07:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=67OHmd2x+PK+XxmIrdrnASfRovZdZJtVuR9fDhx/u1U=; b=THe+PBRteusfMpSZaAYeWtFcJ56GpkR2bhiEDDHLZeFXwo/X5TpAWU/7IDYCEZcOdu BWAdekDCG4MZYx/oR1tt7c+1FyeotTO7JsogaqEWbLZjWl7Q2bB+srNDmFG31dZF7eL6 pMMYtfOx9JRUJNcItILAqiLYINR6k5TR3H+xg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=67OHmd2x+PK+XxmIrdrnASfRovZdZJtVuR9fDhx/u1U=; b=MAsqrGWEGPDlHqdCRm4zBdRaq5xHFRCqIRuTMo7QqVRhm47RMzQ7mDDyb1kvHbcCs3 3iRSsvh89+NBaPq8xoOQck2puBNtXUMH+RcOzY9S6BPAVQjAjYKmywvOxNnwOA1q3KZC HR7IMvYTu3wP/5ETcLi9g1j5DSpo0Znv/MGrmAq605O20wpfqwXdkS7rQ/TltRnTro6v DWaw0ppK3evZsvTRlzTQmqDIkW9FqHKLg4CgR0Tc/2/wJOM6yWjMFr/uaRZI1f2Ohj0r zWVkqgKBg5f1LoJ9S0N4I89y8SVARoJsVYTPbCafefNfAmbT+xXYTfy2S7IsyZw8+HBC lK2Q== X-Gm-Message-State: AG10YORZXHO13rrPjf9H6wh8CfPRDTCL2VjKtw6DIRN8yDOyUQgvbsPxEzXzlbXujGevguhDsRo= X-Received: by 10.112.164.97 with SMTP id yp1mr1420984lbb.30.1453475259058; Fri, 22 Jan 2016 07:07:39 -0800 (PST) Received: from localhost.localdomain ([195.238.92.128]) by smtp.gmail.com with ESMTPSA id h8sm918198lbd.48.2016.01.22.07.07.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Jan 2016 07:07:38 -0800 (PST) From: Ivan Khoronzhuk To: lng-odp@lists.linaro.org Date: Fri, 22 Jan 2016 17:07:31 +0200 Message-Id: <1453475251-8501-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: timers patch Subject: [lng-odp] [PATCH] linux-generic: timer: limit notification about resolution incorrectness X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" https://bugs.linaro.org/show_bug.cgi?id=1992 Signed-off-by: Ivan Khoronzhuk --- platform/linux-generic/odp_timer.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/platform/linux-generic/odp_timer.c b/platform/linux-generic/odp_timer.c index 4bab481..01339ad 100644 --- a/platform/linux-generic/odp_timer.c +++ b/platform/linux-generic/odp_timer.c @@ -168,6 +168,7 @@ typedef struct odp_timer_pool_s { char name[ODP_TIMER_POOL_NAME_LEN]; odp_shm_t shm; timer_t timerid; + int notify_overrun; } odp_timer_pool; #define MAX_TIMER_POOLS 255 /* Leave one for ODP_TIMER_INVALID */ @@ -239,6 +240,7 @@ static odp_timer_pool *odp_timer_pool_new( tp->num_alloc = 0; odp_atomic_init_u32(&tp->high_wm, 0); tp->first_free = 0; + tp->notify_overrun = 1; tp->tick_buf = (void *)((char *)odp_shm_addr(shm) + sz0); tp->timers = (void *)((char *)odp_shm_addr(shm) + sz0 + sz1); /* Initialize all odp_timer entries */ @@ -635,10 +637,14 @@ static void timer_notify(sigval_t sigval) int overrun; odp_timer_pool *tp = (odp_timer_pool *)sigval.sival_ptr; - overrun = timer_getoverrun(tp->timerid); - if (overrun) - ODP_ERR("\n\t%d ticks overrun on timer pool \"%s\", timer resolution too high\n", - overrun, tp->name); + if (tp->notify_overrun) { + overrun = timer_getoverrun(tp->timerid); + if (overrun) { + ODP_ERR("\n\t%d ticks overrun on timer pool \"%s\", timer resolution too high\n", + overrun, tp->name); + tp->notify_overrun = 0; + } + } #ifdef __ARM_ARCH odp_timer *array = &tp->timers[0];