From patchwork Tue Apr 5 16:16:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zoltan Kiss X-Patchwork-Id: 65107 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp560939lbc; Tue, 5 Apr 2016 09:17:35 -0700 (PDT) X-Received: by 10.107.169.228 with SMTP id f97mr13599276ioj.192.1459873055414; Tue, 05 Apr 2016 09:17:35 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id b20si30293829ioe.8.2016.04.05.09.17.34; Tue, 05 Apr 2016 09:17:35 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id A0EBA6162A; Tue, 5 Apr 2016 16:17:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id CC46F611FE; Tue, 5 Apr 2016 16:17:30 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 785AC60181; Tue, 5 Apr 2016 16:17:28 +0000 (UTC) Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by lists.linaro.org (Postfix) with ESMTPS id 848C5617C6 for ; Tue, 5 Apr 2016 16:17:27 +0000 (UTC) Received: by mail-wm0-f45.google.com with SMTP id 127so30008902wmu.1 for ; Tue, 05 Apr 2016 09:17:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AC8doYvOkpMGJ70xwT4hD/LMmIYRDEepqvrQkGfJWbA=; b=atcM7UmO6zKEXU3Uk0ezI+/fWH2vi4dC/8srxnReeYX4uochJILhSrdi5U0DM/diN4 GEU1ASQ3Eupq9fFp9M2DXxV+gM2d5rihlIwD9HlFnthcUyhNWp+FaBiUsbAij/vExOmK FEW4P6zXZP3w029QLdNRFPdk6xBVVIcm2C8/HhnJ5jC59iFNZ3jVg+tJNP5/RJ1b6g5k fWyvgxCXZN2NgQory84Z/XOuXCMgjAlWZJW7UBRGUiTqb1+heavavySTAB/JyWodu6Tq ZV43zQG1DGENxnS8nBRLhfgmK/WCIbPD/wr1hJdd3oAxwwWSB0RIWo/Fr4zCjqbGnrR6 CC8A== X-Gm-Message-State: AD7BkJKW/nG6hSs+Aypd1akiw9WBF89WoVE5PIDTUT1w2uqnZbBXgRYsFh+3dqw5djog+pKVCXI= X-Received: by 10.28.176.200 with SMTP id z191mr19117942wme.91.1459873046711; Tue, 05 Apr 2016 09:17:26 -0700 (PDT) Received: from localhost.localdomain ([195.11.233.227]) by smtp.googlemail.com with ESMTPSA id i206sm20183704wmf.1.2016.04.05.09.17.25 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Apr 2016 09:17:26 -0700 (PDT) From: Zoltan Kiss To: lng-odp@lists.linaro.org Date: Tue, 5 Apr 2016 17:16:42 +0100 Message-Id: <1459873002-31367-1-git-send-email-zoltan.kiss@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: patch Subject: [lng-odp] [PATCH] validation: pktio: remove octet check from stats test X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" This test sets up two interface and connect them to each other, so in theory these two numbers should be the same. However when you use a pktio which doesn't have full control of the interface, it could happen that other players, e.g. various services of the operating system start to send traffic out on the newly created interfaces. It won't be visible for ODP when going out, but coming in it will increase the counters. This breaks the test on ODP-DPDK, unnecessarily. On ODP-Linux it does not, because it checks the system level statistics, not the ODP level ones. Signed-off-by: Zoltan Kiss Reviewed-by: Bill Fischofer diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index cb403a6..73b702c 100644 --- a/test/validation/pktio/pktio.c +++ b/test/validation/pktio/pktio.c @@ -1256,7 +1256,6 @@ void pktio_test_statistics_counters(void) CU_ASSERT((stats[1].in_ucast_pkts == 0) || (stats[1].in_ucast_pkts >= (uint64_t)pkts)); CU_ASSERT(stats[0].out_ucast_pkts == stats[1].in_ucast_pkts); - CU_ASSERT(stats[0].out_octets == stats[1].in_octets); CU_ASSERT((stats[0].out_octets == 0) || (stats[0].out_octets >= (PKT_LEN_NORMAL * (uint64_t)pkts)));