From patchwork Thu Apr 21 18:48:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zoltan Kiss X-Patchwork-Id: 66406 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp312999qge; Thu, 21 Apr 2016 11:49:45 -0700 (PDT) X-Received: by 10.50.41.226 with SMTP id i2mr5559985igl.33.1461264585194; Thu, 21 Apr 2016 11:49:45 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id x76si5267995ioe.127.2016.04.21.11.49.44; Thu, 21 Apr 2016 11:49:45 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 9B58A6877C; Thu, 21 Apr 2016 18:49:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 134BF67593; Thu, 21 Apr 2016 18:49:40 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 2270468362; Thu, 21 Apr 2016 18:49:38 +0000 (UTC) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by lists.linaro.org (Postfix) with ESMTPS id 3A358674D9 for ; Thu, 21 Apr 2016 18:49:37 +0000 (UTC) Received: by mail-wm0-f54.google.com with SMTP id v188so256221189wme.1 for ; Thu, 21 Apr 2016 11:49:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fCVutPrKmWK1lmC5U6a7GHggHH+lgWpXPZEBhAHwGxU=; b=UGUFCZXXyUwauUSLskWUhGXYe57JZSBJY667a0UP0ySecI7T0n0EsvJ4CGFL89go63 iRYawqFIkRwZyjlbQrO/tKMEnog9Xtwo38UVODCih0V44bYxtrfXxWRn0V2OgHL+SC8L hiJihk2c8CUvIMkeKjOvbt/8PhLIhl7A4K2webXQ+KUtaoLStCkjMzh/R3r57+SDuiJt Lv9gdf0B5qK8gBT3yXCt3BC7TN4NRgz87aaDJuc71hkuSa5ML8mMrCVPGMndgZF7AqlB xoWOPMaddsETAXSrdSKOkxAoihb/O0if7TpRLJoyBuyIsAWN3rz7pUsdPFP0n1zIVYeQ OFqg== X-Gm-Message-State: AOPr4FW6W9YnqI/TPZ02SBkyAlhZdpZjNKhiKQUYpO7SxczmMmaAbKaoBznzN1VYEPc0GT9ozMo= X-Received: by 10.194.22.167 with SMTP id e7mr15990949wjf.9.1461264575655; Thu, 21 Apr 2016 11:49:35 -0700 (PDT) Received: from localhost.localdomain ([195.11.233.227]) by smtp.googlemail.com with ESMTPSA id s6sm4150574wjy.31.2016.04.21.11.49.34 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Apr 2016 11:49:35 -0700 (PDT) From: Zoltan Kiss To: lng-odp@lists.linaro.org Date: Thu, 21 Apr 2016 19:48:59 +0100 Message-Id: <1461264539-6798-1-git-send-email-zoltan.kiss@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: patch Subject: [lng-odp] [PATCH v2] validation: pktio: remove checks from stats test X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" This test sets up two interfaces and connect them to each other, so in theory these numbers should be the same. However when you use a pktio which doesn't have full control of the interface, it could happen that other players, e.g. various services of the operating system start to send traffic out on the newly created interfaces. It won't be visible for ODP when going out, but coming in it will increase the counters. This breaks the test on ODP-DPDK, unnecessarily. On ODP-Linux it does not, because it checks the system level statistics, not the ODP level ones. Signed-off-by: Zoltan Kiss --- v2: - fix commit log typo - remove pkt number check as well, and edit the title diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index d52a520..78cf44a 100644 --- a/test/validation/pktio/pktio.c +++ b/test/validation/pktio/pktio.c @@ -1258,8 +1258,6 @@ void pktio_test_statistics_counters(void) CU_ASSERT(ret == 0); CU_ASSERT((stats[1].in_ucast_pkts == 0) || (stats[1].in_ucast_pkts >= (uint64_t)pkts)); - CU_ASSERT(stats[0].out_ucast_pkts == stats[1].in_ucast_pkts); - CU_ASSERT(stats[0].out_octets == stats[1].in_octets); CU_ASSERT((stats[0].out_octets == 0) || (stats[0].out_octets >= (PKT_LEN_NORMAL * (uint64_t)pkts)));