From patchwork Thu Aug 18 14:52:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Uvarov X-Patchwork-Id: 74169 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp390461qga; Thu, 18 Aug 2016 07:52:24 -0700 (PDT) X-Received: by 10.233.235.143 with SMTP id b137mr2849042qkg.115.1471531944817; Thu, 18 Aug 2016 07:52:24 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id w3si1472396qkc.12.2016.08.18.07.52.24; Thu, 18 Aug 2016 07:52:24 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 0E6A260900; Thu, 18 Aug 2016 14:52:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id F381C608BD; Thu, 18 Aug 2016 14:52:20 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 099C9608D0; Thu, 18 Aug 2016 14:52:19 +0000 (UTC) Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by lists.linaro.org (Postfix) with ESMTPS id 1A7D2608B8 for ; Thu, 18 Aug 2016 14:52:18 +0000 (UTC) Received: by mail-lf0-f46.google.com with SMTP id g62so13457453lfe.3 for ; Thu, 18 Aug 2016 07:52:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=DGh4aYktQXIavUcWpAJDa6poAAEEgc59H33tpkDgULc=; b=Fb7O4y+OSZxhnbTF1RM3MSs3DCR6I9oWbd/0WgHLo0CP+0fnr9hFTbPxR4E9iBM8Tw LXExKUHfWvJohsQWE34//stsAc+nypH6nVN0YXNBlTqxh0IvQQ9QZF/A4cxCSNRUWSef NvwJX7RyFWlQnaczyNOgfGtzY62JAkUvmvvCe8PDxCtjEXrbj4wCL7Lt9jY2xkBYBOCS UrnBm9nEWp3z5Q/kqHhEA8pOFUYTSK1H1BBFd3ZF8Et3q4CHNnvt1dVnEBn3Plrwto8b A1Wgb3AD7I0VaczWNWQRKtN41CZeJf8soX3xNzZWJBNGovZKPi1Mnp9lPfxPlhfieC6g Qr4Q== X-Gm-Message-State: AEkoous9ntiMbkJmz0HqBwwilyyqWEt/c5lc84R8GLBoEZKICMAoO7tib/r0EuWPXLVRW13JJiI= X-Received: by 10.25.31.9 with SMTP id f9mr805023lff.34.1471531936803; Thu, 18 Aug 2016 07:52:16 -0700 (PDT) Received: from localhost.localdomain ([83.220.239.215]) by smtp.gmail.com with ESMTPSA id k63sm385552lfe.48.2016.08.18.07.52.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Aug 2016 07:52:16 -0700 (PDT) From: Maxim Uvarov To: lng-odp@lists.linaro.org Date: Thu, 18 Aug 2016 17:52:08 +0300 Message-Id: <1471531928-16150-1-git-send-email-maxim.uvarov@linaro.org> X-Mailer: git-send-email 2.7.1.250.gff4ea60 X-Topics: patch Subject: [lng-odp] [PATCH] linux-gen: socket mmap remove todo X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" socket mmap is not performance target for pktio. Improving performance for it needs more profiling and understanding it's work. Remove this todo because there is no plan to work on performance for socket mmap. https://bugs.linaro.org/show_bug.cgi?id=2409 Signed-off-by: Maxim Uvarov --- platform/linux-generic/pktio/socket_mmap.c | 1 - 1 file changed, 1 deletion(-) -- 2.7.1.250.gff4ea60 Reviewed-by: Mike Holmes diff --git a/platform/linux-generic/pktio/socket_mmap.c b/platform/linux-generic/pktio/socket_mmap.c index 8b24c99..9655668 100644 --- a/platform/linux-generic/pktio/socket_mmap.c +++ b/platform/linux-generic/pktio/socket_mmap.c @@ -345,7 +345,6 @@ static inline unsigned pkt_mmap_v2_tx(int sock, struct ring *ring, static void mmap_fill_ring(struct ring *ring, odp_pool_t pool_hdl, int fanout) { - /*@todo add Huge Pages support*/ int pz = getpagesize(); uint32_t pool_id; pool_entry_t *pool_entry;